From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-101.ptr.blmpb.com (sg-1-101.ptr.blmpb.com [118.26.132.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CCA2DA763 for ; Tue, 30 Dec 2025 02:41:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767062501; cv=none; b=POe8oUJKmQc8aha1uT3KXz/mIB5+65D2SKPZHtP/+nQdgeNJj6lRPwV98uSRZ9t6ubnaOTIz6YGVJDuvR/XiW95/5lBRzOXPqCaA5ZKJhbp6YME+TdFs+pMKmmRBKBjMKndB28Nd19ZYz24ZbR9BXkpsgfnFWIQ7EyGwmMddCXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767062501; c=relaxed/simple; bh=zlZ50MDGhzEG4wE4mYmDBp0p4TrM/l4IP83OGxNOCgY=; h=Message-Id:In-Reply-To:Mime-Version:References:To:Subject:Date:Cc: From:Content-Type; b=H4OBFTNOwDqH6MZD1AGqCoG/9uyW4qCp5q3hXs6WFhw7uijyWnRTYM/NyX/xX9vSC8BEwPX7j6t+g37XqdGG42kmQfJnQg8UNlTfdh4sn7zrrezDAzTITAjxvZjn1R4VhwBeBe8dpp1XGz1qvUUA6dusmTb29h2ER+JsKmq+8Ao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=B/fHVAtJ; arc=none smtp.client-ip=118.26.132.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="B/fHVAtJ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=2212171451; d=bytedance.com; t=1767062491; h=from:subject: mime-version:from:date:message-id:subject:to:cc:reply-to:content-type: mime-version:in-reply-to:message-id; bh=nuyBlAAtiqXwXnsGaaUroTpLCkz20Z8FGXFlzJIDhS0=; b=B/fHVAtJqmicDLAslkGTzU/m3ZJz2K+kBerRf9SRjEpGGfVmF80VvdealAEHjqjcUYwDjN 3C2ahUut/tzk3lZS1P4iev3/naQJC5G279pnZKd+a5M6EIQvSspZDE7jsKQYHAl9O1lY8p 5NEXIx9H9iGCRMu8T9lMhbf1c/8SzMNNhLXDyu83RqhK6Z7uLO+OBvwFkocwog2PycAVlf OWkVwsREcE2Ucu+ysHpGu0TBw9p0i5AAnc0WdcIijO2Xg+rsMpfqJZWk9VxexY5JCm1sdr CgvIf+8InNR3C4QQMyqf6uyWRRe0FRu80hDiZwbg0LXrszoBk2RtqBONwmHI0A== Message-Id: <20251230024118.5263-1-lizhe.67@bytedance.com> In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2 References: X-Lms-Return-Path: To: Subject: Re: [PATCH 4/8] mm/hugetlb: introduce per-node sysfs interface "zeroable_hugepages" Date: Tue, 30 Dec 2025 10:41:16 +0800 Content-Transfer-Encoding: quoted-printable Cc: , , , , , , From: "Li Zhe" X-Original-From: Li Zhe Content-Type: text/plain; charset=UTF-8 > On Mon, 29 Dec 2025 10:57:23 -0800, fvdl@google.com wrote: >=20 > On Mon, Dec 29, 2025 at 4:26=E2=80=AFAM Li Zhe w= rote: > > > > On Fri, 26 Dec 2025 10:51:01 -0800, fvdl@google.com wrote: > > > > > > +static ssize_t zeroable_hugepages_show(struct kobject *kobj, > > > > + struct kobj_attribute *attr= , char *buf) > > > > +{ > > > > + struct hstate *h; > > > > + unsigned long free_huge_pages_zero; > > > > + int nid; > > > > + > > > > + h =3D kobj_to_hstate(kobj, &nid); > > > > + if (WARN_ON(nid =3D=3D NUMA_NO_NODE)) > > > > + return -EPERM; > > > > + > > > > + free_huge_pages_zero =3D h->free_huge_pages_node[nid] - > > > > + h->free_huge_pages_zero_node[nid]; > > > > + > > > > + return sprintf(buf, "%lu\n", free_huge_pages_zero); > > > > +} > > > > + > > > > +static inline bool zero_should_abort(struct hstate *h, int nid) > > > > +{ > > > > + return (h->free_huge_pages_zero_node[nid] =3D=3D > > > > + h->free_huge_pages_node[nid]) || > > > > + list_empty(&h->hugepage_freelists[nid]); > > > > +} > > > > + > > > > +static void zero_free_hugepages_nid(struct hstate *h, > > > > + int nid, unsigned int nr_zero) > > > > +{ > > > > + struct list_head *freelist =3D &h->hugepage_freelists[nid]; > > > > + unsigned int nr_zerod =3D 0; > > > > + struct folio *folio; > > > > + > > > > + if (zero_should_abort(h, nid)) > > > > + return; > > > > + > > > > + spin_lock_irq(&hugetlb_lock); > > > > + > > > > + while (nr_zerod < nr_zero) { > > > > + > > > > + if (zero_should_abort(h, nid) || fatal_signal_pendi= ng(current)) > > > > + break; > > > > + > > > > + freelist =3D freelist->prev; > > > > + if (unlikely(list_is_head(freelist, &h->hugepage_fr= eelists[nid]))) > > > > + break; > > > > + folio =3D list_entry(freelist, struct folio, lru); > > > > + > > > > + if (folio_test_hugetlb_zeroed(folio) || > > > > + folio_test_hugetlb_zeroing(folio)) > > > > + continue; > > > > + > > > > + folio_set_hugetlb_zeroing(folio); > > > > + > > > > + /* > > > > + * Incrementing this here is a bit of a fib, since > > > > + * the page hasn't been cleared yet (it will be don= e > > > > + * immediately after dropping the lock below). But > > > > + * it keeps the count consistent with the overall > > > > + * free count in case the page gets taken off the > > > > + * freelist while we're working on it. > > > > + */ > > > > + h->free_huge_pages_zero_node[nid]++; > > > > + spin_unlock_irq(&hugetlb_lock); > > > > + > > > > + /* > > > > + * HWPoison pages may show up on the freelist. > > > > + * Don't try to zero it out, but do set the flag > > > > + * and counts, so that we don't consider it again. > > > > + */ > > > > + if (!folio_test_hwpoison(folio)) > > > > + folio_zero_user(folio, 0); > > > > + > > > > + cond_resched(); > > > > + > > > > + spin_lock_irq(&hugetlb_lock); > > > > + folio_set_hugetlb_zeroed(folio); > > > > + folio_clear_hugetlb_zeroing(folio); > > > > + > > > > + /* > > > > + * If the page is still on the free list, move > > > > + * it to the head. > > > > + */ > > > > + if (folio_test_hugetlb_freed(folio)) > > > > + list_move(&folio->lru, &h->hugepage_freelis= ts[nid]); > > > > + > > > > + /* > > > > + * If someone was waiting for the zero to > > > > + * finish, wake them up. > > > > + */ > > > > + if (waitqueue_active(&h->dqzero_wait[nid])) > > > > + wake_up(&h->dqzero_wait[nid]); > > > > + nr_zerod++; > > > > + freelist =3D &h->hugepage_freelists[nid]; > > > > + } > > > > + spin_unlock_irq(&hugetlb_lock); > > > > +} > > > > > > Nit: s/nr_zerod/nr_zeroed/ > > > > Thank you for the reminder. I will address this issue in v2. > > > > > Feels like the list logic can be cleaned up a bit here. Since the > > > zeroed folios are at the head of the list, and the dirty ones at the > > > tail, and you start walking from the tail, you don't need to check if > > > you circled back to the head - just stop if you encounter a prezeroed > > > folio. If you encounter a prezeroed folio while walking from the tail= , > > > that means that all other folios from that one to the head will also > > > be prezeroed already. > > > > Thank you for the thoughtful suggestion. Your line of reasoning is, > > in most situations, perfectly valid. Under extreme concurrency, > > however, a corner case can still appear. Imagine two processes > > simultaneously zeroing huge pages: Process A enters > > zero_free_hugepages_nid(), completes the zeroing of one huge page, > > and marks the folio in the list as pre-zeroed. Should Process B enter > > the same function moments later and decide to exit as soon as it > > meets a prezeroed folio, the intended parallel zeroing would quietly > > fall back to a single-threaded pace. >=20 > Hm, setting the prezeroed bit and moving the folio to the front of the > free list happens while holding hugetlb_lock. In other words, if you > encounter a folio with the prezeroed bit set while holding > hugetlb_lock, it will always be in a contiguous stretch of prezeroed > folios at the head of the free list. >=20 > Since the check for 'is this already prezeroed' is done while holding > hugetlb_lock, you know for sure that the folio is part of a list of > prezeroed folios at the head, and you can stop, right? Sorry for the confusion earlier. You're right, this does make zero_free_hugepages_nid() simpler. I'll update it in v2. Thanks, Zhe