From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 803D3946C for ; Tue, 30 Dec 2025 05:21:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767072092; cv=none; b=PQQ7TFFu4P+yKzmxczSBKc9UpQI7C1VHetr/LfM/x8hsLcr+OYltlULtIMq9e6LzcddowpLUlvuoL1BPlZDuvAwzEDqUL4FMgNlKrrfbvNnklPTiMJtSgzYvD6r7B5aulDhgeT10fSKN5lTL+W1HeGawUKZZ+8Z3q73xVCpgcnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767072092; c=relaxed/simple; bh=6WvBZmYDptv4U8cW4BmCM2Ed9GuaLWcHGh9kTfmIizA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ub47Can34aPG0NQk9VOaSXSZ10d4KLV8+85hsOT2BvZz5FfZnK1tvddWTbCmBsFACfnuWFjyex0wbvwPMgp8dBo9zlf207F0OUGPZ6mvlWZ0fjqfgDBWmPB7Ed7Zz98Egoo6Trmi9tdimxmvB1B6qz6YNqglLHJJkZyPi/ezd2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M8zq/7hQ; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M8zq/7hQ" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a102494058so52221455ad.0 for ; Mon, 29 Dec 2025 21:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767072089; x=1767676889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eNidwSG0yf8kDbKbE4MsUauW5ztIJtpjcHMpWs+5C74=; b=M8zq/7hQYnBmAvEFuoeMehk7t6C0N6rBgM56XKeQUsKfs6CMJEcNEHF8b1YAK8wNif p16mc7EHN0kqEVyDx1fm9Wo4jIkOKbfBPpQ0hFCmnTlRinrIwXghROzqN01G7oX+r4gs 7XSvwAwk2/noHTwMUg4f8lVlNV3qPN33FgrEybqsUQkeZ3PPOOPWv29WkQpXnivO8IyL IcTNi3HNNnvItqsnfrz6Ar7Vh02evnsqksBAByehNbWGnVJA5IiAXMHUckNa+nDNkhst gbh1t3SUco8rU5rWjh6VHIrBF4hTL2Hkg43X+L0hauC++sE7TI+6hBFi2d/p6++cwwkr jpqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767072089; x=1767676889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eNidwSG0yf8kDbKbE4MsUauW5ztIJtpjcHMpWs+5C74=; b=aJA6ljXOtvecC468yQHr6x1HJF/29+QDFPF77MajmukXI++GrWnUyrTWbiYnrQsbbf 6ZRBRfXvRL/E5pXOwTY6Coevv/iDpO3HSOu478DRq2nxBzA+7tymdnfdsPNWfhPDE0s/ AgAx+BY88hEhphvl84EI2ZGQdoS5jTqGbqDS48CzywWdXBATo0ZIM7sXHagzhRNlKgXR OrUz6XJksbBHJIBsu3/TxXsg4wI4wqMkvMwC78EnQV4amZKDxHVEL7/SqFnR9Dpd3hHh u89O0QlttrcBjmzG8PAc1uKAf4Q7jF8aioWfJv8qnBALgY9Uc9iE4kHzUhMeJkA+J/02 geZA== X-Gm-Message-State: AOJu0YwOqUG+a8bBUJuec7I3SeYMVNdDx7CMLFf3bV9cbFyh3D94IPC5 ucPzQrvJwdjyJIVjKSFWwQerOwgAf3lxQYosKFGi5F7VcOdi3ke1RWvQP/HBJA== X-Gm-Gg: AY/fxX5ghEeqNVpGcNOr5X4bV6ufyy/oMk4VXpaO+jdXmDhwLmc+aPdTtEnm+dgZMWV poQ+uHY03R29lzPfef4L56C7zn6rlv7I0j42y/exLrSzboLRyer0VufbL6smaKMAu4oCTP2M/bx H8gTMOjBf1VaRlorbfiaSoc8D2HowRz41iYPlQIjSqkRc5mubakCTCiQzHuNWPX45+Le69HHCja I9NXHl9joHj517y23ygFTaBgzsJfF+wx6BzCTyLKCFkC0SuvojjWRmyJFFo2gm2Rd8gg/C1qO+V MBK2p8eVlGtMNm7zCK1HX2TttkRuOk3MnHdgy8dkvwq0vkDwb05Aqpwe65m16872Pcn5kYd6Wmr NA9TSuvMPwE6kWmuM7hTehiwPvKfXO60BHxiBJV88IbfJKhGlL3SNw1t/elxyQjkkxlzS5oWG0n nLa3CW5SR2X2DUoQ20FyvJ//nBZD5aeGKwz237yHXRns8GUrx4qCbXgv5SBzJ00i2RmqFus6YN3 TdnCg== X-Google-Smtp-Source: AGHT+IEsl88WLrOitDxeexF58fFSiCQFUmI5BDiG2Uq2WLHmUEuNwU0nzVf0xtUy4Y4XLUI0uumZ1w== X-Received: by 2002:a17:902:cccd:b0:2a0:9238:881d with SMTP id d9443c01a7336-2a2cab15ebdmr433482245ad.15.1767072089479; Mon, 29 Dec 2025 21:21:29 -0800 (PST) Received: from aristo-PC.tail872496.ts.net (124-218-37-86.cm.dynamic.apol.com.tw. [124.218.37.86]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c66465sm291695105ad.15.2025.12.29.21.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Dec 2025 21:21:28 -0800 (PST) From: Aristo Chen X-Google-Original-From: Aristo Chen To: linux-kernel@vger.kernel.org Cc: jens.wiklander@linaro.org, sumit.garg@kernel.org, op-tee@lists.trustedfirmware.org, harshal.dev@oss.qualcomm.com, mario.limonciello@amd.com, Rijo-john.Thomas@amd.com, amirreza.zarrabi@oss.qualcomm.com, Aristo Chen Subject: [PATCH v4 1/2] tee: add revision sysfs attribute Date: Tue, 30 Dec 2025 13:17:58 +0800 Message-ID: <20251230051804.6230-1-aristo.chen@canonical.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251226131920.64582-1-aristo.chen@canonical.com> References: <20251226131920.64582-1-aristo.chen@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a generic TEE revision sysfs attribute backed by a new optional get_tee_revision() callback. The revision string is diagnostic-only and must not be used to infer feature support. Signed-off-by: Aristo Chen --- Documentation/ABI/testing/sysfs-class-tee | 10 +++++ drivers/tee/tee_core.c | 51 ++++++++++++++++++++++- include/linux/tee_core.h | 8 ++++ 3 files changed, 68 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-tee b/Documentation/ABI/testing/sysfs-class-tee index c9144d16003e..6e783210104e 100644 --- a/Documentation/ABI/testing/sysfs-class-tee +++ b/Documentation/ABI/testing/sysfs-class-tee @@ -13,3 +13,13 @@ Description: space if the variable is absent. The primary purpose of this variable is to let systemd know whether tee-supplicant is needed in the early boot with initramfs. + +What: /sys/class/tee/tee{,priv}X/revision +Date: Dec 2025 +KernelVersion: 6.18 +Contact: op-tee@lists.trustedfirmware.org +Description: + Read-only revision string reported by the TEE driver. This is + for diagnostics only and must not be used to infer feature + support. Use TEE_IOC_VERSION for capability and compatibility + checks. diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c index d65d47cc154e..0a00499811c1 100644 --- a/drivers/tee/tee_core.c +++ b/drivers/tee/tee_core.c @@ -1146,7 +1146,56 @@ static struct attribute *tee_dev_attrs[] = { NULL }; -ATTRIBUTE_GROUPS(tee_dev); +static const struct attribute_group tee_dev_group = { + .attrs = tee_dev_attrs, +}; + +static ssize_t revision_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct tee_device *teedev = container_of(dev, struct tee_device, dev); + char version[TEE_REVISION_STR_SIZE]; + int ret; + + if (!teedev->desc->ops->get_tee_revision) + return -ENODEV; + + ret = teedev->desc->ops->get_tee_revision(teedev, version, + sizeof(version)); + if (ret) + return ret; + + return sysfs_emit(buf, "%s\n", version); +} +static DEVICE_ATTR_RO(revision); + +static struct attribute *tee_revision_attrs[] = { + &dev_attr_revision.attr, + NULL +}; + +static umode_t tee_revision_attr_is_visible(struct kobject *kobj, + struct attribute *attr, int n) +{ + struct device *dev = kobj_to_dev(kobj); + struct tee_device *teedev = container_of(dev, struct tee_device, dev); + + if (teedev->desc->ops->get_tee_revision) + return attr->mode; + + return 0; +} + +static const struct attribute_group tee_revision_group = { + .attrs = tee_revision_attrs, + .is_visible = tee_revision_attr_is_visible, +}; + +static const struct attribute_group *tee_dev_groups[] = { + &tee_dev_group, + &tee_revision_group, + NULL +}; static const struct class tee_class = { .name = "tee", diff --git a/include/linux/tee_core.h b/include/linux/tee_core.h index 1f3e5dad6d0d..c214c38898ca 100644 --- a/include/linux/tee_core.h +++ b/include/linux/tee_core.h @@ -76,6 +76,9 @@ struct tee_device { /** * struct tee_driver_ops - driver operations vtable * @get_version: returns version of driver + * @get_tee_revision: returns revision string (diagnostic only); + * do not infer feature support from this, use + * TEE_IOC_VERSION instead * @open: called for a context when the device file is opened * @close_context: called when the device file is closed * @release: called to release the context @@ -98,6 +101,8 @@ struct tee_device { struct tee_driver_ops { void (*get_version)(struct tee_device *teedev, struct tee_ioctl_version_data *vers); + int (*get_tee_revision)(struct tee_device *teedev, + char *buf, size_t len); int (*open)(struct tee_context *ctx); void (*close_context)(struct tee_context *ctx); void (*release)(struct tee_context *ctx); @@ -292,6 +297,9 @@ struct tee_shm_pool *tee_shm_pool_alloc_res_mem(unsigned long vaddr, phys_addr_t paddr, size_t size, int min_alloc_order); +/* Size for TEE revision string buffer used by get_tee_revision(). */ +#define TEE_REVISION_STR_SIZE 128 + /** * tee_shm_pool_free() - Free a shared memory pool * @pool: The shared memory pool to free -- 2.43.0