From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF5C4E573 for ; Thu, 1 Jan 2026 01:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767231960; cv=none; b=XgtjxIPsRKupjVQY+VlJZv0mpYTh5/0euVDEWEh9bGoFXIhXdRMQyxUSXfxxELmDugul0WuNrOod6/XAMDfKJ+8fddrx+0Vb+z6/m+PGDk70Sf5OEkk9WXwUV3VbKpzq+R/vBfIf2o74kC1j5oSOemDdzacy5H4h3396Cl5kZcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767231960; c=relaxed/simple; bh=UNY0vPgkg3Epp4W9bRvRyXpNTLs9vlhObTqtdEhnGJw=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=WeR6cOwbwSOZiyly+AgD+hbuKMfOPdPjHhP5Mg7zLleAx2CKPbqLqUhdKF6JS1nkigxICy+Q5C73sRhw+fFvJtvFllliQkobpDJyiRie8Q5WTHPfy/RiTxWaZrgNuLiZtmq2YScB3T4nrnEGN/J8JOc8pdpALKlNPzhHIyIlGEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=2GuGVamo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="2GuGVamo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACE56C113D0; Thu, 1 Jan 2026 01:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1767231958; bh=UNY0vPgkg3Epp4W9bRvRyXpNTLs9vlhObTqtdEhnGJw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2GuGVamo5yhh08W9+NMzdq0RZNyFv6hR+k8OqAUJPLYGi+PWQ7SRBtw2n/xtKia/k R7IxzUNnhLAhUnKN52tuutfCohXrmw117ROmB0DuUpOrZ/lHiMYWlMMtJ+qjG0cH0c sG17frrd+zPq1C5jlgJmqArFxF9ddDwhdyCIvnr4= Date: Wed, 31 Dec 2025 17:45:58 -0800 From: Andrew Morton To: Dipendra Khadka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, rientjes@google.com, shakeel.butt@linux.dev Subject: Re: [PATCH] mm/oom_kill: Remove unnecessary integer promotion in format string Message-Id: <20251231174558.6a317049e8d08cc323ceca64@linux-foundation.org> In-Reply-To: <20251231122117.7683-1-kdipendra88@gmail.com> References: <20251230123336.ef33f8a55df71f3e3f782532@linux-foundation.org> <20251231122117.7683-1-kdipendra88@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 31 Dec 2025 12:21:17 +0000 Dipendra Khadka wrote: > Since the value is already promoted to int internally, using %d is > simpler and avoids the unnecessary cast. The checkpatch warning > confirms this: > > ``` > WARNING: Integer promotion: Using 'h' in '%hd' is unnecessary > #461: FILE: mm/oom_kill.c:461: > + pr_warn("%s invoked oom-killer: gfp_mask=%#x(%pGg), order=%d, oom_score_adj=%hd\n", > + current->comm, oc->gfp_mask, &oc->gfp_mask, oc->order, > + current->signal->oom_score_adj); > > > WARNING: Integer promotion: Using 'h' in '%hd' is unnecessary > #961: FILE: mm/oom_kill.c:961: > + pr_err("%s: Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB, UID:%u pgtables:%lukB oom_score_adj:%hd\n", > + message, task_pid_nr(victim), victim->comm, K(mm->total_vm), > + K(get_mm_counter(mm, MM_ANONPAGES)), > + K(get_mm_counter(mm, MM_FILEPAGES)), > + K(get_mm_counter(mm, MM_SHMEMPAGES)), > + from_kuid(&init_user_ns, task_uid(victim)), > + mm_pgtables_bytes(mm) >> 10, victim->signal->oom_score_adj); > ``` > > Checkpatch flags the 'h' modifier as unnecessary for this reason, > and many other subsystems have moved to using %d for promoted types. > Hence, I think this patch aligns with kernel coding practices. hm, OK, this code is pretty lonely. hp2:/usr/src/linux-6.19-rc3> grep -r "%hd" . | wc -l 50 Consistency is good.