From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbdAZHPt (ORCPT ); Thu, 26 Jan 2017 02:15:49 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:39142 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787AbdAZHPs (ORCPT ); Thu, 26 Jan 2017 02:15:48 -0500 X-AuditID: cbfec7f4-f79716d000006f65-0c-5889a21ff733 Subject: Re: [PATCH 1/2] soc: samsung: pmu: Remove unused and duplicated defines To: Krzysztof Kozlowski , Kukjin Kim , Javier Martinez Canillas , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sylwester Nawrocki From: Marek Szyprowski Message-id: <20251f7e-310a-223e-3a35-7df5bc30352a@samsung.com> Date: Thu, 26 Jan 2017 08:15:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-version: 1.0 In-reply-to: <20170125193452.31768-1-krzk@kernel.org> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsWy7djPc7ryizojDNZ2mVm8ebuGyaL/8Wtm i/PnN7BbbHp8jdXi8q45bBYzzu9jsjj8pp3Vgd1j06pONo/NS+o9tvTfZffo27KK0ePzJrkA 1igum5TUnMyy1CJ9uwSujN93fzMWNLBVHP35i6WB8TVLFyMnh4SAicSNpQfZIGwxiQv31gPZ XBxCAksZJXr6JzNDOJ8ZJVrvdDDCdBxa0A9VtYxRYsu/j6wQznNGiYs9L9lBqoQFgiS+PdnC DpIQEXjBKPFp7jVmkASzgL7E3C1LwUaxCRhKdL3tAlvOK2An8ejsWbAaFgFViWfv17CC2KIC MRINp36yQ9QISvyYfA/scE4BU4lHUw4xQsy0knj2r5UVwpaX2LzmLTPEqYvYJbqfmHQxcgDZ shKbDkCFXSRm9MB8Iyzx6vgWdghbRqKz4yAThN3PKNHUqg1hz2CUOPeWF8K2ljh8/CLUKj6J SdumM0OM55XoaBOCKPGQ2Lt0OdR4R4nDHUuggdXBKPFi3z/GCYzys5B8MwvJB7OQfLCAkXkV o0hqaXFuemqxiV5xYm5xaV66XnJ+7iZGYDo5/e/4lx2Mi49ZHWIU4GBU4uE9sKMjQog1say4 MvcQowQHs5IIL3tFZ4QQb0piZVVqUX58UWlOavEhRmkOFiVx3j0LroQLCaQnlqRmp6YWpBbB ZJk4OKUaGKcvzdc+vK3Y5EjE7AVHp7ZtnXBzn0x4Q2iQS4DYzBmnjb6IzRZpjFNaVCVuMivF 87P5zHV8/ocjt0jNsxe0jAg/t3Lx2pu1zMraPEyPNyx5esAwNuZHhF+Zzl0ByWcL7tZw1Qh9 WPXu3POPaSdjS9kT8372Wi0//Nxvgzkv8/2sIx++Kh2Z1KzEUpyRaKjFXFScCACEJtYkIwMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsVy+t/xq7rxizojDHacErd483YNk0X/49fM FufPb2C32PT4GqvF5V1z2CxmnN/HZHH4TTurA7vHplWdbB6bl9R7bOm/y+7Rt2UVo8fnTXIB rFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpwcA5w D1bSt0twy/h99zdjQQNbxdGfv1gaGF+zdDFyckgImEgcWtDPBmGLSVy4tx7I5uIQEljCKLG8 5TIjhPOcUeJD73JWkCphgQCJdT8vgFWJCLxglFi7bRsrRFUXo8TZ6fuYQKqYBfQl5m5Zyghi swkYSnS97QLbwStgJ/Ho7FlmEJtFQFXi2fs1YFNFBWIk3q5fzg5RIyjxY/I9sPs4BUwlHk05 xAgx00ziy8vDrBC2vMTmNW+ZJzAKzELSMgtJ2SwkZQsYmVcxiqSWFuem5xYb6hUn5haX5qXr JefnbmIExte2Yz8372C8tDH4EKMAB6MSD++BHR0RQqyJZcWVuYcYJTiYlUR42Ss6I4R4UxIr q1KL8uOLSnNSiw8xmgI9MZFZSjQ5Hxj7eSXxhiaG5paGRsYWFuZGRkrivCUfroQLCaQnlqRm p6YWpBbB9DFxcEo1MFouVzDYkyGnYMm2s2dZoU/tjnf/p2e/zd1udl+oP3kfd3a3aFm1T9Pi mqib2fWnU9+KsL4SyHXa/rxzh9XxOHXvCxvumlXlBe9aFlmlJycopMR1b8H8xwtf7npyuO+2 5bS2UjPnP9+PhPTsutJQbhW7YsmtyqqKCYVNDslbPDW29DdO87uVrcRSnJFoqMVcVJwIAIFz WtPFAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170126071543eucas1p149fbcb57d467b1badd2fc121c7795d77 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170125193513epcas4p3630dd48974bedbe07a74a21d11500fe1 X-RootMTR: 20170125193513epcas4p3630dd48974bedbe07a74a21d11500fe1 References: <20170125193452.31768-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2017-01-25 20:34, Krzysztof Kozlowski wrote: > The exynos-regs-pmu.h was never a complete list of PMU registers. It > contained a lot of holes for registers which are not used. However, a > lot of unused defines came with porting the code from vendor kernel. > > Few of defines were also duplicated. > > Remove them so the file will be slightly smaller. > > Signed-off-by: Krzysztof Kozlowski Thanks for the cleanup! If you are touching this, you may also want to unify multiple headers for the Exynos PMU regs: include/linux/soc/samsung/exynos-regs-pmu.h linux/mfd/syscon/exynos4-pmu.h linux/mfd/syscon/exynos5-pmu.h > [...] Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland