From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Melody Olvera <quic_molvera@quicinc.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Abel Vesa <abelvesa@kernel.org>, Abel Vesa <abelvesa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rajendra Nayak <quic_rjendra@quicinc.com>,
manivannan.sadhasivam@oss.qualcomm.com,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
stable@vger.kernel.org
Subject: [PATCH 2/7] clk: qcom: gcc-sa8775p: Do not turn off PCIe GDSCs during gdsc_disable()
Date: Fri, 02 Jan 2026 15:13:02 +0530 [thread overview]
Message-ID: <20260102-pci_gdsc_fix-v1-2-b17ed3d175bc@oss.qualcomm.com> (raw)
In-Reply-To: <20260102-pci_gdsc_fix-v1-0-b17ed3d175bc@oss.qualcomm.com>
With PWRSTS_OFF_ON, PCIe GDSCs are turned off during gdsc_disable(). This
can happen during scenarios such as system suspend and breaks the resume
of PCIe controllers from suspend.
So use PWRSTS_RET_ON to indicate the GDSC driver to not turn off the GDSCs
during gdsc_disable() and allow the hardware to transition the GDSCs to
retention when the parent domain enters low power state during system
suspend.
Fixes: 08c51ceb12f7 ("clk: qcom: add the GCC driver for sa8775p")
Cc: stable@vger.kernel.org
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
drivers/clk/qcom/gcc-sa8775p.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sa8775p.c b/drivers/clk/qcom/gcc-sa8775p.c
index e7425e82c54f2355015b58f5a25f11d2fb5020e6..b2e8639e9f09194fccde927466dab0f179e08e01 100644
--- a/drivers/clk/qcom/gcc-sa8775p.c
+++ b/drivers/clk/qcom/gcc-sa8775p.c
@@ -4211,7 +4211,7 @@ static struct gdsc pcie_0_gdsc = {
.pd = {
.name = "pcie_0_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
.flags = VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
};
@@ -4225,7 +4225,7 @@ static struct gdsc pcie_1_gdsc = {
.pd = {
.name = "pcie_1_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
.flags = VOTABLE | RETAIN_FF_ENABLE | POLL_CFG_GDSCR,
};
--
2.34.1
next prev parent reply other threads:[~2026-01-02 9:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 9:43 [PATCH 0/7] clk: qcom: gcc: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 1/7] clk: qcom: gcc-sc7280: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` Krishna Chaitanya Chundru [this message]
2026-01-02 9:43 ` [PATCH 3/7] clk: qcom: gcc-sm8750: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 4/7] clk: qcom: gcc-glymur: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 5/7] clk: qcom: gcc-qcs8300: " Krishna Chaitanya Chundru
2026-01-02 9:43 ` [PATCH 6/7] clk: qcom: gcc-x1e80100: " Krishna Chaitanya Chundru
2026-01-02 9:49 ` Bryan O'Donoghue
2026-01-02 9:43 ` [PATCH 7/7] clk: qcom: gcc-kaanapali: " Krishna Chaitanya Chundru
2026-01-02 11:34 ` [PATCH 0/7] clk: qcom: gcc: " Konrad Dybcio
2026-01-02 11:36 ` Krishna Chaitanya Chundru
2026-01-02 11:39 ` Konrad Dybcio
2026-01-02 13:19 ` Krishna Chaitanya Chundru
2026-01-02 13:57 ` Konrad Dybcio
2026-01-02 16:12 ` Bryan O'Donoghue
2026-01-05 4:54 ` Krishna Chaitanya Chundru
2026-01-05 5:14 ` Manivannan Sadhasivam
2026-01-05 9:47 ` Stephan Gerhold
2026-01-08 5:58 ` Manivannan Sadhasivam
2026-01-09 15:49 ` Bjorn Andersson
2026-01-09 17:33 ` Stephan Gerhold
2026-01-09 18:48 ` Bjorn Andersson
2026-01-05 5:15 ` Manivannan Sadhasivam
2026-01-30 10:36 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102-pci_gdsc_fix-v1-2-b17ed3d175bc@oss.qualcomm.com \
--to=krishna.chundru@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=mturquette@baylibre.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=stable@vger.kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®