From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/T2H and RZ/N2H SoCs
Date: Fri, 2 Jan 2026 12:20:51 +0100 [thread overview]
Message-ID: <20260102-petite-gentle-wasp-81bbb8@quoll> (raw)
In-Reply-To: <20251230115814.53536-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Tue, Dec 30, 2025 at 11:58:13AM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document the CAN-FD controller used on the RZ/T2H and RZ/N2H SoCs. The
> CAN-FD IP is largely compatible with the R-Car Gen4 block, but differs
> in that AFLPN and CFTML are different, there is no reset line for the IP,
> and it only supports two channels.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> v1->v2:
> - No changes made.
> ---
> .../bindings/net/can/renesas,rcar-canfd.yaml | 26 ++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index fb709cfd26d7..4a83e9e34d67 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -50,6 +50,12 @@ properties:
> - renesas,r9a09g057-canfd # RZ/V2H(P)
> - const: renesas,r9a09g047-canfd
>
> + - const: renesas,r9a09g077-canfd # RZ/T2H
That's part of other enum with single compatibles.
> +
> + - items:
> + - const: renesas,r9a09g087-canfd # RZ/N2H
> + - const: renesas,r9a09g077-canfd
> +
> reg:
> maxItems: 1
>
> @@ -179,7 +185,6 @@ required:
> - clocks
> - clock-names
> - power-domains
> - - resets
> - assigned-clocks
> - assigned-clock-rates
> - channel0
> @@ -243,11 +248,30 @@ allOf:
> minItems: 2
> maxItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a09g077-canfd
> + then:
> + properties:
> + interrupts:
> + maxItems: 8
> +
> + interrupt-names:
> + maxItems: 8
> +
> + resets: false
> + else:
> + required:
> + - resets
Why is this de-synced with reset-names? Properties are supposed to
behave the same way, not once requiring resets other time requiring
reset-names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-02 11:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 11:58 [PATCH v2 0/4] Add CANFD support to R9A09G056/057/077/087 SoCs Prabhakar
2025-12-30 11:58 ` [PATCH v2 1/4] dt-bindings: can: renesas,rcar-canfd: Specify reset-names Prabhakar
2026-01-02 11:16 ` Krzysztof Kozlowski
2026-01-06 17:17 ` Lad, Prabhakar
2026-01-06 17:39 ` Rob Herring
2026-01-06 21:53 ` Lad, Prabhakar
2026-01-07 8:25 ` Krzysztof Kozlowski
2026-01-07 21:15 ` Lad, Prabhakar
2025-12-30 11:58 ` [PATCH v2 2/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/V2H(P) and RZ/V2N SoCs Prabhakar
2026-01-02 11:17 ` Krzysztof Kozlowski
2026-01-07 16:02 ` Geert Uytterhoeven
2025-12-30 11:58 ` [PATCH v2 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/T2H and RZ/N2H SoCs Prabhakar
2026-01-02 11:20 ` Krzysztof Kozlowski [this message]
2026-01-06 17:26 ` Lad, Prabhakar
2026-01-07 8:28 ` Krzysztof Kozlowski
2026-01-08 19:25 ` Lad, Prabhakar
2026-01-07 16:37 ` Geert Uytterhoeven
2025-12-30 11:58 ` [PATCH v2 4/4] can: rcar_canfd: Add RZ/T2H support Prabhakar
2026-01-07 16:37 ` Geert Uytterhoeven
2026-01-08 10:13 ` Lad, Prabhakar
2026-01-08 10:20 ` Geert Uytterhoeven
2026-01-08 10:34 ` Lad, Prabhakar
2026-01-16 9:08 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102-petite-gentle-wasp-81bbb8@quoll \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®