mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org
Cc: sshegde@linux.ibm.com, linux-kernel@vger.kernel.org,
	kprateek.nayak@amd.com, juri.lelli@redhat.com,
	vschneid@redhat.com, tglx@linutronix.de,
	dietmar.eggemann@arm.com, anna-maria@linutronix.de,
	frederic@kernel.org, wangyang.guo@intel.com
Subject: [PATCH v2 2/3] sched/fair: Change likelyhood of nohz.nr_cpus and do stats update if its due
Date: Fri,  2 Jan 2026 18:17:43 +0530	[thread overview]
Message-ID: <20260102124744.360872-3-sshegde@linux.ibm.com> (raw)
In-Reply-To: <20260102124744.360872-1-sshegde@linux.ibm.com>

These days most of the system have multi cores. The likelyhood of
at least one or more CPUs in nohz (idle state) is higher.
So move likely to unlikely.

Allow stats balancing to complete when there are no nr_cpus as the check
happens later. This may do an additional stats based load balancing
which would reset has_blocked_load. Code also looks saner by removing
that uncharactiristic return in between.

Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
---
 kernel/sched/fair.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index cd1c78d2c272..5ceb9126d441 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -12456,10 +12456,10 @@ static void nohz_balancer_kick(struct rq *rq)
 
 	/*
 	 * None are in tickless mode and hence no need for NOHZ idle load
-	 * balancing:
+	 * balancing, do stats update if its due
 	 */
-	if (likely(!atomic_read(&nohz.nr_cpus)))
-		return;
+	if (unlikely(!atomic_read(&nohz.nr_cpus)))
+		goto out;
 
 	if (rq->nr_running >= 2) {
 		flags = NOHZ_STATS_KICK | NOHZ_BALANCE_KICK;
-- 
2.47.3


  parent reply	other threads:[~2026-01-02 12:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02 12:47 [PATCH v2 0/3] sched/fair: improve nohz fields for large systems Shrikanth Hegde
2026-01-02 12:47 ` [PATCH v2 1/3] sched/fair: Move checking for nohz cpus after time check Shrikanth Hegde
2026-01-06 15:50   ` Peter Zijlstra
2026-01-06 15:57     ` Shrikanth Hegde
2026-01-02 12:47 ` Shrikanth Hegde [this message]
2026-01-05  3:52   ` [PATCH v2 2/3] sched/fair: Change likelyhood of nohz.nr_cpus and do stats update if its due K Prateek Nayak
2026-01-05  5:07     ` Shrikanth Hegde
2026-01-05  6:41       ` K Prateek Nayak
2026-01-05 10:39         ` Shrikanth Hegde
2026-01-06  3:03           ` K Prateek Nayak
2026-01-06  4:23             ` Shrikanth Hegde
2026-01-06  5:50               ` K Prateek Nayak
2026-01-06  6:44                 ` Shrikanth Hegde
2026-01-02 12:47 ` [PATCH v2 3/3] sched/fair: Remove nohz.nr_cpus and use weight of cpumask instead Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102124744.360872-3-sshegde@linux.ibm.com \
    --to=sshegde@linux.ibm.com \
    --cc=anna-maria@linutronix.de \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wangyang.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®