From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBD4826D4CA for ; Fri, 2 Jan 2026 23:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767395139; cv=none; b=D82okUqCnz8e2zYG/uprONjQQDs40NJJgtioUX4G52K4uLRA/meLKyb/XnfhNCU0se8oT9Qbjmfn5qw2KdOAMgfLC26OdP9KdAw/dGLGi4U/9hchm7jCbtaLdXmBn1Hm2DDXBaN+iFjz/m+EN9l3MsvBBBKhcxLUoiItm0JXtmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767395139; c=relaxed/simple; bh=zN6ndZGvkiNHADlj/UU03wS0UCkcDL6Fte98pyU5dUA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RAnjzzXb/qAQ3kjsz7N0eqAKDMwDG9S1JIXxEo5+aU2th02YU9Pma/M++0IPGUoLHaw7zYyM+9zGi13tzazyTQQK8I2kW+/1++B5kMFQ0rVO7iHu3HmAQvLo000Un32Heb5NPXUTJwZKSIHq/EMyzZeWlZ8nnvBRxlKHdKT/YYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YogeuQGi; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YogeuQGi" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47a8195e515so75075925e9.0 for ; Fri, 02 Jan 2026 15:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767395136; x=1767999936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gATuC38XoDqmbs1Y0VN60Xh8p2YBvlk1d2ihfjSJrZM=; b=YogeuQGivcC5qzhq0j3ioAPEk1i5zfHMpabSxKDXKwpN0LlFjBF9DI1i2MakPaE1cr Id1ela4IzWjRebzHWigDPWs8ZZPPCHZHjYQEouaQQNRIDhoyktWRPjQXR/bz4W4FXqXj Q45+eCTSqq343sdWjr1UwsJT0dXVy4GvkIZjUlHmR2mdMBdaa7xbNq0mNrDzh+nRbPTG RrAy+lmkW7mHgONja210mnS0yUmk2DO/SPCCHi/JDh1vJcfgU7ziRteBze8YxF4PNnd5 rT5qpt+0JMRvBq53LAtEeYDFe2kDI8akeHededh+go/j4lI7AnKGqCJinEo/8C9qrtDm QkbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767395136; x=1767999936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gATuC38XoDqmbs1Y0VN60Xh8p2YBvlk1d2ihfjSJrZM=; b=GD7nJv4AiPbcQpuGBgbTbRVQ8UbLIj9Sohv5OyQ4YcW8E8Gzs+/jyh9zdu0aLd21e1 m6UqSwjY/JkaUSNh2eHzMRC2LtiAT+ji9zAVGIh6sAi3bQG8VwFfJ3n4UjEPMgRP9oPq sRIyw24cf2qPopVnYeeck7DDohj0Gu22WVcfURGShp0GrpxBOBCwJgGotOcy9xBrWIeu FbXx1OfKJ/61yrVqRPQSdWWAcAYT0kDADBudvI6IEsw2/bhsINCe58yFTBQ7nkvGpjKj ZwdpQBomXNeaDYg9cyImgyWj6X+PXKjh+wTqo5WsIj74Civ8+dHKdWsGz8b+5u2t1Ihe 8F4Q== X-Forwarded-Encrypted: i=1; AJvYcCWcKxkzWz7UUxdJllgCRvFp6LOibw/yxcR8AY4u4qQasDfuz1iFe9QKYk484rn8rlsSHzjtwZNWV2KFdjE=@vger.kernel.org X-Gm-Message-State: AOJu0YwUPrz9p2KACGSA2iKXvsK82bSrcY/miQsS6APbpIVfqdXzPALS P+yjESFmaJtHrpq3Tt1S5YlGzNpFSGc7gQJAV/yHDMcsdeMJk8FQ6yoj X-Gm-Gg: AY/fxX6mPj021MJpb+c/uS+a6A5A9/DrAY/9t04MfoYq3N8HUyD2/GDjimsEuu4994T L0BNAbBgKO1JDqCzkofN0mQgZLRAWWuUKi80YlgY+rGALBDIfaN7DaYc6YDuM8/JDj4YOElQAOI EKHbQUDc6H7yTuQ7/aZbAeDHB0wv+Zys46yKqjpuSQx2bnk9YzkbLLCI5yx1/flQNLexqJY8dUQ WfVcA+6NnLv1d5NEqx9FYjRvVq1jCXYZgemKIhe0uZKNsyIPid/yTKYC+TDxtSyiKdU2saYSc4z mrbFMA+nWVdEhiSiQ4HXaTKrYRBt1AxbnxNT48GZkANyFlWHOnvk3V0OmMQSc60QKbF1FC4fEWj a6PAU6hKq1SySbRo5Yemcgl2fXnQHU5VcrK4lSnX6/4xH37rZ355Dp/agZghEN+xP6fqvEP1pkc KH9iFmJ9OyN5ykN+Q50jonVFQ/zk7zU8lhEEtSDqxejU3E75P0hWTR X-Google-Smtp-Source: AGHT+IH496nx63x7Ywh5WtJLuS+N+LqIyhglkqM7MecPJHigBzdkDAY96pkr8teZzNbzWf1tn9XsUA== X-Received: by 2002:a05:600d:108:20b0:477:214f:bd95 with SMTP id 5b1f17b1804b1-47d1c036d6cmr411887275e9.23.1767395136005; Fri, 02 Jan 2026 15:05:36 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea2278dsm88571673f8f.18.2026.01.02.15.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 15:05:35 -0800 (PST) Date: Fri, 2 Jan 2026 23:05:33 +0000 From: David Laight To: Matthew Wilcox Cc: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , Russell King , Andrew Morton , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , stable@vger.kernel.org Subject: Re: [PATCH] ARM: fix memset64() on big-endian Message-ID: <20260102230533.4fb1d8ef@pumpkin> In-Reply-To: References: <20260102-armeb-memset64-v1-1-9aa15fb8e820@linutronix.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 2 Jan 2026 15:22:20 +0000 Matthew Wilcox wrote: > On Fri, Jan 02, 2026 at 08:15:46AM +0100, Thomas Wei=C3=9Fschuh wrote: > > On big-endian systems the 32-bit low and high halves need to be swapped, > > for the underlying assembly implemenation to work correctly. =20 >=20 > Heh. In my heart, ARM will always be a litte-endian architecture. > I'm not really surprised this bug took, er, 8 years to show up; big-endian > arm is rare enough and memset64() isn't much used on 32-bit systems. > And it turns out that many of the users pass a constant 0 as the value, > which was kind of not the point, but it seems to be an easier API to > use than memset, so whatever ;-) I'd have thought that part of the point of memset64() was to remove all the 'alignment' and 'tail handling' that a normal memset() has. Clearly someone thought otherwise :-) David >=20 > > Fixes: fd1d362600e2 ("ARM: implement memset32 & memset64") > > Cc: stable@vger.kernel.org > > Signed-off-by: Thomas Wei=C3=9Fschuh = =20 >=20 > Reviewed-by: Matthew Wilcox (Oracle) >=20