From: Dipendra Khadka <kdipendra88@gmail.com>
To: david.laight.linux@gmail.com
Cc: dhowells@redhat.com, kdipendra88@gmail.com,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
marc.dionne@auristor.com
Subject: Re: [PATCH] fs/afs: Remove unnecessary integer promotion in format strings
Date: Sat, 3 Jan 2026 09:05:00 +0000 [thread overview]
Message-ID: <20260103090500.57460-1-kdipendra88@gmail.com> (raw)
In-Reply-To: <20260102224006.39c8398e@pumpkin>
>Fairly pointless churn for existing code.
>
>The message isn't really right either, 'short integers' are always
>promoted to 'int' whenever they are used.
>There is nothing special about variadic functions.
Yeah , I accept that but this patch is for consistency.
Other subsytems are migrating. There are very small
printk statements with "%hd","%hx" and "%hu".
root@ubuntu:/home/ubuntu/linux# git grep "%hd" . | wc -l
48
root@ubuntu:/home/ubuntu/linux# git log --oneline
b69053dd3ffb (HEAD -> master, origin/master, origin/HEAD) wifi: mt76: Remove blank line after mt792x firmware version dmesg
af7809f037e6 Revert "wifi: mt76: Strip whitespace from build ddate"
9528d5c091c5 Merge tag 'platform-drivers-x86-v6.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
349bd28a86f2 Merge tag 'vfio-v6.19-rc4' of https://github.com/awilliam/linux-vfio
Best Regards,
Dipendra
prev parent reply other threads:[~2026-01-03 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 11:57 Dipendra Khadka
2026-01-02 22:40 ` David Laight
2026-01-03 9:05 ` Dipendra Khadka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260103090500.57460-1-kdipendra88@gmail.com \
--to=kdipendra88@gmail.com \
--cc=david.laight.linux@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®