From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
Yishai Hadas <yishaih@nvidia.com>,
Chiara Meiohas <cmeiohas@nvidia.com>,
Michal Kalderon <mkalderon@marvell.com>,
Selvin Xavier <selvin.xavier@broadcom.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH rdma-next 1/6] RDMA/umem: Remove redundant DMABUF ops check
Date: Sun, 4 Jan 2026 15:51:33 +0200 [thread overview]
Message-ID: <20260104-ib-core-misc-v1-1-00367f77f3a8@nvidia.com> (raw)
In-Reply-To: <20260104-ib-core-misc-v1-0-00367f77f3a8@nvidia.com>
From: Leon Romanovsky <leonro@nvidia.com>
ib_umem_dmabuf_get_with_dma_device() is an in-kernel function and does
not require a defensive check for the .move_notify callback. All current
callers guarantee that this callback is always present.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/core/umem_dmabuf.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/infiniband/core/umem_dmabuf.c b/drivers/infiniband/core/umem_dmabuf.c
index 0ec2e4120cc9..939da49b0dcc 100644
--- a/drivers/infiniband/core/umem_dmabuf.c
+++ b/drivers/infiniband/core/umem_dmabuf.c
@@ -129,9 +129,6 @@ ib_umem_dmabuf_get_with_dma_device(struct ib_device *device,
if (check_add_overflow(offset, (unsigned long)size, &end))
return ret;
- if (unlikely(!ops || !ops->move_notify))
- return ret;
-
dmabuf = dma_buf_get(fd);
if (IS_ERR(dmabuf))
return ERR_CAST(dmabuf);
--
2.52.0
next prev parent reply other threads:[~2026-01-04 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 13:51 [PATCH rdma-next 0/6] Batch of unrelated cleanups in IB Leon Romanovsky
2026-01-04 13:51 ` Leon Romanovsky [this message]
2026-01-05 3:29 ` [PATCH rdma-next 1/6] RDMA/umem: Remove redundant DMABUF ops check Kalesh Anakkur Purayil
2026-01-04 13:51 ` [PATCH rdma-next 2/6] RDMA/core: Avoid exporting module local functions and remove not-used ones Leon Romanovsky
2026-01-05 3:45 ` Kalesh Anakkur Purayil
2026-01-05 5:01 ` Zhu Yanjun
2026-01-04 13:51 ` [PATCH rdma-next 3/6] RDMA/mlx5: Fix ucaps init error flow Leon Romanovsky
2026-01-05 3:37 ` Kalesh Anakkur Purayil
2026-01-04 13:51 ` [PATCH rdma-next 4/6] RDMA/mlx5: Avoid direct access to DMA device pointer Leon Romanovsky
2026-01-05 3:45 ` Kalesh Anakkur Purayil
2026-01-04 13:51 ` [PATCH rdma-next 5/6] RDMA/qedr: Remove unused defines Leon Romanovsky
2026-01-05 3:34 ` Kalesh Anakkur Purayil
2026-01-04 13:51 ` [PATCH rdma-next 6/6] RDMA/ocrdma: Remove unused OCRDMA_UVERBS definition Leon Romanovsky
2026-01-05 3:41 ` Kalesh Anakkur Purayil
2026-01-05 9:07 ` [PATCH rdma-next 0/6] Batch of unrelated cleanups in IB Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104-ib-core-misc-v1-1-00367f77f3a8@nvidia.com \
--to=leon@kernel.org \
--cc=cmeiohas@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=selvin.xavier@broadcom.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®