mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacky Chou <jacky_chou@aspeedtech.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Jacky Chou <jacky_chou@aspeedtech.com>
Subject: [PATCH 10/15] net: ftgmac100: Simplify legacy MDIO setup
Date: Mon, 5 Jan 2026 15:08:56 +0800	[thread overview]
Message-ID: <20260105-ftgmac-cleanup-v1-10-b68e4a3d8fbe@aspeedtech.com> (raw)
In-Reply-To: <20260105-ftgmac-cleanup-v1-0-b68e4a3d8fbe@aspeedtech.com>

From: Andrew Lunn <andrew@lunn.ch>

There are old device trees which place the PHY nodes directly in the
MAC nodes, rather than within an MDIO container node.

The probe logic indicates that the use of NCSI and the legacy
placement of PHYs is mutually exclusive. Hence priv->use_ncsi cannot
be true, so there is no reason to set it false.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 drivers/net/ethernet/faraday/ftgmac100.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 327e29064793..cc01cf616229 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -1995,8 +1995,6 @@ static int ftgmac100_probe(struct platform_device *pdev)
 		 * child node. Automatically scan the MDIO bus for available
 		 * PHYs.
 		 */
-		priv->use_ncsi = false;
-
 		err = ftgmac100_mii_probe(netdev);
 		if (err) {
 			dev_err(priv->dev, "MII probe failed!\n");

-- 
2.34.1


  parent reply	other threads:[~2026-01-05  7:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-05  7:08 [PATCH 00/15] net: ftgmac100: Various probe cleanups Jacky Chou
2026-01-05  7:08 ` [PATCH 01/15] net: ftgmac100: List all compatibles Jacky Chou
2026-01-05  7:08 ` [PATCH 02/15] net: ftgmac100: Add match data containing MAC ID Jacky Chou
2026-01-05  7:08 ` [PATCH 03/15] net: ftgmac100: Replace all of_device_is_compatible() Jacky Chou
2026-01-05  7:08 ` [PATCH 04/15] net: ftgmac100: Use devm_alloc_etherdev() Jacky Chou
2026-01-07 15:55   ` Simon Horman
2026-01-08  1:31     ` Jacky Chou
2026-01-05  7:08 ` [PATCH 05/15] net: ftgmac100: Use devm_request_memory_region/devm_ioremap Jacky Chou
2026-01-05  7:08 ` [PATCH 06/15] net: ftgmac100: Use devm_clk_get_enabled Jacky Chou
2026-01-05  7:08 ` [PATCH 07/15] net: ftgmac100: Simplify error handling for ftgmac100_initial_mac Jacky Chou
2026-01-05  7:08 ` [PATCH 08/15] net: ftgmac100: Move NCSI probe code into a helper Jacky Chou
2026-01-07 15:55   ` Simon Horman
2026-01-08  1:32     ` Jacky Chou
2026-01-05  7:08 ` [PATCH 09/15] net: ftgmac100: Always register the MDIO bus when it exists Jacky Chou
2026-01-05  7:08 ` Jacky Chou [this message]
2026-01-05  7:08 ` [PATCH 11/15] net: ftgmac100: Move DT probe into a helper Jacky Chou
2026-01-05  7:08 ` [PATCH 12/15] net: ftgmac100: Remove redundant PHY_POLL Jacky Chou
2026-01-05  7:08 ` [PATCH 13/15] net: ftgmac100: Simplify error handling for ftgmac100_setup_mdio Jacky Chou
2026-01-05  7:09 ` [PATCH 14/15] net: ftgmac100: Simplify condition on HW arbitration Jacky Chou
2026-01-05  7:09 ` [PATCH 15/15] net: ftgmac100: Fix wrong netif_napi_del in release Jacky Chou
2026-01-07 15:54 ` [PATCH 00/15] net: ftgmac100: Various probe cleanups Simon Horman
2026-01-07 16:09   ` Andrew Lunn
2026-01-12 15:02     ` Simon Horman
2026-01-08  1:37   ` Jacky Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260105-ftgmac-cleanup-v1-10-b68e4a3d8fbe@aspeedtech.com \
    --to=jacky_chou@aspeedtech.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®