From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E169824677A for ; Mon, 5 Jan 2026 00:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767573094; cv=none; b=dXJ1VKxOHMPZH64G3X4t3ScnF5kRAkyP9FFPkaWLGd/p95j81nkuG7lOjpIacUbOJq1CA2U36H0J9cDTEsl+yMkDHq757Io2cPRn/oz1CCiCpr/Nycq98Aw6AcnDGUX20yrhxdNiVp9BAnKCKdCTz4lQeK0EVtWzhx82d+8rKAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767573094; c=relaxed/simple; bh=+Ou/L691yl2pEwFshvoUphLVq7kRxh5ZvJ859wkB/ls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cBVJk4GNGSxmvgbYyylCUNKzxblMRAkgEbbLikudGPQp8GOOITm21LhuAlV1JLbj3AOdJ2/0Xk0FYlIv41OUQThFPFW0zruPbCGDHEEwsdRUkpYZC6ND8G+YD0LFfTdklVTHxhT3eXWIiA4pLmOrh6gI2xjNTOnTHxlQ17VHYrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RO5xdX0/; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RO5xdX0/" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b73a9592fb8so284546766b.1 for ; Sun, 04 Jan 2026 16:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767573090; x=1768177890; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gpScWjXx32UdireQANlIMVCU9jYYS6COy9ebZPNG17U=; b=RO5xdX0/JBe31sGfVdBO9dl7jgHhxKcolce3HRIWP+sncb91E1MeTbrdxH7d5U2FFG S5cgd14OQUJ28WdojcaMnhZQZFm5thyr/MD4yGNXK2RII+H9sYmAOyvC4k7ILYcGm+PO +T/uLL2GuPXD1M1ZwkQda7myMFbfmYC2AQkeNyINbOFllJ7s4ybhM8N8+4iBtPD/zblS 8x5wyQ604+20vuofNcyElIY/uz4chokT5ibKpCUa+gnG46NAWVIp9H9vdb1KGlvqdr8N YCc6eemEjVu8HrLLt6YNjbaKHUlUx8p83cBaz6OjVbnShBnvR1YvcJQjlWxIKc7ISzaK pw+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767573090; x=1768177890; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gpScWjXx32UdireQANlIMVCU9jYYS6COy9ebZPNG17U=; b=N/IMvswXvmmLDFDa9eYbHgRb5ispH9l9tTy6kcXSSmA0YOa19WA/qC+Bwo30c+MR/w oMu7w7UiPzy907jDF2e2cZXgGYUVan1KKA1M0L+hN7zdn9c944gyErvqGdablkKmtVsa JkVucyw0YrFDKLj2Y3rLZ0ihDTpeTCmlqg+yZnD5X9UGwd0YDIywQ/Lqnx+UQQ2QFcex mNbYEToy4f7X0dIBdHOtk7iXrHoK7aBULgLrGbIY1m8Yc4WgSdKcs7p461oZ5HYywJm4 Yql342FrECOl48jxOrXjwZER99Wty6mheJghmIoLxVmfxweB9kZrJ4X358xFi4izSIJ/ EGKQ== X-Forwarded-Encrypted: i=1; AJvYcCXEWNMz/Uggvqw1KTVuNfuXHEs/WMfhbcJb7ml+k9r5+csfm/kAIEoHuHugjIqb+y0PEyl7GF09iX4PN6s=@vger.kernel.org X-Gm-Message-State: AOJu0YzuSp3AYJMuaGd7X/QaNZOG8hoh9mZoiSrxMnF+Tb/eEu6n5umj V8cZJynt3C5WC/kmcBkGt7stkwqFmZF8kFjiLp4QoevhOHVMQNk4AMW0 X-Gm-Gg: AY/fxX4yrm8u8bzNACdIV/7NJPaqujP2yClPOWahrDDL0QmTuTKNUC7OAWQfPSlldLd +8EjTaCnEqy7/EJwEFdrVt027rgrYsbY0tp4mQkDTWkH40Xv1u+xsU+hlGTopFYb7mX4fbTHXT1 emeMjneO4Pmn+QnqQRBk9SdqLC/Qk8Fdo+3UFZpb7qetfW0Sb3u9HjR51t2dy5fFMtVl38fMxsK lRaJAMnYwVOhsTZdZCCI2hEvyg2b/56C9PFFbifrdiAcymtHf2kFtOguCK8vGR8x4gCg9+9+Z4Q 3sVhTmtTkj7qtSkGqYliAiC8cIjBvgk/7U/gIo7kHVjIh6Yq8NbmDf+nfzwAsVSH6uFYxO4YB8i 9uNgMUiy/YoJr63yxREees0iupmHrixz9EafPzUhQkYlUYl9H8lV70DG7/SrNkCG/cdTKK5CmWR 8L2N6r4ibUKA== X-Google-Smtp-Source: AGHT+IFqZiY/tTJ0C0QIUq5PksnWtfuoN7KhR5JgpcJjhbJ9tEmhm534OfKZskuDHTP+pZFa+QoqQg== X-Received: by 2002:a17:907:3daa:b0:b3f:f6d:1d9e with SMTP id a640c23a62f3a-b83e25b475dmr722625566b.6.1767573089984; Sun, 04 Jan 2026 16:31:29 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b9105a9c4sm52272729a12.12.2026.01.04.16.31.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 Jan 2026 16:31:28 -0800 (PST) Date: Mon, 5 Jan 2026 00:31:28 +0000 From: Wei Yang To: Lance Yang Cc: Vernon Yang , lorenzo.stoakes@oracle.com, ziy@nvidia.com, dev.jain@arm.com, baohua@kernel.org, richard.weiyang@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@kernel.org, Vernon Yang , akpm@linux-foundation.org Subject: Re: [PATCH v3 6/6] mm: khugepaged: set to next mm direct when mm has MMF_DISABLE_THP_COMPLETELY Message-ID: <20260105003128.7xitfioeno56h7f3@master> Reply-To: Wei Yang References: <20260104054112.4541-1-yanglincheng@kylinos.cn> <20260104054112.4541-7-yanglincheng@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) On Sun, Jan 04, 2026 at 08:20:29PM +0800, Lance Yang wrote: > > >On 2026/1/4 13:41, Vernon Yang wrote: >> When an mm with the MMF_DISABLE_THP_COMPLETELY flag is detected during >> scanning, directly set khugepaged_scan.mm_slot to the next mm_slot, >> reduce redundant operation. >> >> Signed-off-by: Vernon Yang >> --- >> mm/khugepaged.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >> index 1ca034a5f653..d4ed0f397335 100644 >> --- a/mm/khugepaged.c >> +++ b/mm/khugepaged.c >> @@ -2541,7 +2541,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, >> * Release the current mm_slot if this mm is about to die, or >> * if we scanned all vmas of this mm. >> */ >> - if (hpage_collapse_test_exit(mm) || !vma) { >> + if (hpage_collapse_test_exit_or_disable(mm) || !vma) { >> /* >> * Make sure that if mm_users is reaching zero while >> * khugepaged runs here, khugepaged_exit will find > > >Let's convert hpage_collapse_test_exit() in collect_mm_slot() as well, >otherwise the mm_slot would not be freed and will be scanned again ... > >static void collect_mm_slot(struct mm_slot *slot) >{ > struct mm_struct *mm = slot->mm; > > lockdep_assert_held(&khugepaged_mm_lock); > > if (hpage_collapse_test_exit(mm)) { <- > What if user toggle the MMF_DISABLE_THP_COMPLETELY flag again? > hash_del(&slot->hash); > list_del(&slot->mm_node); > > mm_slot_free(mm_slot_cache, slot); > mmdrop(mm); > } >} -- Wei Yang Help you, Help me