From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE8F327C18 for ; Mon, 5 Jan 2026 09:50:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767606624; cv=none; b=KVewWKuAMJy8rmX67orfS9Rf8W/n83B3Pan/CL5GBoqbwwbf6a8OBiZJO+Oc661rAaES932pfehPrW4zSUcFEpyntJro1hed5HbkdgG9d8kbm0ZcK1NPu4E0G8jQv3MHv6FT6xL3bHJjPBhtpcDENz9GDSd8UtPJG/5O7vlD1wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767606624; c=relaxed/simple; bh=FhA8UK+chCa+pd17hZ6IOPyBbup1JCfkMRjpIxTkHNo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rk01LroaQBDtiicN0a2mR0KpDjVTuj2XcNJlyX1kCInHOHPmc+sdE+eWJtLW4NHWnZLAbiMzmvtn4rVLVZzhzg26ad79XhdduqYjHFLbdw2G82m0Sd+/dt4hkPZvTT1nbYHrU3qLL7dMOC5G8vX8O9jXvZt4aXB/y/Zla1XY6G8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ch6/Q7bJ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ch6/Q7bJ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47928022b93so20053985e9.0 for ; Mon, 05 Jan 2026 01:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1767606621; x=1768211421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FHbyaIHmldcU+eqqgyAXM9nUM8TFQGdgTiHVbrY2G0o=; b=ch6/Q7bJAAq2dveUyIY5ODasRlLELdDmSr5b55hbxAvwj+DMYKdVCaUko5AOiQmhgi N0EgetQVqD8vgYahlGMM9R+BEC99QpGuJJpdFQa0NQQ3yG2LTA2Tu0ZRyqO634+rlWN9 wWzjBF++QRgs75FDG2EkurOYdM0VguozM5JgJzY852qkRTaFJqNo7vxptgkwUADi1VrB Qa+9fTkoB5MRLnHd8dUxsp5bdfGE6gD+Tq/xeCHSn57yb3largDmjmBNlL2mU4Z43TzA mPZkRDY3siUk5PgIkppZuLF4tj/VclHM+LbsIjkSiZ36Ee2gIjBXlOBAVtAhFgWCg783 97qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767606621; x=1768211421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FHbyaIHmldcU+eqqgyAXM9nUM8TFQGdgTiHVbrY2G0o=; b=Q/lKI0P1blHERX/YpZvpR7SobPssuBZxLfge8Bh/ZIro6h9wTUHpHGFWN2YEURNo44 h5nkaan4QE8N/us5knGjd6xL5wMji1ICeReOr9AXpwA+yyZgGtm3MGZo4DKuRG24iRZp h+uZ+jLSrJM9ij9dauoDFEIZXgAvdR347yaVSA+gD2qhoTPmfK++DbDOxx3Hnv2ZM6KN pTDui+Yi/oPDf/NBwkj2GjW/7qk39Ly9P3Rbe8nGOA8HQiNkswaNdZzhXrsnShPdmQEC +FIH3oKSEXRpDjVGdOQ/RPsxDNaikr5no7XLTioQ8LCwEQqjceaUc8Zqi9i1BVpQw7We o2dA== X-Gm-Message-State: AOJu0YzT+k9a3lPjOsEeE07pPhpOJ9V2avjjAb6r41B+hdCFdN6VHtF/ kt6QQpODt5KqAKKhULvx0DKfiLjX2yjav8UDqVnrQ4195cIHs0o1MaczUCMAA9k+tBc= X-Gm-Gg: AY/fxX7BbN4bxv/4GnK6EQ4DqPEra6M0wUZr3gjyACkiuTRo549jxGqITwNQfVWbHYH wSUoBKpwhLDoWTlHCeFEWT2RQeEixb7+WcVmU4YjEDruDXA9cEFUSQcm28wi3NEoStxof8mKoho h+g3Vs4wvkwGmjbQ0AX/8zH+8zIyvBGX/o+8mGt/xMQrcsPD9l0AAFOjq58hyJe3vsOwLFofaJc RvdH2KPyxY5aeRquBxPd5knWgAYSgdivLWf/sjq+8A4i9lzoa88wSutBBer8gtDtpijK2HlhYq7 YKw8nLpZ6y+rhZDQrLxS+D6jTQa9WQ09seL+hA9jLUGNQfRYE4+jvThfMLKnNHYlDHQT6kbr+v2 5P/FDZKEdyI07UHONzzwwOoEJw/lOA4eoVa07cSCqNi+WmMMBJOar0ivJQKiKBzgYOywm0rCSfz aL54qVkpFrNOAyG+1mPE/3bAUCzGjD18qIa1WuKnbHIuSks0H0U6FF/5pON70hy2LAXmQAf7KxY 8YnK/Vt9TSN4tY= X-Google-Smtp-Source: AGHT+IGnsRamZ5T2skVdNNSZv9niwK5H6wuQG4RJC9WMb4c0kDes0M5FONvR6OuiLsAxcMrzh8ZmXw== X-Received: by 2002:a05:600c:1d1d:b0:477:a6f1:499d with SMTP id 5b1f17b1804b1-47d19574e09mr373374595e9.3.1767606620962; Mon, 05 Jan 2026 01:50:20 -0800 (PST) Received: from mordecai (dynamic-2a00-1028-83b8-1e7a-3010-3bd6-8521-caf1.ipv6.o2.cz. [2a00:1028:83b8:1e7a:3010:3bd6:8521:caf1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7443c04csm28265855e9.1.2026.01.05.01.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 01:50:20 -0800 (PST) Date: Mon, 5 Jan 2026 10:50:18 +0100 From: Petr Tesarik To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?UTF-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 03/15] dma-mapping: add DMA_ATTR_CPU_CACHE_CLEAN Message-ID: <20260105105018.732dd009@mordecai> In-Reply-To: <2d5d091f9d84b68ea96abd545b365dd1d00bbf48.1767601130.git.mst@redhat.com> References: <2d5d091f9d84b68ea96abd545b365dd1d00bbf48.1767601130.git.mst@redhat.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 Jan 2026 03:23:01 -0500 "Michael S. Tsirkin" wrote: > When multiple small DMA_FROM_DEVICE or DMA_BIDIRECTIONAL buffers share a > cacheline, and DMA_API_DEBUG is enabled, we get this warning: > cacheline tracking EEXIST, overlapping mappings aren't supported. > > This is because when one of the mappings is removed, while another one > is active, CPU might write into the buffer. > > Add an attribute for the driver to promise not to do this, making the > overlapping safe, and suppressing the warning. > > Signed-off-by: Michael S. Tsirkin LGTM. I'm not formally a reviewer, but FWIW: Reviewed-by: Petr Tesarik > --- > include/linux/dma-mapping.h | 7 +++++++ > kernel/dma/debug.c | 3 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index 29ad2ce700f0..29973baa0581 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -79,6 +79,13 @@ > */ > #define DMA_ATTR_MMIO (1UL << 10) > > +/* > + * DMA_ATTR_CPU_CACHE_CLEAN: Indicates the CPU will not dirty any cacheline > + * overlapping this buffer while it is mapped for DMA. All mappings sharing > + * a cacheline must have this attribute for this to be considered safe. > + */ > +#define DMA_ATTR_CPU_CACHE_CLEAN (1UL << 11) > + > /* > * A dma_addr_t can hold any valid DMA or bus address for the platform. It can > * be given to a device to use as a DMA source or target. It is specific to a > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c > index 138ede653de4..7e66d863d573 100644 > --- a/kernel/dma/debug.c > +++ b/kernel/dma/debug.c > @@ -595,7 +595,8 @@ static void add_dma_entry(struct dma_debug_entry *entry, unsigned long attrs) > if (rc == -ENOMEM) { > pr_err_once("cacheline tracking ENOMEM, dma-debug disabled\n"); > global_disable = true; > - } else if (rc == -EEXIST && !(attrs & DMA_ATTR_SKIP_CPU_SYNC) && > + } else if (rc == -EEXIST && > + !(attrs & (DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_CPU_CACHE_CLEAN)) && > !(IS_ENABLED(CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC) && > is_swiotlb_active(entry->dev))) { > err_printk(entry->dev, entry,