From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C747404E for ; Tue, 6 Jan 2026 00:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767660959; cv=none; b=qa+wD9P8Mxj+Vas8oOiYVdZhUvQ4Wi4wpzMAM2XDFSQv7UKBxuLclqvtlmVdEWbAZiBnpDKVxw4QG49awKL++TYsMITqX5+EFmsO09FAMCBgaGnzld3JEBfqnXsfjjCgqB1ivb1MudO58LpFY3LOwuTAl88ymZBLQHKmH+SyJq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767660959; c=relaxed/simple; bh=abJpD/qRRa8BSnB0k+A5D0fdC9PhsRPfE1y9bMxV0DM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nj4e27OEnl+Cywbe9blwc9M14v/yZxRA9p27+7ZbUw0z862Oh8y8PFYYcXCAzkA+8Yl/B3rDzSaDiyuty/c9ysQobDTHmX4Fv/SAwxY5cUgQIIZsyR/SihUvAcoh/TFOkplhMgu70pbwq+g27f97f09l2pIh87myxEU4qsPNA0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=SqhU27a2; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="SqhU27a2" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8b1e54aefc5so39770285a.1 for ; Mon, 05 Jan 2026 16:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1767660957; x=1768265757; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=MDaatcwxGRMydCvVRMs3UB8MyV1SGaXPU4qbydS0qdk=; b=SqhU27a2AkuX08eCs0gQEEHW6ijKDFiZVPsx4TlR6ITDo+Kedn3bOu6LTEli0dn0iU 6jLXtzbaq8JxCqZckUf3WQGiQU8AoQrMqRx2XDG4RXovaZrBbNogPUY+BrFNKI4P4xg1 Yw947i2sB+iNObXUSrfdIwId2o5/swFZICUexi/Vb2ktVurgRDLDTbcX1KSRcmpHDJ1U xMNZXlDzi0hDMnW/k4kmCpU160zTkq4iGcjsxULos1WjFWzooRTx8ZU34uqTqr5CCkNp P2DFSLdEf1m8UhSdAEIRTxXi7zOWp0P2+l+g2eytmUumx03n039TjxOp6HnDLSUx7EMQ ACGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767660957; x=1768265757; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MDaatcwxGRMydCvVRMs3UB8MyV1SGaXPU4qbydS0qdk=; b=YUum4tLys/Np7um0LLFfdWXKEXE/C0k+lryKVVEGl9MdMxFZ7M/GRtNsV2GSUjroGe hbXPEIccDoflcX2/j1kXidz1upVOIkLFi7z6/MHK438p7vg/0JTQE1SWgvbDrXNTlQch scasnx4Pl+ijAqWkJTi6etd6mb+NtCYEdLtdSJrGFd+I+d3GEUTBC7dL2cyQWO3Qq2CK u7b9LwS/fGgXRj34uOYbc86boJAwTW6ryGL3ibXP8qOApUKUiBw/lMJix+TeMzf+WrTc JNoCHvMumhyoWTXEsygtVARlL5N7T8AWHVSvIWI0Ya99GtFVUFA99wHQ4arJRA7RszgP gyQg== X-Forwarded-Encrypted: i=1; AJvYcCXcpeSs/JO+xC4vDrOiKWdb7CYkYFChqS0dt28otsI4YI5Mv8G6LMEzethg0ykFH6W+Ce4EfH+aB6sqsPI=@vger.kernel.org X-Gm-Message-State: AOJu0YyGeh5GIBDNIaYh5D3gcdNAfbcTfN+oc9xOuP6zLbP/7NbbfZ3Q WXfwYCLhrZa/q8KBfARfeKTspR6CuQbf1xRAYfH9MylFAPCPyut7UgUJEYgi5qslGto= X-Gm-Gg: AY/fxX6sAIIKhgaGn+AR2YSzAGOgilUHeIq9fbbjK4EW3waZ2vkL2+XuG0WKIHAeLVH Q19rICIL6Rk10mFLwAwd/n3Wkse7d/gPwn1iA/76WHUMegivXGFgLZSWU18Y4SnNVVGwLUhunvO DR+4MfTFEAJxmzPiA9Gk9dyu/mWAUysHi8+nJ/GsmnxmV4A/tlOrf8W1WTG/2Tr4tE5+5ifot58 vQTwtlyMAi6W9xbUmMGbnAU5CL8aRN+HOzf/5fvM7FbLmsOqMi+okEkzVjiHW9VoBgawFnRIN5c A225SS2eM+YeY+SqBXhLdYZ8x+Ph0tWhkG/7NxY8JRJql18xeqU5iI5e9RVy9SWVlii0RMSWLXU Mu37vHpbHloRAqhI82tca3X5kPqb+zC6gMpaJnQ673B5EStzPqAlO+aQGNGQyjojZd9I9XcyG7k +lC6B7BAS9ywfSzjmYURNYGQqtLLNbNCpPIIqhhnYQ20jipVRYla0MFRNClIeNetGYDSw= X-Google-Smtp-Source: AGHT+IHkp3tvc1TSQLjXfwX1R/16djzCewcOTCUqfELaiw90lDY/HdFwxvMQJsz2/fprn33eK02RsQ== X-Received: by 2002:a05:620a:4494:b0:8b2:d2c9:f73 with SMTP id af79cd13be357-8c37ebba292mr183184685a.41.1767660957054; Mon, 05 Jan 2026 16:55:57 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f53129fsm63537585a.44.2026.01.05.16.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 16:55:56 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vcvMZ-00000001EVK-3aKl; Mon, 05 Jan 2026 20:55:55 -0400 Date: Mon, 5 Jan 2026 20:55:55 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Jang Ingyu , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] infiniband/core: Fix logic error in ib_get_gids_from_rdma_hdr() Message-ID: <20260106005555.GL125261@ziepe.ca> References: <20251219041508.1725947-1-ingyujang25@korea.ac.kr> <20251221092418.GF13030@unreal> <20251221093038.GG13030@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251221093038.GG13030@unreal> On Sun, Dec 21, 2025 at 11:30:38AM +0200, Leon Romanovsky wrote: > On Sun, Dec 21, 2025 at 11:24:18AM +0200, Leon Romanovsky wrote: > > On Fri, Dec 19, 2025 at 01:15:08PM +0900, Jang Ingyu wrote: > > > Fix missing comparison operator for RDMA_NETWORK_ROCE_V1 in the > > > conditional statement. The constant was used directly instead of > > > being compared with net_type, causing the condition to always > > > evaluate to true. > > > > In current code, it doesn't matter as network type can be one of four > > possible values, and this "else if" will be always true anyway. > > > > I changed your patch to this and added Fixes line: > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > > index ee390928511ae..256f81c5803ff 100644 > > --- a/drivers/infiniband/core/verbs.c > > +++ b/drivers/infiniband/core/verbs.c > > @@ -737,14 +737,11 @@ int ib_get_gids_from_rdma_hdr(const union rdma_network_hdr *hdr, > > ipv6_addr_set_v4mapped(dst_saddr, > > (struct in6_addr *)dgid); > > return 0; > > - } else if (net_type == RDMA_NETWORK_IPV6 || > > - net_type == RDMA_NETWORK_IB || net_type == RDMA_NETWORK_ROCE_V1) { > > - *dgid = hdr->ibgrh.dgid; > > - *sgid = hdr->ibgrh.sgid; > > - return 0; > > - } else { > > - return -EINVAL; > > } > > + > > + *dgid = hdr->ibgrh.dgid; > > + *sgid = hdr->ibgrh.sgid; > > + return 0; > > } > > EXPORT_SYMBOL(ib_get_gids_from_rdma_hdr); > > After some additional consideration, I'll keep your patch as is. > > My change is technically correct, but it's risky since some drivers > use non‑conformant values. I don't think it is that risky because it is what has been happening all this time anyhow. > > > } else if (net_type == RDMA_NETWORK_IPV6 || > > > - net_type == RDMA_NETWORK_IB || RDMA_NETWORK_ROCE_V1) { That expression is always true Conversely with the "correct" patch if we have a net type of RDMA_NETWORK_IPV4 we now get an EINVAL that we didn't get before.. I guess we will see if this turns into a problem or not.. Jason