From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chen Changcheng <chenchangcheng@kylinos.cn>
Cc: krzk@kernel.org, hansg@kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, mchehab@kernel.org
Subject: Re: [PATCH v2] uvcvideo: simplify spin_lock using guards
Date: Tue, 6 Jan 2026 05:51:59 +0200 [thread overview]
Message-ID: <20260106035159.GA11450@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20260105093512.194988-1-chenchangcheng@kylinos.cn>
On Mon, Jan 05, 2026 at 05:35:12PM +0800, Chen Changcheng wrote:
> > This is an undesired syntax explicitly documented as one to avoid. You
> > need here proper assignment, not NULL. Please don't use cleanup.h if you
> > do not intend to follow it because it does not make the code simpler.
>
> Thank you for your correction and feedback. I made the change initially
> because I saw similar patterns using "__free(...) = NULL" in patches from
> other driver modules, which led me to overlook the core paradigm of
> cleanup.h that requires a "declaration with a meaningful initializer."
Do you plan to send a v3 ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2026-01-06 3:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 0:56 [PATCH v2] media: uvcvideo: Use scope-based cleanup helper Chen Changcheng
2026-01-05 7:07 ` Krzysztof Kozlowski
2026-01-05 9:35 ` [PATCH v2] uvcvideo: simplify spin_lock using guards Chen Changcheng
2026-01-06 3:51 ` Laurent Pinchart [this message]
2026-01-06 8:11 ` [PATCH v2] media: uvcvideo: Use scope-based cleanup helper Chen Changcheng
2026-01-05 9:42 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106035159.GA11450@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=chenchangcheng@kylinos.cn \
--cc=hansg@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®