From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8716F322C67 for ; Tue, 6 Jan 2026 10:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767697122; cv=none; b=ucjiYtoOirM+1Sq6+XtHSVK61Mb7lRBSbhupPGdkVy59g93C2NsKe+0tfwRmQVRGiRV5SQ4uraI+NdUSMW4a8vRfEcCY9fvyCFtIKvNMPX+/ShpqlSOhy48ht+93qIWUDQ+Xj3BMaZvfRQlZopNHsVQqt7iLnUQsUEhzov3CIBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767697122; c=relaxed/simple; bh=iDyH1pgtP+ppXMR2VoPfL4ZIjjIgNHls4cU5wmr0SRw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KtQkoJq4IlSgWTCuUw/tVrinbihDNHe1qYS16zfp8q+OAMopkdK/sNFpwMDhJ7qHyaj9pO66s1W0ANZQvS96Dhnm4m39zlN9u1thqhI02NwvKg1eNSBfhugY9ExzGnqRyaW5vW8V5VJMi98/9E+OryoGynlNZOFjjHNEVxamUSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CHulDA7x; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CHulDA7x" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2a0fe77d141so11336915ad.1 for ; Tue, 06 Jan 2026 02:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767697121; x=1768301921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ITf0IriX3y4OETSjppyjGWMxJAuHK5Bh+jzngHrIi4=; b=CHulDA7xSNBCxII2NaPrhWiA6qV/1T6tRSOKUvK2DVsyvFDIm0fH3YHONrirNraq+R SmShl9GoYB3oiL5ZiJhyd1BePE6eiH9iJ1XqGLvBuSKcK0oie55dY7aqVOJISFHOGuB9 Pe+jhAel6RSaWTfa9jmBiLhcDHHm1qLcBOvpargMukxYj89yJ2RXN+ucFCRhTCMjFqnb VvN7chBuhIEfOu1VxYHmLfGQl7MNkFI5vVLIpnhQWuBubdh2Yc8+UMMl3zDXCK4oRkPH j2spuZ2zNFIUcI9OzGuVKogPlG/Yj7p9YwyeMAP6tMMTj+abL44te7EF3QdSIcp0aGY5 AMFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767697121; x=1768301921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6ITf0IriX3y4OETSjppyjGWMxJAuHK5Bh+jzngHrIi4=; b=AqDy8H042t+8UsVnFfugrS6bXeBTr8/knnpMV4FSbhqu3pTkPJWx0VpcbI/UovdFrX qBQ7qY+P+b5KQJivCyxFSXMk4/wAsjSGgXdwAzz4ZJ3lCMilvq5oqV4T5BvcEhC6rD5F DgcWXBGnAfgm7pn6QxeDpXjWyKj44j4LbU/Xy9bQ4J97nk8zBdSCOtKrfbjgxwaDIF4p bSvzfQVoVDwinWDOJZ4Yg6/4sqzMRdnAq5QDePvS44EuBNP+Q36b16xPnb4OT/A35fjZ tu7I5XC1932kdoBgCufFkAEmh76OiZY3njvi5pkr4PvN82UtuJItdeEHiintjenj/Kda PKVw== X-Forwarded-Encrypted: i=1; AJvYcCVv+wnhhFaBIsuRxT13BBTSUhmdYuN1bYFWLSV/5XuEZDGWaV1US1PHXT8IqQsLtCUvVLpuntOZ7tWAyBo=@vger.kernel.org X-Gm-Message-State: AOJu0YwII9zaU3iMoE413OjV6EQPfGayclkIeUtF6YZdz9xR4wOIxpy4 ZiCLAGcqnnmYdKpE/KBACT3g+aLsKchhTkaodkWdygh5L1EoRKwWZWZU X-Gm-Gg: AY/fxX61GzzHW5LXchZVAe3APihx8Ddno167QZxBX3lQa8jFYqyyiesNVOpVTKom9He 8tem6yx6+mHZ65Kq943Yvhfmer51slRY/BiqM/8sRzYvxJiw7tHL/uXNbguJ3EZ4KT451UMJcjG f4oHu1CVGonOl/jRUWwVgWLk9uNWNafthEa+q0woVNucJ4Iixk9M0/+ipvx7hlpQqpYQ89aWVbj KV+S5i0QlZy6DF1FoZuT/ZB7nrAupRt6aJyG0IyvZuyz1exBSVs1rUyrkFYTX0YwPaNF/9B5Vfk +0ViiYQGj6ZIKYxGCRkCcIIMNGEjAVhtZ09k2YeZFyGyYxlBK0KBdJTg23AL8sMs6H3aZH3MSG3 Cir/zsaspImR+wfsxs5Yl2g/Xc+quTF2Ky0crG80sAwmVaDGf3HrCEmcgR5k1biTadN1NeeBTfG guj3BKro84Ue5B4gewc6hadJNVlJ4BX0NNidt9og== X-Google-Smtp-Source: AGHT+IEUpg+zz/ppgMl6H4u5xOiikyKGsov+4g7wDMkY+KGOTIrZYjDa+28HXzwLLP7lKUkeJfVkBw== X-Received: by 2002:a17:902:e882:b0:2a0:bb0a:a5dd with SMTP id d9443c01a7336-2a3e2d428bbmr29576445ad.57.1767697120726; Tue, 06 Jan 2026 02:58:40 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.217]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8d81sm19378775ad.81.2026.01.06.02.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 02:58:40 -0800 (PST) From: Qing Wang To: oleg@redhat.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, bsegall@google.com, david@kernel.org, dietmar.eggemann@arm.com, jack@suse.cz, joel.granados@kernel.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, mingo@redhat.com, mjguzik@gmail.com, peterz@infradead.org, rostedt@goodmis.org, rppt@kernel.org, syzbot+e0378d4f4fe57aa2bdd0@syzkaller.appspotmail.com, vbabka@suse.cz, vincent.guittot@linaro.org, wangqing7171@gmail.com Subject: Re: [PATCH] fork/pid: Fix use-after-free in __task_pid_nr_ns Date: Tue, 6 Jan 2026 18:58:32 +0800 Message-Id: <20260106105832.2779312-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 06 Jan 2026 at 17:04, Oleg Nesterov wrote: > At first glance this is racy. Can't task->signal be freed right after > the check? > > And... Can't we make another fix? If copy_process() fails and does > free_signal_struct(), the child has not been added to rcu protected > lists and init_task_pid(child) was not called yet. > > So perhaps something like the patch below can work? > > Oleg. > --- > > --- x/kernel/events/core.c > +++ x/kernel/events/core.c > @@ -1422,16 +1422,17 @@ unclone_ctx(struct perf_event_context *c > static u32 perf_event_pid_type(struct perf_event *event, struct task_struct *p, > enum pid_type type) > { > - u32 nr; > + u32 nr = 0; > /* > * only top level events have the pid namespace they were created in > */ > if (event->parent) > event = event->parent; > > - nr = __task_pid_nr_ns(p, type, event->ns); > + if (pid_alive(p)) > + nr = __task_pid_nr_ns(p, type, event->ns); > /* avoid -1 if it is idle thread or runs in another ns */ > - if (!nr && !pid_alive(p)) > + if (!nr) > nr = -1; > return nr; > } Could we put the checking 'pid_alive(task)' into __task_pid_nr_ns()? Because there is another similar use case here. arch/s390/kernel/perf_cpum_sf.c 619,9: pid = __task_pid_nr_ns(tsk, type, event->ns); --- diff --git a/kernel/pid.c b/kernel/pid.c index a31771bc89c1..e8826731fa47 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -515,7 +515,7 @@ pid_t __task_pid_nr_ns(struct task_struct *task, enum pid_type type, rcu_read_lock(); if (!ns) ns = task_active_pid_ns(current); - if (ns) + if (ns && pid_alive(task)) nr = pid_nr_ns(rcu_dereference(*task_pid_ptr(task, type)), ns); rcu_read_unlock();