From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E62623BF83 for ; Tue, 6 Jan 2026 16:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767718151; cv=none; b=cj1Cr2H1vCK12X+5zGGdgq8j3MU3q86IHKcU0rXfrGZswcDp9bRqmOjmoUHr0v9whyMXgN4zVWnGd2Kb+GCXb3eI8PbXKHSY0PIE9Ad7q8a20wDJeHUVrxh9yX7FiAk8zZSuaMOIBTTNM6ROXpHAsUcJXdGNLI/6UUeF6ebC118= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767718151; c=relaxed/simple; bh=jwrFUMxerbZOYlsVxQfH0pTRFsG5XM65V45COxSSGKQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iqb9jTHTT0t29q/B6ttt5LD5CKiqfP6Z5kiM1zlt43orqZO7cKQFFWqGEqAcK7yP7RNYGGUErG2P1MSMrETJMzj4x4MmsG0Zi2icVkQggdzRQEo+BR0NDNy8p/LnSioy8ajl0JpTCTH6PbbwvmiILhuDFT/jKtj+b7VXZLPi16c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=delta-utec.com; spf=none smtp.mailfrom=delta-utec.com; dkim=pass (2048-bit key) header.d=delta-utec-com.20230601.gappssmtp.com header.i=@delta-utec-com.20230601.gappssmtp.com header.b=kuvjxIi/; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=delta-utec.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=delta-utec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=delta-utec-com.20230601.gappssmtp.com header.i=@delta-utec-com.20230601.gappssmtp.com header.b="kuvjxIi/" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-64c893f3a94so26882a12.0 for ; Tue, 06 Jan 2026 08:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delta-utec-com.20230601.gappssmtp.com; s=20230601; t=1767718148; x=1768322948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/2hOfQwWsFzjkLVUeSCjYmpOw68MXiDDJlSVEBxaXg=; b=kuvjxIi/ElWlLp8Uvud63bKJynfuDTtvqYUATjAoO2xFRTKlqHl04u+aNuzRdsEOo0 im+ifCHJz44KtCKXZsxxPU7BCLg3hhKDfxDEIfkA7/Qp4yvitpaqBnc2EpN71Cg/Im5S iWB16/8x0FfXJ7F8jMQTwMnYQPFg8JyplzKYLlXBrfWwftEMLFnCZzvqZk4KRLQn4Tmn qgXVcuBxg6pWdb3BYLCYCTaLkjYs6MVleLHauxWyPfnBAY9H0kIyNlMB/XNyAShRDgTN cWWDb4Y0dK0ITtkJqs3lBy54qlMcRA9tgAgtYW44bLHfn3jOw/DsVf1jsF5I5fyXCVvm 4pOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767718148; x=1768322948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/2hOfQwWsFzjkLVUeSCjYmpOw68MXiDDJlSVEBxaXg=; b=Dbkl1EKzcpa1CV+fs7MSj9+hsT0Q5E2kAW1DMr2ryV2Sng+GSM8GIHjIc0yMQTkHtK GwU0RhnKh0F9ofQxLCObOTmV1B/26nw/hNawRiBAvn16L1GBJOwPMrFdgEYmqc3rI0F/ x3FcLhzfnL3RYfWXfEa+oJlcq6yzjP0froHgPIuPXWBVdQZDRWz4Vhd0bAvdsVEyu/F9 R+UiJIGsJOJ6hlqayRAb1VA/MutrMxyzV2Do6oWzdXT6d/1xqjNX94SddEGjlLRkO8uB g/ylhiWmtEjkd4mL616RZ/JJfOwQM+FulTi1X1s/JX63nkrjvFZXYMOD5Nxa0rVGyVrv KTCg== X-Forwarded-Encrypted: i=1; AJvYcCUn1DZeEFsSnhJXPuDQ4Q1j3GihheHrz/wYYBLmNh4F80jN8bmkC37MJ4JK6D11qioUPfSeMi4XiN1egf0=@vger.kernel.org X-Gm-Message-State: AOJu0YxNVVpToDJaocQ1RVcILyjX32+3KRNRgF2Ve8OL2Ynj4gQf4T/L 5xaomlMaOZvyLtk68WXGiOuJQbAhkKGRsgj8R/J0QWKLG1EPOnvdc+HEKykWbn5h3g== X-Gm-Gg: AY/fxX5ZKpODbneJDzW5gTio16m9vhEJLNgn5SnViM7aSDbF+w+/L9MmNJuNi30xutK bvsnessaLAXAFt0kFAb7cW/OhdYNfAha8xv7cTsiZAV3GOycoe317h77amLdTEbsGkg+jDNrrOO VBDJ4uDHjaDada0tKDb6051BdTwWwROsSJXR7+0xVPFrNv/iGYOcGYESN3cGKK7dWJosr2QUXua IcmWc5yWdTueM5JD6nJJ6mtYOwu2kYmafcmrWgJdURHN70sDFCdCPBm+zudlLN9CgSC1/ocU1Q8 CRcsKWD8tUbYsWmahd5c8crKYILK0V/l/wL1jH8us3oXR+hgeBQ5dmctszbYsAetLeaivqW66/0 IsHQIxZhqkC5NgjfipY3Og+aUHumQmI3eB8GmHqSwD/A5DNUBzAZh1+LvWP0KTyvOjHWoL5KCZD 7euhspWh3H/Ldps1cAxuS3bCphzwiQmiI1Qit40zvHBB9IcsXtZBOjcOSz6QuFmcel55blePZDY uUU9+5OhhugjtVxqHzpXQux78LU6s13Wr5XLn3m X-Google-Smtp-Source: AGHT+IEHCglQNO0/MVSOt8fK8+G32v50l3Jpso3LgWYx6GLnM5uCEhibt+qUpj+mRzM+1ok5vuYFIw== X-Received: by 2002:a17:907:8e96:b0:b80:3ff7:e43d with SMTP id a640c23a62f3a-b84299b2a7amr363926566b.26.1767718147469; Tue, 06 Jan 2026 08:49:07 -0800 (PST) Received: from localhost.localdomain (2001-1c00-3405-d100-fd78-186a-9428-6b97.cable.dynamic.v6.ziggo.nl. [2001:1c00:3405:d100:fd78:186a:9428:6b97]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a233fdfsm272017666b.7.2026.01.06.08.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 08:49:07 -0800 (PST) From: Boudewijn van der Heide To: liam.howlett@oracle.com Cc: akpm@linux-foundation.org, aliceryhl@google.com, andrewjballance@gmail.com, boudewijn@delta-utec.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maple-tree@lists.infradead.org, willy@infradead.org Subject: Re: [PATCH] maple_tree: Add dead node check in mas_dup_alloc() Date: Tue, 6 Jan 2026 17:48:44 +0100 Message-ID: <20260106164844.280106-1-boudewijn@delta-utec.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > > > Surely this should just be a lockdep assertion that the appropriate > > > locks are held? > > > > > Just to confirm: do you want me to remove the original runtime check entirely > > and replace it with a lockdep_assert(), or do you want both? > > If it's only the assertion, > Please do not include any runtime checks in this change - Just the > lockdep_assert(). > > that would mean that production builds won't enforce the check, right? > > > > For v2, should I add a Fixes: line and Cc: stable, > > or should i leave it out? > This does not need to be backported and does not fix anything. It's an > attempt to protect the user from shooting their own foot off by using > the interface incorrectly. > The fact that no one in the tree uses it incorrectly means that any > backport would be for the benefit of out-of-tree drivers, which we do > not support. Thanks for the help and clarification! I will send v2 with just the assertion, as suggested. Thanks, Boudewijn