mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Janne Grunau <j@jannau.net>
To: "Piotr Masłowski" <piotr@maslowski.xyz>
Cc: Nick Chan <towinchenmi@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Sven Peter <sven@kernel.org>,
	linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: defconfig: Enable Apple Silicon drivers
Date: Wed, 7 Jan 2026 12:20:59 +0100	[thread overview]
Message-ID: <20260107112059.GB4068972@robin.jannau.net> (raw)
In-Reply-To: <DFCLU67GQO86.1NY037FRPJ4E2@maslowski.xyz>

On Wed, Dec 31, 2025 at 07:14:13PM +0100, Piotr Masłowski wrote:
> Hello, I'm not a kernel developer so this might be entirely irrelevant,
> but while browsing the list I noticed something you might've missed:
> 
> On Wed Dec 31, 2025 at 16:42 CET, Janne Grunau wrote:
> > From: Sven Peter <sven@kernel.org>
> >
> > Enable drivers for hardware present on Apple Silicon machines. None of
> > these drivers are critical so build them as modules.
> [...]
> > Link: https://lore.kernel.org/asahi/20250612-apple-kconfig-defconfig-v1-0-0e6f9cb512c1@kernel.org/
> > Signed-off-by: Sven Peter <sven@kernel.org>
> > Signed-off-by: Janne Grunau <j@jannau.net>
> >
> > ---
> > Changes compared to the original submission:
> > - Remove AIC and APPLE_PMGR_PWRSTATE as those are selected by ARCH_APPLE
> > - Add new macsmc drivers (mfd, reset, hwmon, rtc and gpio)
> > - Add BACKLIGHT_APPLE_DWI, DRM_PANEL_SUMMIT and NVMEM_APPLE_SPMI
> >   (suggested by Nick Chan)
> 
> What about DRM_ADP which Nick also mentioned?
> 
> > - Add PWM_APPLE and APPLE_M1_CPU_PMU
> [...]
> 
> I tried to check whether it had possibly been taken care of elsewhere,
> but I didn't find anything related on the mailing list(s) nor in the repo.

Good catch, I missed it in Nick's list. Comma or new line separated
entries would have been easier to read. I also missed the network and
bluetooth devices:

- BRCMFMAC_PCIE
- BT_HCIBCM4377
- TIGON3
- AQTION

Missing as well although only in linux-next is PHY_APPLE_ATC

What is the merge policy for defconfig changes? If this can be merged
for v6.19 I won't bother with a v2 and add them later in a subsequent
change.

If it will be picked up only for the next cycle (v7.0?) I'll send a v2
with the missing configs. Any advise how to deal with PHY_APPLE_ATC? It
depends on commit 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY")
currently only in
https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/log/?h=next

Janne

  reply	other threads:[~2026-01-07 11:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31 15:42 [PATCH 0/2] " Janne Grunau
2025-12-31 15:42 ` [PATCH 1/2] arm64: select APPLE_PMGR_PWRSTATE for ARCH_APPLE Janne Grunau
2025-12-31 15:42 ` [PATCH 2/2] arm64: defconfig: Enable Apple Silicon drivers Janne Grunau
2025-12-31 18:14   ` Piotr Masłowski
2026-01-07 11:20     ` Janne Grunau [this message]
2026-01-07 20:13       ` Sven Peter
2026-01-03 12:46   ` Krzysztof Kozlowski
2026-01-08 20:23 ` [PATCH 0/2] " Sven Peter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107112059.GB4068972@robin.jannau.net \
    --to=j@jannau.net \
    --cc=asahi@lists.linux.dev \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piotr@maslowski.xyz \
    --cc=robin.murphy@arm.com \
    --cc=sven@kernel.org \
    --cc=towinchenmi@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®