From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE39355033
	for <linux-kernel@vger.kernel.org>; Wed,  7 Jan 2026 14:33:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1767796438; cv=none; b=GYbXIvD7XuxxCq6C5wHglDPl2zU1jag1JtcJpkgGGAxxo3rDsMiYbs5azm0DgW0TabEoFe2pDvsb3Prosrl8b1kCYyrHYejvcuk1HzkFvK1GONHQdnr9AIemcLdPrNz+ZijccdvE6pJ8RFunU+Jjqvx4iuAM+CWz91jPYNEAyvw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1767796438; c=relaxed/simple;
	bh=KqDwAdcdhHEwrQJ7G8bigp5Aqb3poO3gFNhGfiG19oo=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Hm3qGarY37BygTqB5m8RHvdMBumRvpdtc5F3Y8InVWQCeBOiQ9LQ4xafjB0aBJZuF1InQKaxkXqag5cexLCe24jm2J6DJ54gLhfEI+skKulOLKl1+30IhlB61yBWrGbYAHQbmHOTSyeJk2pZWicl1x8o7AYA1yRC5Cz/bTYqRMU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 5359F227A87; Wed,  7 Jan 2026 15:33:51 +0100 (CET)
Date: Wed, 7 Jan 2026 15:33:51 +0100
From: Christoph Hellwig <hch@lst.de>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] nvme/host: add delayed retries upon non-fatal error
 during ns validation
Message-ID: <20260107143351.GA14506@lst.de>
References: <20260103-nvme_ns_validation-v3-1-c9ce67393261@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260103-nvme_ns_validation-v3-1-c9ce67393261@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Sat, Jan 03, 2026 at 04:52:00PM -0800, Alex Tran wrote:
> If a non-fatal error is received during nvme namespace validation, it
> should not be ignored and the namespace should not be removed immediately.
> Rather, delayed retries should be performed on the namespace validation
> process.
> 
> This handles non-fatal issues more robustly, by retrying a few times before
> giving up and removing the namespace. The number of retries is set
> to 3 and the interval between retries is set to 3 seconds.
> 
> The retries are handled locally. Upon success then end. Upon fatal error
> then remove the namespace before ending. Upon non-fatal error, retry
> until the max retry amount is hit before ending and removing the ns.

What non-fatal errors do you see?