From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854843148D9 for ; Wed, 7 Jan 2026 14:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767796993; cv=none; b=cF4HgWvZPzay1TXQmGwHvzDNjgW+OklVCY5u78br3Wp+6Dh6C2rop8iJvl3GNSXrNrrOneXMrctfrzNwxcad24xLCMdQaqtbI68o0KbXkuyJvyosXVkhBHq2MGBlzLLycSv9RHbMBvthcOlIfGR2W7GN9snVizNXoMpbsqLVCcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767796993; c=relaxed/simple; bh=Il9Eh11WV/xqDqP1PVBl1AW8wIbYEY8UuvNcQustwlA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e5Xf9fGPHKJ2A8i29GfWGJotsGg/hYG6+PGUwGp2Qfk0uwH52O7EvBtifvbfmcen3+7DsRELpqZhsZ5rEsPityD+zwpcwhzjn6cVxvgQqXgAMBXxR7uG6vBQ2kYpvZz3G74Q9KiDsmL4nqH3u/xPdB7bYfv/WBEFqpwr9C77Kv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lOWWpRhm; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lOWWpRhm" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7aab7623f42so1972834b3a.2 for ; Wed, 07 Jan 2026 06:43:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767796992; x=1768401792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jFmty4BNuj6awrii1t7U31FXH7wri8KyJdJwKzc08Aw=; b=lOWWpRhmaSa6k/O5wqf105m6Se6HkHpadcJpCMerXUvp91Y9zaxBF97HYJBRkDaiH+ FiZVl9fweJfxS6KLedUBXbzQjvHjoESCfVUhJoejMY7udg9OTj/48ye4YkC125I3c01+ jX76r6dXpDxF9CoLQU0NQ3Yd6XHsY/q7fYAGr0JgrvQ7qKrfU/8FUow4+V+QHlyvQB7S jqANNqyVCgHTHOKh8MXL7vETKiy6bBxBkEfA8ETG5Ho/UdBprjnv2mxlZZ20ril6eHI5 1L1pv9zh90U/fGRV5mrMWzk/HRaUqC6ZWiSxsbFGUPV13QFU8wQF+g7T57BbpZlUE1l1 qFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767796992; x=1768401792; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jFmty4BNuj6awrii1t7U31FXH7wri8KyJdJwKzc08Aw=; b=OANDf8idQAPAd8knBfIWRpKtbxo4o0oVA7CFavWPHH29fsGeNZiVXNv8OzTq2+lRmB khl7Vh+D45Wd68P+gWXhFW873mcAk2/BBsDcaN/MZU3HKqIqNiyiDYV0oh6dwAEqvpEM 6Ei0uKCf6Kk5e1HApF3vTnqKirSmXAoDdVNNWhdkR19WWcnHChHpeA1Sb3YKsgAcVXGa rKcsvrj/UClLmpNcuyUPpcz+1QOD/2IKaJTfTeLY41qr3m20oNZ5KECOE9rGIU8YQbSH MUBfTolgVe4v/p8XUzfh4ZcyVHKtZdKJHO1Bd8/3JttJZ7JQaj7QCAmoZc2YQXcP7sDr Xb9A== X-Forwarded-Encrypted: i=1; AJvYcCXW4mCxMu4JYigATuqPtG0NcbuV2ldMTmjFcl+4ARfVzI1i18X5HYLAvSLuLOjIe2NH1+xlzxOpV1HudIY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+f0QfjfxDhTGb+AthPRDNQEPLLlVc21317bgr7LoACZkSRkol z2GyFqHeg0IPqvCZnLffYgTts5JGVmZoOjLtKZDv2dDP9RQFr0BP/3mY X-Gm-Gg: AY/fxX7Wl+9AN8k+ai8pMLt9K+6Wuoqy6+UKUd31kzme1FEWUvDcV9HH7Rp9Ndiyi8e KVv0lIdr7JYMiQEDYitCqVKRxE1YpHiaHa3KZj3NsRe+esrv03H5d8vfl1Coz23dAkxF97dS5Vz Jr3vTq0awhDvUWNKL2foLcPdpYbO3hFMyWZUb1PZ2J8Gcy5p1Y8y5IItQipGKL01TQ4oD3rEj+X g+ol7a2T3o1AqvQ8PsSTK0u9SR95iC1G/7WsS9mEZXR8Pw7lOtKeAlApl0fuvEKbfgb3FIA590u yy5bUA1oZRdCP0TXNnrEpuISTwjdELFPSesnQxgIoIJjYN3qXUQ1e2sIbnsO3nmllwfO9iwO9zK 0uckuEzoVEaqBJUNjRSgauNKKQoAwhfOdrbKzANOfUpJzHYugvUn0NgFk6N0jjSnaiuKdk8xlxc XXlvoAa9BBc5/pBmRtnPV52A== X-Google-Smtp-Source: AGHT+IHBH/YNqBbSFpzLLKloAvcpMmkr0v8s83k+3t8kLdLWdTf6EoKI9MSDa6AMjmoTAhfPDP3b+Q== X-Received: by 2002:a05:6a00:3019:b0:806:1719:295a with SMTP id d2e1a72fcca58-81b7fdc3515mr2374361b3a.47.1767796991833; Wed, 07 Jan 2026 06:43:11 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59da826sm5168936b3a.46.2026.01.07.06.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 06:43:11 -0800 (PST) From: Karthikey D Kadati To: Hans de Goede , Mauro Carvalho Chehab Cc: Dan Carpenter , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH v3 0/3] media: atomisp: refactoring and fixes for V4L2 compliance Date: Wed, 7 Jan 2026 20:12:49 +0530 Message-ID: <20260107144252.74666-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series addresses maintainer feedback and fixes build errors in the atomisp driver. Patch 1: Standardizes the 'Bridge' structs significantly by using v4l2_rect instead of custom shadow structs and aligning ia_css_region members with V4L2 conventions. Patch 2: Introduces a helper function for statistics buffer allocation to reduce code duplication and centralize error handling logic. Patch 3: Adds missing error propagation for IRQ enable and XNR configuration to improve robustness. Changes in v3: - Fix extra new lines in commit messages (Dan Carpenter). - Remove unnecessary s32/u32 casts in atomisp_cmd.c, keeping only the (long long) casts to prevent overflow (Dan Carpenter). - Propagate error codes in atomisp_ioctl.c instead of returning hardcoded -ENOMEM (Dan Carpenter). - Update commit message for Patch 3 to avoid "flooding" terminology (Dan Carpenter). - Wrap cover letter and commit messages to 75 characters (Dan Carpenter). - Sent as a new thread to avoid confusion. Changes in v2: - Split into a 3-patch series. - Standardized internal CSS types. - Fixed integer overflow safety. This series is based on the latest staging/next tree and has been verified with checkpatch.pl --strict. Karthikey D Kadati (3): media: atomisp: replace shadow zoom structs with v4l2_rect media: atomisp: consolidate statistics buffer allocation media: atomisp: propagate errors from ISP xnr and IRQ enable .../media/atomisp/include/linux/atomisp.h | 19 +-- .../staging/media/atomisp/pci/atomisp_cmd.c | 142 +++++++++--------- .../staging/media/atomisp/pci/atomisp_ioctl.c | 127 ++++++++++------ .../staging/media/atomisp/pci/ia_css_types.h | 6 +- .../staging/media/atomisp/pci/sh_css_params.c | 16 +- 5 files changed, 170 insertions(+), 140 deletions(-) -- 2.43.0