From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02E1135E55E for ; Wed, 7 Jan 2026 16:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767804760; cv=none; b=bt2l89eq2lx6pGnIH+0SQ6HWL/kPzeez/J0o9KyNwYySQ6ZewzPUJ/8TrNL8D8Kn6Vcl/Em6485eQKt7jz+Mg2xAKlbjG0yNDu5poEYKfSyXSwVd1aIX3W7hWAtYmo6aMX0ckRxoJmD3lFPAHePjmVXC8kjTsArWM+pSJaOHyTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767804760; c=relaxed/simple; bh=vAGJXvUL/9sBoXeg+qEDESAXwURhENFcuhzOaiocJgw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=G9aJ9GUzP9R3LiY/W8azF3UAOKDBvvZPpDdY5iPt0Uji/tVnHuUaGbdJb+704zfoWS3VR7JdZLzfZQMqYW7togfOOf15Zptcj79+T94UwjgAr+WlltkkXkTisSI9Wwq1LrZTJE2u9SOXLMEFAOX+rjhfilffj9tSOEQvzZCdL1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IUlY2uYQ; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IUlY2uYQ" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4ed861eb98cso24940091cf.3 for ; Wed, 07 Jan 2026 08:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767804754; x=1768409554; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MHVjKAxrVwU1S1gs61EQpxnp4IS2hX0aOMGNWV+STBk=; b=IUlY2uYQJMo8Yy5wWylTBlyAmxXZ1Nxl9mFm4NkpBCVnpiqsYgvfJAHxB67mvTRHIC CA77Ft4OvsHaokDbk8pK6BRhQMy0IDk7F64iSVb5Uct6UTAqdE6TI6CzpoxNYT6Nzygw M9Hy5MQUJi5Wl4t589Ch/e48EmAoIvJuFn1174kZuT8AbG5p7Ofcm3kIcnD62Lr+hRZS qhNA8CUufX+wbUw6VBQK4GkU/ATUlicsjd1iYrHQFoVBIRTWGeE08s8vegrhYU6ZqgiG e1Ksn0ZZy1c2K4CfLzejCGnzlrdgbWaOmPgaQhPdXrh4PcjlXM+jw3C6XTV6HKnmxS7Z HDHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767804754; x=1768409554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MHVjKAxrVwU1S1gs61EQpxnp4IS2hX0aOMGNWV+STBk=; b=EAj3UdPeH2gpXgHTvpxZZQOlmy3Joo5AAR5+slahTJ1G184iQJtt9tPZ7RCnEnsOkk 1uyRAOfO2aceXrPAnTmZ4TPNSa4kb/F841gyIuaI/njS/I6m1RFJ1tBYMsy4gfg1sRZP YksxtH/JMyLPv0QaZrrLQL66Cy7oLtKGAMgiXmN3J5WU9pbJ5Vdm3CSUziqaKBcX0N83 m8LnKhcvohlXWEx9cjh7o3xpDcfCx/b/EYbGCWdRwrVwokaiD8UmSXG+ZjGE9HjMf3SB DYGq/ST1wpheW0QikZ+KcByFb58cduBmx1yAasNQFWEPZQ34WPf5nAHrlY4Fu0ags//q CW6A== X-Forwarded-Encrypted: i=1; AJvYcCUU7yAQ+tRWsxREJU94mE1cqGv5QmDC6Zt9ShusuGMGyRXrAMFwQM9m6eJlJPR3VznzjolaQqLI7AwlzIU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5VVQ4Zhmq2zJ3+WUu0msDt5HTAhyv7JEpeKHqD09ArJ5tb/kC q/UGZoQmIe9CFVETlIzst0jYTNwkxp9cUZD+cfM/wXbbXkSRUYied+t/AYpeAw== X-Gm-Gg: AY/fxX7Rs2J7DqNrXGybmdl7gWvPLTzX1DeqNn63ux0p6V0UNi6c6nXPhPnAVED5V/H 74HBq3Dii3YRYGgpfIY1PhVBUmUpfnh5Yn7ltRFFBa0P1yevBYkptdFxtf2OjYhv/ws8zDSUmP8 3yIUbOjyv6OKGbcP3EWsgadZvBf4Nh0sYIvJJ3AghURfL5KitrE5IrUqqQtowVyUvvE0nVXXCX8 DRzuRXPtj72KuGLaytXXxaJwPA2jd3AMYnw8qQt0U9+WP2Nm82J858DG2ZuLe1KLZeAAXcanvuy S5K9J801GpmaeUgPGcglbwQEJGdau1vo2G+e7q5XDPQxzT06XLqF2qaYQxmOSTSZ7/3Ddn8jTxp kCafBbbVC0oy9SMQo4Ik6KvWdu2tniTKGBZ/HBJZy3ZRi7cO+3G/76bodvHaosQW4VIIVwrdws1 IGkLmbyVqfpCWWBeL8y2ltKjV0o/A3 X-Google-Smtp-Source: AGHT+IE2bckZCt+YdjbqpJWarz2yxCVqzl493RJ7oTK/AC92gMmpx7Pnudth5AsvF1Rdh9Py4jeLTA== X-Received: by 2002:a05:6a20:7f84:b0:366:1a00:2dab with SMTP id adf61e73a8af0-3898f8482d7mr2248462637.3.1767797279097; Wed, 07 Jan 2026 06:47:59 -0800 (PST) Received: from shankari-IdeaPad.. ([2409:40f2:4a:8f9d:b0b5:f6be:9de8:e39b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819baa195aesm5208971b3a.8.2026.01.07.06.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 06:47:58 -0800 (PST) From: Shankari Anand To: Greg Kroah-Hartman , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Danilo Krummrich , Alice Ryhl , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alexandre Courbot , "Rafael J . Wysocki" , Miguel Ojeda , Alex Gaynor , Igor Korotin , Michal Wilczynski Cc: Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Daniel Almeida , Abdiel Janulgue , Robin Murphy , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Shankari Anand Subject: Re: [PATCH v2 4/4] rust: types: remove temporary re-exports of ARef and AlwaysRefCounted Date: Wed, 7 Jan 2026 20:17:39 +0530 Message-Id: <20260107144739.5847-1-shankari.ak0208@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260107143935.5757-1-shankari.ak0208@gmail.com> References: <20260107143935.5757-1-shankari.ak0208@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Jan 07, 2026 at 08:09:35PM +0530, Shankari Anand wrote: > > > Hello Miguel and all, > > > >> error[E0432]: unresolved import `crate::types::ARef` > > --> rust/kernel/scatterlist.rs:41:13 > > | > > 41 | types::{ARef, Opaque}, > > | ^^^^ no `ARef` in `types` > > | > > = help: consider importing this struct instead: > > crate::sync::aref::ARef > > -- > > This change has already been made in [1]. Probably it has showed up on the linux-next > recently which has caused the kernel bot to detect the error. > > > > >> error[E0405]: cannot find trait `AlwaysRefCounted` in module `crate::types` > > --> rust/kernel/device/property.rs:362:27 > > | > > 362 | unsafe impl crate::types::AlwaysRefCounted for FwNode { > > | ^^^^^^^^^^^^^^^^ not found in `crate::types` > > | > > help: consider importing this trait > > | > > 7 + use crate::sync::aref::AlwaysRefCounted; > > | > > help: if you import `AlwaysRefCounted`, refer to it directly > > | > > 362 - unsafe impl crate::types::AlwaysRefCounted for FwNode { > > 362 + unsafe impl AlwaysRefCounted for FwNode { > > | > > > > -- > > I haven't raised a patch for this file change I suppose. Should I do it in the same patch v3 > or put up a separate patch and reference it there? > > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > Please let me know which one would be appropriate and accordingly I'll send the revised patch. > I'll try to complete this refactoring soon. Sincere apologies that this has been going since quite a while now. > > Thanks a lot! > > Regards, > Shankari Apologies, I forgot to link [1] [1] - https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2da67beda68776842fd0a26f2374e42a5e9b12c8