From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DFE535A958 for ; Wed, 7 Jan 2026 15:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798561; cv=none; b=dkGgyHvIBWicE+XYm9YorxbldFZ0KdtnLGxJYYgUSdxfQUDy95F7rZzXXSkcygJdRy8BlWITwTr7GmNHTotXoFeY92gl0Xto943Bewz7OlVL1VWezAJh/FZOTSUNf4PqBDP/iX/HOLf45CMNvVRJyjKxXMeiBxOnhCCxmj8yiIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798561; c=relaxed/simple; bh=ZU5aP8O78dSxdoTaolgYTMsruktd3PaIhLm0H61X0dY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A5dpSrw/FACc1zfO+NgJYbXTd7VpHJ6CRubTw9UNBwjhG+dazJWWHiI9JFDqChyqTa6pTBpVmdaMIKzk/cqAyUeh4pEMG+lnxagnT/FsRIueinYT+etp+Qwjz1cf9keh+vmfRkiYPSw0dLKRFf+egXUgUXdbkbGPBw8W0F1NNJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GED68igh; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GED68igh" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo1702888b3a.2 for ; Wed, 07 Jan 2026 07:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767798559; x=1768403359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QGJr5/hzI8JoRIA81xmwa92sWuNgKBOZWdP5NsRWAM0=; b=GED68ighwE8iSNvK5lEtR/TcHhIPvHl0Gl5YGo1T/0DvBZYb76N2yGry93skyf8dIm 9I0TtRxVUow8CT5exkVddP/Q/NXn6avSQttpQYwrIUF+bSfOkWBhAZxh/VCkL6/ZQ2qs yxragIJaTJDKza7n7FV2iqqd7lYcKl6xcWH1mfhUfPSjANlMjxIg0Wiisioa7FeC3LfG MbXM1sw6ovubX3gsg6t5agu1Ev8lQeeo8KCaSSQVFpESbpesj2xxoKoCflt1s2l9COZU ZoUTHQqH4GioK5eAT0bIfr8pyP9QgYUAXrq1PcQD4nhUZdeAy4ptSkmxiu5Y/bfja9FI qWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798559; x=1768403359; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QGJr5/hzI8JoRIA81xmwa92sWuNgKBOZWdP5NsRWAM0=; b=wjwHOqNHMPmb1azvbyA0iAPp7w52w7L/AmIsNgns1/POyjDE61+4jrRuQ1jlpEi5Z8 DL1rJdYcjvigKtc9DeYgLSVGNPTW8Prt5PFRFY4MpuYFzPopAfY+YeeVi0wARWPDBJB2 VQiStAhco9GsGqhjsI3raeI4j+tjZxOii+DnHWrBen2aS6n9hsWh01yMyxXgLIFQvJvA rcwhaSuBVGHgXKLine9f2Z49G5+GjQX96Qd7uucOb1C+h4d9htGOtf+DBVPMbhl5zAF6 n7WIU6qHggQAex6ROeqi8MOmHaymW+OlDXvhqCoLPMFVfSeyGIDXZIoMTETokdYA8tRR VSyA== X-Forwarded-Encrypted: i=1; AJvYcCUdgJD6IAQcgehbodaXiE2AnFDb1Bu13B0Sr8EfE1iLNDTSBHnPOd/UUCPm1biHdZdFbQAntW9Ia7rdL7M=@vger.kernel.org X-Gm-Message-State: AOJu0YzFMdcs/nW81sIk3RjU7Fa2XBTlLtdKgiLC1h6gZuARyKTrP6FQ kTCLImBi8IFcW9rs10BbT47sR5BRAengykT3laoNz4WjCztb7g4wiUag X-Gm-Gg: AY/fxX6zRst2iDUP8WRZtfAU3B+HDsYkPR517t3bRYFzTI+OEoPA5xb3+RZc0E3eG4s CJGcLkrqz1Yd7+bUQQh/yshSb2Fhrlzr3VHBUfl/pvAcpzXRMXWN36U5dTg6g0HO9M7ybhIgLKt AzpaeSm9yB2jQydplMe1+8Cc1wphowJ3p/oktYyFaKeKqTEgXyJrMrJBhPvitWG1XxOOaS0eQOW 9bV9Cju0PRKrX0b2b/wxBOWbh3Izbz0IZtWs1Up+7mjYASJZrQEj05bb7kCxRpYDyt2vKE01cEj v1ahnhEDuR+wk4QHst9FFRlPVL82KzPutcL2f+ImZQih/e0J0JqQP28FQFpDHtYHpDAU1xhmlCB g7xPf/P6Q0CttvG4k4xK0FQ+C+FWihyW1xGRKxosbozvzGk+qe3gIhjWkX/8qPLVSMaNgbAr0Je vRREyaf+9Ezbk= X-Google-Smtp-Source: AGHT+IGIOHylZejHQrceK+q3mkfYA8k9rlJp3ALqXwHKd+bcwttRKyvJp1rMrS18e3tSDE8PbwaKHA== X-Received: by 2002:a05:6a00:81cc:b0:81c:717b:9d39 with SMTP id d2e1a72fcca58-81c717ba51amr236689b3a.56.1767798558555; Wed, 07 Jan 2026 07:09:18 -0800 (PST) Received: from karthik.. ([43.247.159.43]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59df961sm5246114b3a.47.2026.01.07.07.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:09:18 -0800 (PST) From: Karthikey D Kadati To: Hans de Goede , Mauro Carvalho Chehab Cc: Dan Carpenter , Sakari Ailus , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Karthikey D Kadati Subject: [PATCH v4 0/3] media: atomisp: refactoring and fixes for V4L2 compliance Date: Wed, 7 Jan 2026 20:38:55 +0530 Message-ID: <20260107150858.79818-1-karthikey3608@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series addresses maintainer feedback and fixes build errors in the atomisp driver. Patch 1: Standardizes the 'Bridge' structs significantly by using v4l2_rect instead of custom shadow structs and aligning ia_css_region members with V4L2 conventions. Patch 2: Introduces a helper function for statistics buffer allocation to reduce code duplication and centralize error handling logic. Patch 3: Adds missing error propagation for IRQ enable and XNR configuration to improve robustness. Changes in v4: - Drop overflow fix (long long casts) from Patch 1 to keep it a clean refactor/rename patch (Dan Carpenter). - Fix extra new lines in commit messages (Dan Carpenter). - Strictly wrap commit messages to 72 characters (Dan Carpenter). Changes in v3: - Remove unnecessary s32/u32 casts in atomisp_cmd.c (Dan Carpenter). - Propagate error codes in atomisp_ioctl.c (Dan Carpenter). - Update commit message for Patch 3 (Dan Carpenter). - Wrap cover letter and commit messages to 75 characters (Dan Carpenter). - Sent as a new thread. Changes in v2: - Split into a 3-patch series. - Standardized internal CSS types. - Fixed integer overflow safety. This series is based on the latest staging/next tree and has been verified with checkpatch.pl --strict. Karthikey D Kadati (3): media: atomisp: replace shadow zoom structs with v4l2_rect media: atomisp: consolidate statistics buffer allocation media: atomisp: propagate errors from ISP xnr and IRQ enable .../media/atomisp/include/linux/atomisp.h | 19 +-- .../staging/media/atomisp/pci/atomisp_cmd.c | 142 +++++++++--------- .../staging/media/atomisp/pci/atomisp_ioctl.c | 127 ++++++++++------ .../staging/media/atomisp/pci/ia_css_types.h | 6 +- .../staging/media/atomisp/pci/sh_css_params.c | 16 +- 5 files changed, 170 insertions(+), 140 deletions(-) -- 2.43.0