From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AEB5275AFD for ; Wed, 7 Jan 2026 07:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767771855; cv=none; b=rHI4IPP/20SiZ4iIjNDSZyIKzJCau7i7z7RNkSXFC37/rmcWN1Z+GFO8z8DJYAQ7b1fkdGPnzYrrsiKWyl4YL5G6uamLt4hVQgozX4do7S/1VZZ7/z0jdsboO1SbzTCgwEhBJfYUVbxwjFr3EeMI2LT00sDl0eVge6XDBhQaeM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767771855; c=relaxed/simple; bh=wtepG4ALMqKiyvEt0jTluSuqHX787/roVKJbXsbF/j0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fC07RV2E1cFJ1KMFXZGdckkW9XYzTorLwbeNDx1sHQjiaX5Jc5OvBkvlCB5isT5zO92e+VVrGxX4PVyK6dyVp1RpMqL02OLZJFwRhqB9ZG7uIZl6r+z7Znul+Ut5A7Y63FjvtX5DBA9Fe1YPp12uxE7MbV2kafXlQxFKlJrI0hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qkiAXa7S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qkiAXa7S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 201D6C4CEF7; Wed, 7 Jan 2026 07:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767771854; bh=wtepG4ALMqKiyvEt0jTluSuqHX787/roVKJbXsbF/j0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qkiAXa7S+dmxh6XiyOJ+dURPUcCWvD6eKm660lGoJceLJX0suxTera4dNqRcaUlgh w9+nwLM9cKZEZ5CTRWMDiezR/GE+amG8FjIGCKiGt7ayLbrignoWbYr41YE+01mW7J hxisgmoRvkbvxh7x2Li1OKcsBiQ986t3XZURBOtc= Date: Wed, 7 Jan 2026 08:44:11 +0100 From: Greg Kroah-Hartman To: "Christophe Leroy (CS GROUP)" Cc: Ioana Ciornei , Laurentiu Tudor , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: fsl-mc: add missing fsl_mc_bus_dpdbg_type declaration Message-ID: <2026010738-collie-quarters-5ceb@gregkh> References: <2026010755-registrar-agreeably-a626@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jan 07, 2026 at 08:39:41AM +0100, Christophe Leroy (CS GROUP) wrote: > Hi Ioana, > > Le 07/01/2026 à 06:30, Greg Kroah-Hartman a écrit : > > On Tue, Jan 06, 2026 at 07:54:21PM +0100, Christophe Leroy (CS GROUP) wrote: > > > Fix following sparse warning: > > > > > > CHECK drivers/bus/fsl-mc/fsl-mc-bus.c > > > drivers/bus/fsl-mc/fsl-mc-bus.c:435:26: warning: symbol 'fsl_mc_bus_dpdbg_type' was not declared. Should it be static? > > > > > > As it is exported it can't be static. So declare it in mc.h like > > > all other similar objects. > > > > > > Fixes: e70ba1b06c26 ("bus: fsl-mc: add the dpdbg device type") > > > Signed-off-by: Christophe Leroy (CS GROUP) > > > --- > > > include/linux/fsl/mc.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h > > > index 897d6211c1635..28441a456bb48 100644 > > > --- a/include/linux/fsl/mc.h > > > +++ b/include/linux/fsl/mc.h > > > @@ -451,6 +451,7 @@ extern const struct device_type fsl_mc_bus_dpdcei_type; > > > extern const struct device_type fsl_mc_bus_dpaiop_type; > > > extern const struct device_type fsl_mc_bus_dpci_type; > > > extern const struct device_type fsl_mc_bus_dpdmai_type; > > > +extern const struct device_type fsl_mc_bus_dpdbg_type; > > > > As it's obviously not used anywhere, this should not be the fix, please > > just mark it static and remove the EXPORT_SYMBOL_GPL() as well. > > What's your opinion here as Maintainer of this driver, what should we do ? > > Greg is right that it is nowhere used, and it is the same for several other > types, the only difference being that they have a matching > is_fsl_mc_bus_dp..() helper that hides the type, but not all helpers are > used, and many of them are not used outside drivers/bus/fsl-mc/ which cannot > be built as a module: Anything that does not need to be exported (i.e. not used by anything else in the kernel tree), should be made static. thanks, greg k-h