From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Alex Elder <elder@riscstar.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Michael Opdenacker <michael.opdenacker@rootcommit.com>,
Troy Mitchell <troymitchell988@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Subject: [PATCH v6 1/2] i2c: spacemit: move i2c_xfer_msg()
Date: Thu, 08 Jan 2026 15:52:11 +0800 [thread overview]
Message-ID: <20260108-k1-i2c-atomic-v6-1-41b132b70f68@linux.spacemit.com> (raw)
In-Reply-To: <20260108-k1-i2c-atomic-v6-0-41b132b70f68@linux.spacemit.com>
The upcoming PIO support requires a wait_pio_xfer() helper, which is
invoked from xfer_msg().
Since wait_pio_xfer() depends on err_check(), move the definition of
xfer_msg() after err_check() to avoid a forward declaration of
err_check().
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
---
Changes in v6:
- fix wrong subject
- Link to v5: https://lore.kernel.org/all/20251226-k1-i2c-atomic-v5-1-023c798c5523@linux.spacemit.com/
---
drivers/i2c/busses/i2c-k1.c | 62 ++++++++++++++++++++++-----------------------
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
index d42c03ef5db5984ea8e06b3d7eb485b4f899e616..accef6653b56bd3505770328af17e441fad613a7 100644
--- a/drivers/i2c/busses/i2c-k1.c
+++ b/drivers/i2c/busses/i2c-k1.c
@@ -304,37 +304,6 @@ static void spacemit_i2c_start(struct spacemit_i2c_dev *i2c)
writel(val, i2c->base + SPACEMIT_ICR);
}
-static int spacemit_i2c_xfer_msg(struct spacemit_i2c_dev *i2c)
-{
- unsigned long time_left;
- struct i2c_msg *msg;
-
- for (i2c->msg_idx = 0; i2c->msg_idx < i2c->msg_num; i2c->msg_idx++) {
- msg = &i2c->msgs[i2c->msg_idx];
- i2c->msg_buf = msg->buf;
- i2c->unprocessed = msg->len;
- i2c->status = 0;
-
- reinit_completion(&i2c->complete);
-
- spacemit_i2c_start(i2c);
-
- time_left = wait_for_completion_timeout(&i2c->complete,
- i2c->adapt.timeout);
- if (!time_left) {
- dev_err(i2c->dev, "msg completion timeout\n");
- spacemit_i2c_conditionally_reset_bus(i2c);
- spacemit_i2c_reset(i2c);
- return -ETIMEDOUT;
- }
-
- if (i2c->status & SPACEMIT_SR_ERR)
- return spacemit_i2c_handle_err(i2c);
- }
-
- return 0;
-}
-
static bool spacemit_i2c_is_last_msg(struct spacemit_i2c_dev *i2c)
{
if (i2c->msg_idx != i2c->msg_num - 1)
@@ -418,6 +387,37 @@ static void spacemit_i2c_err_check(struct spacemit_i2c_dev *i2c)
complete(&i2c->complete);
}
+static int spacemit_i2c_xfer_msg(struct spacemit_i2c_dev *i2c)
+{
+ unsigned long time_left;
+ struct i2c_msg *msg;
+
+ for (i2c->msg_idx = 0; i2c->msg_idx < i2c->msg_num; i2c->msg_idx++) {
+ msg = &i2c->msgs[i2c->msg_idx];
+ i2c->msg_buf = msg->buf;
+ i2c->unprocessed = msg->len;
+ i2c->status = 0;
+
+ reinit_completion(&i2c->complete);
+
+ spacemit_i2c_start(i2c);
+
+ time_left = wait_for_completion_timeout(&i2c->complete,
+ i2c->adapt.timeout);
+ if (!time_left) {
+ dev_err(i2c->dev, "msg completion timeout\n");
+ spacemit_i2c_conditionally_reset_bus(i2c);
+ spacemit_i2c_reset(i2c);
+ return -ETIMEDOUT;
+ }
+
+ if (i2c->status & SPACEMIT_SR_ERR)
+ return spacemit_i2c_handle_err(i2c);
+ }
+
+ return 0;
+}
+
static irqreturn_t spacemit_i2c_irq_handler(int irq, void *devid)
{
struct spacemit_i2c_dev *i2c = devid;
--
2.52.0
next prev parent reply other threads:[~2026-01-08 7:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:52 [PATCH v6 0/2] i2c: spacemit: introduce pio for k1 Troy Mitchell
2026-01-08 7:52 ` Troy Mitchell [this message]
2026-01-08 7:52 ` [PATCH v6 2/2] " Troy Mitchell
2026-01-14 15:47 ` Andi Shyti
2026-01-15 17:02 ` Alex Elder
2026-02-07 13:49 ` Troy Mitchell
2026-01-15 17:02 ` Alex Elder
2026-02-07 13:57 ` Troy Mitchell
2026-01-08 19:21 ` [PATCH v6 0/2] " Aurelien Jarno
2026-01-27 22:51 ` Aurelien Jarno
2026-01-29 9:58 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108-k1-i2c-atomic-v6-1-41b132b70f68@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=andi.shyti@kernel.org \
--cc=aurelien@aurel32.net \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.opdenacker@rootcommit.com \
--cc=spacemit@lists.linux.dev \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®