mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: George Guo <dongtai.guo@linux.dev>
To: etsal@meta.com
Cc: arighi@nvidia.com, changwoo@igalia.com, dongtai.guo@linux.dev,
	guodongtai@kylinos.cn, linux-kernel@vger.kernel.org,
	sched-ext@lists.linux.dev, tj@kernel.org, void@manifault.com
Subject: Re: [PATCH 1/1] sched_ext: Add error logging for dsq creation failures
Date: Thu,  8 Jan 2026 11:23:28 +0800	[thread overview]
Message-ID: <20260108032328.85947-1-dongtai.guo@linux.dev> (raw)
In-Reply-To: <BL1PR15MB531447D39DAACF121532E6A8C784A@BL1PR15MB5314.namprd15.prod.outlook.com>

Hi Etsal,
Thanks for reviewing!

> While the change looks correct, is there any benefit to it?
Yes, definitely. I found this issue while adding sched_ext support for
LoongArch. When scx_bpf_create_dsq() failed during my development, there
were no error messages at all, which made debugging difficult.

Specifically:
1. The failure was silent - no log, no error message in dmesg
2. I had to add bpf_printk() temporarily to confirm it was dsq creation failing

So the benefit is improved debuggability and faster issue diagnosis.

Thanks!


  reply	other threads:[~2026-01-08  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  6:28 George Guo
2026-01-07 17:32 ` Emil Tsalapatis
2026-01-08  3:23   ` George Guo [this message]
2026-01-08  6:25     ` Andrea Righi
2026-01-09 10:02       ` George Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108032328.85947-1-dongtai.guo@linux.dev \
    --to=dongtai.guo@linux.dev \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=etsal@meta.com \
    --cc=guodongtai@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome