From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E024A05EC for ; Thu, 8 Jan 2026 10:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767869628; cv=none; b=P//w99xNYE908P2R5ujNt1Q2tEE0dRiFGfvsCfuNejwOf0HYZGV7ZbSqMBEzi6CyeTtfkfoJ+CpLbad4a7h1UpvdK2lWgLy6KfirXLXTy2C8uzgWHLlmTULdGFWFJaepmkgPtCWSuml5f2HXmcMfECz0KlGBMpBgJMgxY7wGEXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767869628; c=relaxed/simple; bh=X1AeJ7N4i8+SK2RnBDtq0LwFDsMhBf5L0Kh+mUydmsA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OdN4WK/zAmIM+aqymVjpOfAV1+rfpBxLC5tNeNU0KtePVqe2q9dA57xdRxO0ljbgZnYPfhDMst6o2yEJC+NPODkxEZ9JEQ4MUdbd6VKnbqZKveuWWPk9/fxLWLhLwPol+2mFc1uh3hQgEpx3Ao99BMyM4xV1M7qsyJizTu6aeiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RcI2B89L; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RcI2B89L" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b79ea617f55so621413966b.3 for ; Thu, 08 Jan 2026 02:53:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767869621; x=1768474421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BGNSfyZ14mhgFHrLCd55IAkiSyATWPzAV9vrJzYyTU0=; b=RcI2B89LfhuMN6HD+PPSWyt87xquV7vg4iIsw+wvMIvjPn8azCrj5Bs+aCfNuPyB2S mnnt/6XfrxmAepaoh+EzxrNnmnY3OcYVGScA6VG+AVqLZxDgxBNO9p0ii0/Zi7+Ak0lx VWzqjd7H+RnColvyndUL3I6jgftEThxmyjH92ODD8W02ljuuCpqftM0Adzw18vN9YKt6 as4QG32TCwtjyDRoWiH5okuA3RWKpm/pDs/UO/4BUuXcK2/+qb4/FhnEaV7NEd/tHFkU sIjOBAmX3xK7WJ7dhbUsYykIML6pOY/bNkl2I1cwDZrDquK1UZWHC4T6wx4sC5cDvkEf cmag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767869621; x=1768474421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BGNSfyZ14mhgFHrLCd55IAkiSyATWPzAV9vrJzYyTU0=; b=AQcog7IoN/U2NTIkuQ/o7uO0JkrYuCdlyuc5iEPIzM2funrPnZjiR2dPmv5Km7mwPr YvDd59ZwTXhP5E4o67fnYVxPcDhpZ6DvVCgIkG/7sQGHmJ/kmpXz14qMzAvfNliSn20U 3zlONoUPPB6p1gICLKtAZe+K57x5s2/keeqtA/qMmB8NcSet3pDOkO/ZlPhu2WcoF2J8 YewmQ8Rei4wbnzSjHul+Q86uFXWprzxs+nIknql89BwBFUWOjwswsi9D1IwUt6pqky7i zPW+rxM7mcD6HSjbluAxmz2+HyI8y1RYVDhnX9lEnfwM4KXgyvUebE4I4nO5klBxMXsN iMCg== X-Forwarded-Encrypted: i=1; AJvYcCVsS6AyXwu52ak8+DuGovvv+UkOY+ns6CsEUK6QNB55NoQKYsSdDSvA6+2PBu5lYfruZreWx87eFcuPgyY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2N1ojl5QcxUgjEvrKJBnZuwhgXAUvMSO+uw7RqnUHrXf9ZXW7 KDmoNUOOxjy45F/pm2oqIju5dfTzOr9g6MYZwd4JSzrIZLgpzhvGnL7E X-Gm-Gg: AY/fxX6h16XFn78KCXEC/Pso56SfAVoflgo1qR3uIFWTcKMcdCiy4j3ANdiQ9YhsmAs ZFbH0JZZNWYPYgzb9fPTIQhUSmhBP+jNG6Dnz98cCM/IVaxOPlTcxzzT2NssQx+dUoGAhOHTlpW inqS5C/j8ppMgvx2Q8MgZka/fSxyfMgI8ZzL8czVsbVnwnvHBFWplto4ImCNFS2aB3McpWpQQUn 5JYHGsj2xdFG2VbsP2Y6dErxIhqkjwpiw8ub6SM+HfMS1rCIsZqUzy/WPoX0cGQ3sbnKzqyEhv/ cOIx2HNKHLDvvF7pyTYJXlNc7A0OuQow1S/X9qewGOZJgVVIfmVtyhQzVrLfHVBVerl7PvpgOM9 uw5fQ6Qoe6qTitY2uvrPZxdGqwoyatnNCYpufXjwWX3bXmdFjAoMFu9PI9bSM9BXDCmmsxzNeJa G76tNNlqRyipuw/7+D6AUjSiRpW642kAefWPtvFOZawzm5yBnSvLYU X-Google-Smtp-Source: AGHT+IGqCP130UpuuANz8HR/GkYDcNsmaKPOj1V5+2tWgODMHf6K6iZQhaCL0rcFVNmgtFuaq57HWA== X-Received: by 2002:a05:600c:3e8e:b0:459:db7b:988e with SMTP id 5b1f17b1804b1-47d84b1820amr58573495e9.13.1767863116998; Thu, 08 Jan 2026 01:05:16 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f390a69sm141644795e9.0.2026.01.08.01.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 01:05:16 -0800 (PST) Date: Thu, 8 Jan 2026 09:05:14 +0000 From: David Laight To: Kunihiko Hayashi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/2] net: ethernet: ave: Replace udelay with usleep_range Message-ID: <20260108090514.375a23fb@pumpkin> In-Reply-To: <20260108064641.2593749-2-hayashi.kunihiko@socionext.com> References: <20260108064641.2593749-1-hayashi.kunihiko@socionext.com> <20260108064641.2593749-2-hayashi.kunihiko@socionext.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 8 Jan 2026 15:46:41 +0900 Kunihiko Hayashi wrote: > Replace udelay() with usleep_range() as notified by checkpatch.pl. Nak. Look at the code... > > CHECK: usleep_range is preferred over udelay; see function description > of usleep_range() and udelay(). > #906: FILE: drivers/net/ethernet/socionext/sni_ave.c:906: > + udelay(50); > > Signed-off-by: Kunihiko Hayashi > --- > drivers/net/ethernet/socionext/sni_ave.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c > index 4700998c4837..a3735d81a862 100644 > --- a/drivers/net/ethernet/socionext/sni_ave.c > +++ b/drivers/net/ethernet/socionext/sni_ave.c > @@ -903,11 +903,11 @@ static void ave_rxfifo_reset(struct net_device *ndev) > > /* assert reset */ > writel(AVE_GRR_RXFFR, priv->base + AVE_GRR); > - udelay(50); > + usleep_range(50, 100); > > /* negate reset */ > writel(0, priv->base + AVE_GRR); > - udelay(20); > + usleep_range(20, 40); > > /* negate interrupt status */ > writel(AVE_GI_RXOVF, priv->base + AVE_GISR);