From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C36C487566 for ; Thu, 8 Jan 2026 11:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767870250; cv=none; b=etPJ/ORYOLbMrZ6wCXk+bMdVSQUQBMhHgl6JT1fD4VBfBNPDceioaDBfitnzpW1+ReYZDZSuc0R6dg6ywoXeA4ojHVi0YPvonmq2s6nKu7GGLEUW0vioN8m7Ftq4aHrhvdtaf48f8/y0A3IOCCaXx2bWKgiX7jwwC/BuqHuv5cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767870250; c=relaxed/simple; bh=ZEwqFCYVc4HimN+6rRHZCUw7Ywe13otDm1hjQ3A0GI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dU6VnuBTvSB1cWWAhakSpndSKSE15U81gB/S7Hjd5G4Ui7uHAoPeZEWGYNmO3WFabC1itm77J8Wplx7Kqd/p2hg3uR2mUOw63uv6TbFvb4XfPGcsASMSk9Zps0rKzULUEoWHnDhoOEomrSA6pnjJxIxAEr3mkOOXfQnA3AsPTLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ov9WfPtb; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ov9WfPtb" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7b8bbf16b71so2054895b3a.2 for ; Thu, 08 Jan 2026 03:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767870237; x=1768475037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fvJ1hD9P95fDY1XrAy912Nuk9aMYe060/j6X9Zcdrnk=; b=Ov9WfPtbCiRNWqJBP3fCt+R7Cgv/YEsDVzmxfEJEfwgia7d1Qo/8UOMQ16oAkpVQEy 6e4WjVt3l456kcm7ftWLFOTe+XrCb1kPmBQfVyEm/783AuC3W13MPhhoIllHtGimIgAn 8V6z7yx3GEXVfQ+DxsnB6E4N1TaU+9IUm1dJH7c3hTrpOC3ZwAIFGNjbDBjr3WcBrFuE CrYDDMWojHJimkWx4eJZynZqCEwR1TjAVIm9MCRB+9niK8cJnF8ewx/rmdZSlDk6wxdW o+wCUZeG+/IMeYrKJfWYN9zcM9jo34oB6wSQ5HFzusTNBpzj/I2B7CHfNQTr25FiP1HI b0hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767870237; x=1768475037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fvJ1hD9P95fDY1XrAy912Nuk9aMYe060/j6X9Zcdrnk=; b=RnjtkEdxFrzhxZ4Ycf3stN3mkxk41iR6nSf045WIUSYjtoEOu7EGNgRPFWNl4T7a2e ZR2ADCfM6+UNu1JDF5Hk5/AxqHuhnZfKfd5HBEh1XxrNSBbsGnkVMVUQqsElMM4ENII7 2o+Bc5y8MWQl9B6/5dH7SIDYYbqRQ92/bCwfsT6DyLNIUmnIltPS2hpCl3M01oHPax6O +NlA82OC++juZ6E0Xth+LG/2qNpc3Hq+r8/SO/3/ynxwZxrFGSu2qsw+0Oa1KZsE7JNd 3zQts7yXhEHKTcty5TAoycV+bZ1XNvqkZlBn46yVB3/YFPX5DP57h17+5RoLUGFcv39b 8mNg== X-Forwarded-Encrypted: i=1; AJvYcCV+uxn74BeQR3nP1vd06N6P3TDEj2x4OgbuP8qJAo1LZ5u36x2Kh/X764d+EMt2iVZrAZaSUO7u/z/d0Fg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq1PY6NgU8/eF7/9k2mIlpO/IWYJIokq8HvHdtfiyt65yuxACY 2qYQFk2JCUeD9ykwnv8gMSzZlcnNKuNSj98f5x5W/ncvZJY4cnqIZIVm X-Gm-Gg: AY/fxX6sMMwkNHXD+9z6nykNWWAc9VlKcpO7zIqElN3Jo+ncbyijbOvgeGrGd7FqMbQ dgijRmxo3JMCYwEOyL6PmQ44ntEVPDIlhT1KdQGyrf2t3aJtPuGQtlOjaimjPeb67GDp0dqTCcY nKZEJjT+HTse/IY4jnwSPGWS3KrQCTQYqxZGhlltpOtoBtE2/0S9n5NY0ihkv+rcmFA9Ukg6pO8 quArTAJauG0bWAPVgWjuQz8nXP6IyPMTlf4jjrj4EI2VwTOkKCWQZmUwILwgUhYM5S2hxgtMZVh zGvBaJyI3+v87Sid5BfqggmHwTTuHq/J/Yycllm8dYo/Dl+qjtj0NB1UirPF/ypUH4GG05Cv9lB zOLLbJeg1ygZW01Lx9Rr88vLOOMt41pUEwJWrjkucqLllSKNP3XmYzOFXddqxUXkLrsmOZ9f1cX 7sPDGgyZOJcbl3Nwn07eHfpCJVM1tci8d6F//SwIViayIvC2Umt6h76Vp1jrE= X-Google-Smtp-Source: AGHT+IEl8ADB2W9MKNjoK4jVTQCoZOQcVP/hdfKRsU+zAzuxw0OHlz0HKnR0pyLR55pljnit86/3xQ== X-Received: by 2002:a05:6a00:400e:b0:7e8:450c:61c1 with SMTP id d2e1a72fcca58-81b80ac599fmr4687647b3a.49.1767870237503; Thu, 08 Jan 2026 03:03:57 -0800 (PST) Received: from localhost.localdomain ([2409:40e3:44:c9c0:8d34:cc3d:a8c9:1a48]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59e8010sm7616172b3a.52.2026.01.08.03.03.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 08 Jan 2026 03:03:57 -0800 (PST) From: Chaitanya Mishra To: gregkh@linuxfoundation.org Cc: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, chaitanyamishra.ai@gmail.com Subject: Re: [PATCH v2] staging: greybus: lights: avoid NULL deref Date: Thu, 8 Jan 2026 16:33:51 +0530 Message-ID: <20260108110351.27771-1-chaitanyamishra.ai@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260108104947.23767-1-chaitanyamishra.ai@gmail.com> References: <20260108104947.23767-1-chaitanyamishra.ai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Greg, Found by manual code review while walking the error paths in Gb_lights_light_config(): channels_count is set before channels allocation, but cleanup uses channels_count to iterate and dereference light->channels. If kcalloc() fails, that becomes a NULL deref. Fix is simply deferring channels_count publication until after the allocation succeeds; v2 includes the requested comment. Tested with: ./scripts/checkpatch.pl --strict -g HEAD ./scripts/checkpatch.pl outgoing/0001-staging-greybus-lights-avoid-NULL-deref.patch I couldn't build-test locally on macOS due to missing for kernel host tools. Thanks, Chaitanya