From: Gatien Chevallier <gatien.chevallier@foss.st.com>
To: "Suzuki K Poulose" <suzuki.poulose@arm.com>,
"Mike Leach" <mike.leach@linaro.org>,
"James Clark" <james.clark@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Leo Yan" <leo.yan@linux.dev>,
"Clément Le Goffic" <legoffic.clement@gmail.com>,
"Linus Walleij" <linusw@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>
Cc: <coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
Gatien Chevallier <gatien.chevallier@foss.st.com>
Subject: [PATCH 11/11] pinctrl: stm32: add firewall checks before probing the HDP driver
Date: Fri, 9 Jan 2026 11:55:11 +0100 [thread overview]
Message-ID: <20260109-debug_bus-v1-11-8f2142b5a738@foss.st.com> (raw)
In-Reply-To: <20260109-debug_bus-v1-0-8f2142b5a738@foss.st.com>
Because the HDP peripheral both depends on debug and firewall
configuration, when CONFIG_STM32_FIREWALL is present, use the
stm32 firewall framework to be able to check these configuration against
the relevant controllers.
Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
---
drivers/pinctrl/stm32/pinctrl-stm32-hdp.c | 41 +++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32-hdp.c b/drivers/pinctrl/stm32/pinctrl-stm32-hdp.c
index 0b1dff01e04c..7e4aa0465c06 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32-hdp.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32-hdp.c
@@ -4,6 +4,7 @@
* Author: Clément Le Goffic <clement.legoffic@foss.st.com> for STMicroelectronics.
*/
#include <linux/bits.h>
+#include <linux/bus/stm32_firewall_device.h>
#include <linux/clk.h>
#include <linux/gpio/driver.h>
#include <linux/gpio/generic.h>
@@ -605,10 +606,50 @@ MODULE_DEVICE_TABLE(of, stm32_hdp_of_match);
static int stm32_hdp_probe(struct platform_device *pdev)
{
struct gpio_generic_chip_config config;
+ struct stm32_firewall *firewall = NULL;
struct device *dev = &pdev->dev;
struct stm32_hdp *hdp;
+ int nb_firewall;
u8 version;
int err;
+ int i;
+
+ nb_firewall = of_count_phandle_with_args(pdev->dev.of_node, "access-controllers",
+ "#access-controller-cells");
+ if (IS_ENABLED(CONFIG_STM32_FIREWALL) && nb_firewall != -ENOENT) {
+ if (nb_firewall <= 0)
+ return -EINVAL;
+
+ firewall = devm_kcalloc(dev, nb_firewall, sizeof(*firewall), GFP_KERNEL);
+ if (!firewall)
+ return -ENOMEM;
+
+ /* Get stm32 firewall information */
+ err = stm32_firewall_get_firewall(dev->of_node, firewall, nb_firewall);
+ if (err)
+ return dev_err_probe(dev, err, "Failed to get firewall controller\n");
+
+ for (i = 0; i < nb_firewall; i++) {
+ err = stm32_firewall_grant_access_by_id(firewall + i,
+ firewall[i].firewall_id);
+ if (err) {
+ while (i) {
+ u32 id;
+
+ i--;
+ id = firewall[i].firewall_id;
+ stm32_firewall_release_access_by_id(firewall + i, id);
+ }
+ if (err == -EACCES) {
+ dev_info(dev, "No firewall access\n");
+ return -ENODEV;
+ }
+
+ return dev_err_probe(dev, err, "Error checking firewall access\n");
+ }
+ }
+ }
+
hdp = devm_kzalloc(dev, sizeof(*hdp), GFP_KERNEL);
if (!hdp)
--
2.43.0
next prev parent reply other threads:[~2026-01-09 10:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 10:55 [PATCH 00/11] bus: add stm32 debug bus and coresight support for stm32mp1x platforms Gatien Chevallier
2026-01-09 10:55 ` [PATCH 01/11] dt-bindings: document access-controllers property for coresight peripherals Gatien Chevallier
2026-01-09 10:55 ` [PATCH 02/11] dt-bindings: pinctrl: document access-controllers property for stm32 HDP Gatien Chevallier
2026-01-11 11:27 ` Krzysztof Kozlowski
2026-01-12 8:24 ` Gatien CHEVALLIER
2026-01-12 16:10 ` Krzysztof Kozlowski
2026-01-09 10:55 ` [PATCH 03/11] dt-bindings: bus: document the stm32 debug bus Gatien Chevallier
2026-01-11 11:27 ` Krzysztof Kozlowski
2026-01-12 9:06 ` Gatien CHEVALLIER
2026-01-09 10:55 ` [PATCH 04/11] bus: stm32_firewall: allow check on different firewall controllers Gatien Chevallier
2026-01-09 10:55 ` [PATCH 05/11] drivers: bus: add the stm32 debug bus driver Gatien Chevallier
2026-01-11 11:27 ` Krzysztof Kozlowski
2026-01-12 9:13 ` Gatien CHEVALLIER
2026-01-13 14:45 ` Jens Wiklander
2026-01-13 16:09 ` Gatien CHEVALLIER
2026-01-14 6:53 ` Jens Wiklander
2026-01-09 10:55 ` [PATCH 06/11] arm: dts: stm32: introduce the debug bus for stm32mp1x platforms Gatien Chevallier
2026-01-09 10:55 ` [PATCH 07/11] arm: dts: stm32: enable the debug bus on stm32mp1x boards Gatien Chevallier
2026-01-09 10:55 ` [PATCH 08/11] arm: dts: stm32: enable CoreSight on stm32mp15xx-dkx boards Gatien Chevallier
2026-01-09 10:55 ` [PATCH 09/11] arm: dts: stm32: enable CoreSight on the stm32mp157c-ev1 board Gatien Chevallier
2026-01-09 10:55 ` [PATCH 10/11] arm: dts: stm32: enable CoreSight on the stm32mp135f-dk board Gatien Chevallier
2026-01-09 10:55 ` Gatien Chevallier [this message]
2026-01-09 23:10 ` [PATCH 00/11] bus: add stm32 debug bus and coresight support for stm32mp1x platforms Linus Walleij
2026-01-12 15:56 ` Gatien CHEVALLIER
2026-01-12 15:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109-debug_bus-v1-11-8f2142b5a738@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=legoffic.clement@gmail.com \
--cc=leo.yan@linux.dev \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®