From: "André Draszik" <andre.draszik@linaro.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Will McVicker" <willmcvicker@google.com>,
"Juan Yescas" <jyescas@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>
Subject: [PATCH v2 1/8] regulator: core: update two debug messages
Date: Fri, 09 Jan 2026 08:38:37 +0000 [thread overview]
Message-ID: <20260109-regulators-defer-v2-1-1a25dc968e60@linaro.org> (raw)
In-Reply-To: <20260109-regulators-defer-v2-0-1a25dc968e60@linaro.org>
1)
In print_constraints_debug(), the power budget is printed as:
lldo2: 450 <--> 1300 mV at 900 mV 2147483647 mW budge, enabled
(note the missing t in budget). This is because there is a --count just
below the call to scnprintf(), to make space for the comma. All similar
calls to scnprintf() above add an extra space to the format string to
allow for that, but this one doesn't, so the last character t is
stripped instead. Update the format string to fix the message.
2)
Add the name of the supply to the failure message printed when the
supply can not be resolved when debug messages are enabled to help with
debug.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
drivers/regulator/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 4b6182cde859adb356d160a012e54dcf1646da38..a723bd00e1716c2c3899c63314c6249015698216 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1183,7 +1183,7 @@ static void print_constraints_debug(struct regulator_dev *rdev)
count += scnprintf(buf + count, len - count, "standby ");
if (constraints->pw_budget_mW)
- count += scnprintf(buf + count, len - count, "%d mW budget",
+ count += scnprintf(buf + count, len - count, "%d mW budget ",
constraints->pw_budget_mW);
if (!count)
@@ -5697,7 +5697,8 @@ static int regulator_register_resolve_supply(struct device *dev, void *data)
struct regulator_dev *rdev = dev_to_rdev(dev);
if (regulator_resolve_supply(rdev))
- rdev_dbg(rdev, "unable to resolve supply\n");
+ rdev_dbg(rdev, "unable to resolve supply '%s'\n",
+ rdev->supply_name);
return 0;
}
--
2.52.0.457.g6b5491de43-goog
next prev parent reply other threads:[~2026-01-09 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 8:38 [PATCH v2 0/8] regulator: core: allow regulator_register() with missing required supply André Draszik
2026-01-09 8:38 ` André Draszik [this message]
2026-01-09 8:38 ` [PATCH v2 2/8] regulator: core: fix locking in regulator_resolve_supply() error path André Draszik
2026-01-09 8:38 ` [PATCH v2 3/8] regulator: core: move supply check earlier in set_machine_constraints() André Draszik
2026-01-09 8:38 ` [PATCH v2 4/8] regulator: core: streamline supply resolution for always-on/boot-on regulators André Draszik
2026-01-09 8:38 ` [PATCH v2 5/8] regulator: core: remove dead code in regulator_resolve_supply() André Draszik
2026-01-09 8:38 ` [PATCH v2 6/8] regulator: core: don't ignore errors from event forwarding setup André Draszik
2026-01-09 8:38 ` [PATCH v2 7/8] regulator: core: reresolve unresolved supplies when available André Draszik
2026-01-09 8:38 ` [PATCH v2 8/8] regulator: core: don't fail regulator_register() with missing required supply André Draszik
2026-01-12 14:31 ` [PATCH v2 0/8] regulator: core: allow " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109-regulators-defer-v2-1-1a25dc968e60@linaro.org \
--to=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=jonathanh@nvidia.com \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®