From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D01A738DD3 for ; Fri, 9 Jan 2026 00:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767918985; cv=none; b=VdgwnEthNyW0bYz+byhDw3EoAa7twcSsZFTrDCnQ4JCR1Ycz5snx7MlJQmpp3XnQ9olKBkufjzXupqcVNmxebbyR/RhmyrObiGLzbgj6WcTqSOER2TesFhJq5Qn2ycMJtK4Sv8PYDOm7eLaUrxvqIuZ4DPWD80xXeYmurL75kAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767918985; c=relaxed/simple; bh=HSbyzJte7ef9LUSwX8ZKl4Km7f9/oIn4+KkoGy1YFfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pZSqFlZn6A9SIlhw6hOTy8pRJtgxWNZJdvm9O/0QVe144hyt9gIPeIfKn1RzQFhaHbNDhZGnmJZWnQDyj27fN53c8XXsrB2yAVSznuBhJGGEYDVZxoAipg+J94wdl3jO28mJ1h0E01sNh5bI66BEYCnJ2MYgy4kmbGnCMLse48Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=QleLx14W; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="QleLx14W" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4f1b4bb40aaso19930951cf.3 for ; Thu, 08 Jan 2026 16:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1767918983; x=1768523783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=akXataDrrm2I8aSPYbuC2L/r92iwVSgkWRP1kilxNcE=; b=QleLx14W8+B1sjcbDSeHYPuLmdRPt64TE4pSsYuMOogdNbj5w0gjjjMdVDbSWS/xxW cWhcMj44zUdkiTADW28uJ8i8I9MahK1tdkwcXADKhbbF+H1cqo2a4WKG9LepEgWPFFjI IpqNvBl6nsvEdB7yNmMc2wJep5ad6xW4wEUoP9q4gu81oJt42MVN90lPSV4hxOtfbdlX PPb6vYbZSIjNU2hiJ6TYNNYA/fiJkh4Ck53VKP7VK1JABgAfvphXZMs6bwyaOR8yqzAf pSc/YcT/ORcOxS+SP/R05iaeYZxV9bV6BLawGzZbERjmsTvrOed2nl16kFGcXtPcDh16 tB3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767918983; x=1768523783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=akXataDrrm2I8aSPYbuC2L/r92iwVSgkWRP1kilxNcE=; b=xAxSoM6WZR4c8alWhZm4qUUSyBhe9V4qbxTS+e0JroAn2+0Y9o3COi4nd4lrw+t9yQ C2mxl8uu8ppd9KF5HKkb3aVYwEsQF/xX9LlWy5qEzAMMEH6ZkeU0LS2m0UFKPrPfrPIE Zw2IEO0fPAdV5tmhBUILlbAPXhpekukHDwOkgKVOvEWDIargPMskgC70oM1Ll818w7HD iC+4GER7VGaln1C7zZrZ7BWdJFq/zKgEnFvMN5l70cuwWKpYYvsUKze5xpIwnolrASfL R9IIAagE92yAafeSLnDuL4vEg9WT50KKIKX1h9hQDQYD+hCCunDBqNPwXDBBRaCtT4MM i6MA== X-Forwarded-Encrypted: i=1; AJvYcCU38/u60lfG3EHR8To67bM5hxmh00aEYM7L1G0OiN97lAto9IEf17ou6hB8Tx+f4L3kRasAzljmwUoo8kI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8z1HnQ3N26n7KONlXWNPemjcjo75BfPVHPb9ICcEB3Rf4Yom+ XIGjEPuVbhMvLCcRSjwvPQxHQE0OU+7ZE4g2w0a9L3NhEjgf4L9IAphnDjcXtly/Wng= X-Gm-Gg: AY/fxX4ql9RcUqmML2R7D1I/zC2o7s3idNc0T9BcTeS1YWiHCW99XjXB6Ne+puwzERq XbqhOn7W2fmIBjgbBrS+0Ixpj/SxVDARljSt6Np5e5XZVoy6agMLQ48/MIAvTC85BOLRBF7XUXo cz0RwLWiZPzzVsnMyEhDG6AvOFfBQ1hzmfmVvEQV4Ik7K7vkxbst3oaYKCNMzOKj3hG6blOZFnC n47uzNjtGXvhijh2unr4swm3nvfAyJ24s3d8gakvMD2nmNd7iYhoBWUCrXcMgcWjwI6lnC8+wrq 0ttHeuO8fUS/a0707C5GAr50kwY49l3QnG0U5jsMt1XrtLAwP1mAbmT8Q46uf/oNubJDdN16FLU hi/+AzGknjhK3OI8yREUBxWUuwCpkyoQQFp/bJp2Bjl4COmSIDdDPfgNAZBb3Mlh7eMvrf3VJwP IEDYP6XNjXH7Te71AWvgJ+S6aklbEkW7e1nWQ3/V9kgqj16J5X3pgRz0gLTyFsRb3HP8pb3wHzj GHVPw== X-Google-Smtp-Source: AGHT+IHmWhRihsDEqETUF+e9G1AVgeqEhpLtMexa+k8HuoAsY94LO++GxPutVwxZ0KIRKX6KuiPb9Q== X-Received: by 2002:ac8:5785:0:b0:4e8:9920:be58 with SMTP id d75a77b69052e-4ffb456fd65mr100400051cf.0.1767918982598; Thu, 08 Jan 2026 16:36:22 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ffa8e6257esm57727181cf.31.2026.01.08.16.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 16:36:22 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1ve0UH-00000002vXg-1uqs; Thu, 08 Jan 2026 20:36:21 -0400 Date: Thu, 8 Jan 2026 20:36:21 -0400 From: Jason Gunthorpe To: David Matlack Cc: Alex Williamson , Alex Mastro , Shuah Khan , Peter Xu , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] vfio: selftests: Add vfio_dma_mapping_mmio_test Message-ID: <20260109003621.GG545276@ziepe.ca> References: <20260107-scratch-amastro-vfio-dma-mapping-mmio-test-v1-1-0cec5e9ec89b@fb.com> <20260108005406.GA545276@ziepe.ca> <20260108141044.GC545276@ziepe.ca> <20260108084514.1d5e3ee3@shazbot.org> <20260108183339.GF545276@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 08, 2026 at 09:29:29PM +0000, David Matlack wrote: > On 2026-01-08 02:33 PM, Jason Gunthorpe wrote: > > On Thu, Jan 08, 2026 at 10:24:19AM -0800, David Matlack wrote: > > > > > Oh, I was thinking about a compatability only flow only in the type 1 > > > > > emulation that internally magically converts a VMA to a dmabuf, but I > > > > > haven't written anything.. It is a bit tricky and the type 1 emulation > > > > > has not been as popular as I expected?? > > > > > > > > In part because of this gap, I'd guess. Thanks, > > > > > > Lack of huge mappings in the IOMMU when using VFIO_TYPE1_IOMMU is > > > another gap I'm aware of. > > > vfio_dma_mapping_test.vfio_type1_iommu_anonymous_hugetlb_1gb.dma_map_unmap > > > fails when IOMMUFD_VFIO_CONTAINER is enabled. > > > > What is this? I'm not aware of it.. > > It's one of the test cases within > tools/testing/selftests/vfio/vfio_dma_mapping_test.c. > > Here's the output when running with CONFIG_IOMMUFD_VFIO_CONTAINER=y: > > # RUN vfio_dma_mapping_test.vfio_type1_iommu_anonymous_hugetlb_1gb.dma_map_unmap ... > Mapped HVA 0x7f0480000000 (size 0x40000000) at IOVA 0x0 > Searching for IOVA 0x0 in /sys/kernel/debug/iommu/intel/0000:6a:01.0/domain_translation_struct > Found IOMMU mappings for IOVA 0x0: > PGD: 0x0000000203475027 > P4D: 0x0000000203476027 > PUD: 0x0000000203477027 > PMD: 0x00000001e7562027 > PTE: 0x00000041c0000067 > # tools/testing/selftests/vfio/vfio_dma_mapping_test.c:188:dma_map_unmap:Expected 0 (0) == mapping.pte (282394099815) > # dma_map_unmap: Test terminated by assertion > # FAIL vfio_dma_mapping_test.vfio_type1_iommu_anonymous_hugetlb_1gb.dma_map_unmap I can't think of any reason this would fail, I think your tests have found a real bug?? Can you check into it, what kernel call fails and where does the kernel code come from? I don't think I can run these tests with the HW I have?? Jason