From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF31519D8BC for ; Fri, 9 Jan 2026 03:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767928351; cv=none; b=rENJeECyn7C4RIiQwFQFwSpH1IkvQVP8T7MayUrfO9gjLA/aM4/FwCLIurbccODpF2xkGKDhzKuaV6iB+4WmkDm4mtIMEP0hDtj3/3tXapGiDEPF4OM9EKkAtaAV+2x6yN7xNb787O0Az73Q2rrt/I2VFllPLjqaGtXBAFT4JLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767928351; c=relaxed/simple; bh=NxF2APyDh7kydlBsRUArv+0fdkao1q6SoCQfANZLMRE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N83cPKDJw2elUh/DdHL9J5w/3TrnuRozVv7RpFkOG/yQmf5hJtmVibdHgUbOwC0N95xjQAmk+Wj+IO4NLLn132mvcVSg49PWg3zK7i4b5QH3PMsG3VAnTPiHJsOjq1/jX+zsGNMbyfL99tqTLa6zlqekQwrtqvnTqP6foKvqoAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=uf1Xudjl; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="uf1Xudjl" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6093C5jV42380078, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1767928325; bh=He7auMDVo3aIf4qbdO0LN4O3RzgxclPkNnrL0UJBUlI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=uf1XudjlByNU1+qaPhG6dos8ACaTyOfWPC145AaNsK5CkYcrnMj2flRW9y8aIJtUA I+Mmpcdu6KGiAiCyIUgZP4G0UKb5WCe8gHWVGKT3a4IoO+hQsNvReUtb7cFFucJDmO jq0KC/6P7NV2KP+NnrmYD/2BqBfCpsST3KPy3MXizu5KYg3wuItXxwks4lPOwnIOD9 zoeeQkgTIHI/IFjnIRBBqwTtKWVcwgIcFCPu28/eCzUusoN4DhfYsE4mHBu3ZMvm/c vxUd9bnODcNFlhg5YVDiz7WKxFW3pd4eO3E/6sD/GecLLnnoT+89zhFLalYXZmVe3C +rsMYeHafkFpQ== Received: from mail.realtek.com (rtkexhmbs03.realtek.com.tw[10.21.1.53]) by rtits2.realtek.com.tw (8.15.2/3.21/5.94) with ESMTPS id 6093C5jV42380078 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Jan 2026 11:12:05 +0800 Received: from RTKEXHMBS01.realtek.com.tw (172.21.6.40) by RTKEXHMBS03.realtek.com.tw (10.21.1.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 9 Jan 2026 11:12:06 +0800 Received: from RTKEXHMBS03.realtek.com.tw (10.21.1.53) by RTKEXHMBS01.realtek.com.tw (172.21.6.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 9 Jan 2026 11:12:05 +0800 Received: from cn1dhc-k02 (172.21.252.101) by RTKEXHMBS03.realtek.com.tw (10.21.1.53) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Fri, 9 Jan 2026 11:12:04 +0800 From: Yu-Chun Lin To: CC: , , , , , , , , , Subject: Re: [PATCH v2] regmap: Fix race condition in hwspinlock irqsave routine Date: Fri, 9 Jan 2026 11:12:04 +0800 Message-ID: <20260109031204.5069-1-eleanor.lin@realtek.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <96e4fa72-b9cf-4c7c-9485-a95f4903cdb6@sirena.org.uk> References: <96e4fa72-b9cf-4c7c-9485-a95f4903cdb6@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain > On Wed, Jan 07, 2026 at 11:26:10AM +0800, Yu-Chun Lin wrote: > > > v2: > > - Initialize 'flags' to 0. This fixes a -Werror build failure when > > CONFIG_HWSPINLOCK is disabled, as the stub function in that case does > > not initialize the pointer. > > > { > > struct regmap *map = __map; > > + unsigned long flags; > > > > hwspin_lock_timeout_irqsave(map->hwlock, UINT_MAX, > > - &map->spinlock_flags); > > + &flags); > > + map->spinlock_flags = flags; > > I'm not seeing that initialisation in the actual patch? Oops, sorry about that. I made a mistake and accidentally kept the v1 code. I will fix it in v3. Yu-Chun