From: Yuto Ohnuki <ytohnuki@amazon.com>
To: <jack@suse.cz>
Cc: <brauner@kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <viro@zeniv.linux.org.uk>,
<ytohnuki@amazon.com>
Subject: Re: [PATCH v1] fs: improve dump_inode() to safely access inode fields.
Date: Fri, 9 Jan 2026 15:16:30 +0000 [thread overview]
Message-ID: <20260109151630.65679-1-ytohnuki@amazon.com> (raw)
In-Reply-To: <d73zx7srt4todun77vlhx4k4o5sv4q4vu2nk3iecz4eu7cih4i@6fillvgbgpgq>
> I'd merge this variant with the variant below because NULL inode->i_sb is
> invalid as well and I think it's better to print that sb is invalid
> explicitely instead of just not printing sb info. Otherwise feel free to
> add:
> Reviewed-by: Jan Kara <jack@suse.cz>
Thank you for reviewing!
Sure, I'll resend v2 with this fix.
Thanks again for the feedback.
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
prev parent reply other threads:[~2026-01-09 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-01 16:53 Yuto Ohnuki
2026-01-06 8:15 ` Jan Kara
2026-01-09 15:16 ` Yuto Ohnuki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109151630.65679-1-ytohnuki@amazon.com \
--to=ytohnuki@amazon.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®