From: Nishanth Menon <nm@ti.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: <vulab@iscas.ac.cn>, <linux-arm-kernel@lists.infradead.org>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
<stable@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] soc: ti: pruss: fix double free in pruss_clk_mux_setup()
Date: Fri, 9 Jan 2026 14:04:44 -0600 [thread overview]
Message-ID: <20260109200444.k4kyd5zqqsjeojsx@dreadlock> (raw)
In-Reply-To: <2819dc88-51a5-44f5-bedb-6759e7786fb2@web.de>
On 17:40-20260109, Markus Elfring wrote:
> …
> > +++ b/drivers/soc/ti/pruss.c
> > @@ -368,10 +368,9 @@ static int pruss_clk_mux_setup(struct pruss *pruss, struct clk *clk_mux,
> > clk_mux_np);
> > if (ret) {
> > dev_err(dev, "failed to add clkmux free action %d", ret);
> > - goto put_clk_mux_np;
> > }
>
> You may omit curly brackets here.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc4#n197
agree.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
https://ti.com/opensource
prev parent reply other threads:[~2026-01-09 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 15:20 Wentao Liang
2026-01-09 16:40 ` Markus Elfring
2026-01-09 20:04 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109200444.k4kyd5zqqsjeojsx@dreadlock \
--to=nm@ti.com \
--cc=Markus.Elfring@web.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®