From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Akhil P Oommen <akhilpo@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org
Subject: [PATCH 11/11] drm/msm/a6xx: use new helper to set min_acc length
Date: Sat, 10 Jan 2026 21:38:03 +0200 [thread overview]
Message-ID: <20260110-iris-ubwc-v1-11-dd70494dcd7b@oss.qualcomm.com> (raw)
In-Reply-To: <20260110-iris-ubwc-v1-0-dd70494dcd7b@oss.qualcomm.com>
Use freshly defined helper instead of hardcoding the checks in the
driver.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index 2129d230a92b..04de4d598da0 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -820,7 +820,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
u32 level2_swizzling_dis = !(cfg->ubwc_swizzle & UBWC_SWIZZLE_ENABLE_LVL2);
bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg);
bool amsbc = cfg->ubwc_enc_version >= UBWC_3_0;
- bool min_acc_len_64b = false;
+ bool min_acc_len_64b;
u8 uavflagprd_inv = 0;
u32 hbb_hi = hbb >> 2;
u32 hbb_lo = hbb & 3;
@@ -828,8 +828,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
if (adreno_is_a650_family(adreno_gpu) || adreno_is_a7xx(adreno_gpu))
uavflagprd_inv = 2;
- if (adreno_is_a610(adreno_gpu) || adreno_is_a702(adreno_gpu))
- min_acc_len_64b = true;
+ min_acc_len_64b = qcom_ubwc_min_acc_length_64b(cfg);
gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL,
level2_swizzling_dis << 12 |
--
2.47.3
next prev parent reply other threads:[~2026-01-10 19:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 19:37 [PATCH 00/11] media: iris: migrate to using global UBWC config Dmitry Baryshkov
2026-01-10 19:37 ` [PATCH 01/11] soc: qcom: ubwc: add missing include Dmitry Baryshkov
2026-01-11 20:58 ` Bryan O'Donoghue
2026-01-10 19:37 ` [PATCH 02/11] soc: qcom: ubwc: add helper to get min_acc length Dmitry Baryshkov
2026-01-11 21:03 ` Bryan O'Donoghue
2026-01-11 21:05 ` Bryan O'Donoghue
2026-01-11 22:39 ` Dmitry Baryshkov
2026-01-12 11:08 ` Konrad Dybcio
2026-01-13 0:24 ` Dmitry Baryshkov
2026-01-13 15:26 ` Konrad Dybcio
2026-01-13 16:48 ` Dmitry Baryshkov
2026-01-14 22:22 ` Bjorn Andersson
2026-01-10 19:37 ` [PATCH 03/11] media: iris: retrieve UBWC platform configuration Dmitry Baryshkov
2026-01-11 21:01 ` Bryan O'Donoghue
2026-01-10 19:37 ` [PATCH 04/11] media: iris: don't specify min_acc_length in the source code Dmitry Baryshkov
2026-01-11 21:06 ` Bryan O'Donoghue
2026-01-11 22:43 ` Dmitry Baryshkov
2026-01-10 19:37 ` [PATCH 05/11] media: iris: don't specify highest_bank_bit " Dmitry Baryshkov
2026-01-11 21:07 ` Bryan O'Donoghue
2026-01-12 11:02 ` Konrad Dybcio
2026-01-10 19:37 ` [PATCH 06/11] media: iris: don't specify ubwc_swizzle " Dmitry Baryshkov
2026-01-11 21:08 ` Bryan O'Donoghue
2026-01-12 11:03 ` Konrad Dybcio
2026-01-10 19:37 ` [PATCH 07/11] media: iris: don't specify bank_spreading " Dmitry Baryshkov
2026-01-11 21:09 ` Bryan O'Donoghue
2026-01-12 11:03 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 08/11] media: iris: don't specify max_channels " Dmitry Baryshkov
2026-01-11 21:09 ` Bryan O'Donoghue
2026-01-12 11:05 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 09/11] media: iris: drop remnants of UBWC configuration Dmitry Baryshkov
2026-01-11 21:10 ` Bryan O'Donoghue
2026-01-12 11:06 ` Konrad Dybcio
2026-01-10 19:38 ` [PATCH 10/11] drm/msm/mdss: use new helper to set min_acc length Dmitry Baryshkov
2026-01-12 11:08 ` Konrad Dybcio
2026-01-10 19:38 ` Dmitry Baryshkov [this message]
2026-01-12 11:07 ` [PATCH 11/11] drm/msm/a6xx: " Konrad Dybcio
2026-01-15 3:00 ` (subset) [PATCH 00/11] media: iris: migrate to using global UBWC config Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110-iris-ubwc-v1-11-dd70494dcd7b@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®