mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yosry Ahmed <yosry.ahmed@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jim Mattson <jmattson@google.com>,
	Kevin Cheng <chengkev@google.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yosry Ahmed <yosry.ahmed@linux.dev>
Subject: [PATCH 4/4] RFC: KVM: SVM: WARN if VMSAVE/VMLOAD are not intercepted or virtualized
Date: Sat, 10 Jan 2026 00:48:21 +0000	[thread overview]
Message-ID: <20260110004821.3411245-5-yosry.ahmed@linux.dev> (raw)
In-Reply-To: <20260110004821.3411245-1-yosry.ahmed@linux.dev>

Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
---
 arch/x86/kvm/svm/svm.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index f1b032114406..983ae98133e9 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -1387,6 +1387,14 @@ static void svm_prepare_switch_to_guest(struct kvm_vcpu *vcpu)
 	if (svm->guest_state_loaded)
 		return;
 
+	/*
+	 * Without virtual VMSAVE/VMLOAD, the instruction would directly access
+	 * host physical addresses, so make sure they are intercepted.
+	 */
+	if (!(svm->vmcb->control.virt_ext & VIRTUAL_VMLOAD_VMSAVE_ENABLE_MASK))
+		WARN_ON_ONCE(!svm_is_intercept(svm, INTERCEPT_VMSAVE) ||
+			     !svm_is_intercept(svm, INTERCEPT_VMLOAD));
+
 	/*
 	 * Save additional host state that will be restored on VMEXIT (sev-es)
 	 * or subsequent vmload of host save area.
-- 
2.52.0.457.g6b5491de43-goog


  parent reply	other threads:[~2026-01-10  0:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10  0:48 [PATCH 0/4] KVM: nSVM: nested VMSAVE/VMLOAD fixes Yosry Ahmed
2026-01-10  0:48 ` [PATCH 1/4] KVM: nSVM: Always use vmcb01 in VMLOAD/VMSAVE emulation Yosry Ahmed
2026-01-10  0:48 ` [PATCH 2/4] KVM: SVM: Stop toggling virtual VMSAVE/VMLOAD on intercept recalc Yosry Ahmed
2026-01-10  0:48 ` [PATCH 3/4] KVM: selftests: Add a selftests for nested VMLOAD/VMSAVE Yosry Ahmed
2026-01-10  0:48 ` Yosry Ahmed [this message]
2026-01-15 18:03 ` [PATCH 0/4] KVM: nSVM: nested VMSAVE/VMLOAD fixes Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260110004821.3411245-5-yosry.ahmed@linux.dev \
    --to=yosry.ahmed@linux.dev \
    --cc=chengkev@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®