From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5891425A659 for ; Sat, 10 Jan 2026 23:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088691; cv=none; b=KQBDpsVgEhCekghpGRIxBaHTpwR6odxOQ49FKP9U/Eq+Pdwz1PNoeETQO3k3Da138tyZDGxBj1t0lHA6LpIeNKBo/6mSxIp/UpNgEwqEgYJBdKVFYw4PfqI0MY2sNZ0m9uev5NY/LUguOrax4PV7x2TQuPBno3yZ8Yu2913jHyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768088691; c=relaxed/simple; bh=0hlf1EwjX8n89d+KRv9w/Zg1vh2Xb1fqWAUVd6PX608=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vhjo4LLcIu3bm1K1TMHqSNiba390HNDhgm1Lm1MhysjJg00/ILBcb4SnZcfpoTDwB1L/qgcqC3W7n319sLigZ+xapiIBiHZN3oDr+BSuPiU1RfTqzWLLRbgH6ozbEwPfoSFtn92/l0L8jc1Fq9U6kyW7MqdjIp8nd2TF1/IzYUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KJW5BQ1X; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hm6bcZFd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KJW5BQ1X"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hm6bcZFd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768088689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0NZhG5CFt1ybfdmia3vmiDdp4otmf8/CdWQnIGdtkyg=; b=KJW5BQ1XJZh3RjBFD6Mf4tIhjOb7tqpkgsj8awL4cimMky6DleZKWP+1ANC0vr5bi6TVjX W5QVSiBjGSiP4wxJ0CCS58qc2OC+C1xj7hC0WrFm8CKBJo948YcMjGGJ2ECDBu5+VlQS2B RWPdCbc4oqQ9yByFOTHhA0fkduZ1yCg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-k6VDsXyKNOqbZhhW3udVkw-1; Sat, 10 Jan 2026 18:44:47 -0500 X-MC-Unique: k6VDsXyKNOqbZhhW3udVkw-1 X-Mimecast-MFC-AGG-ID: k6VDsXyKNOqbZhhW3udVkw_1768088686 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47d1622509eso34573145e9.3 for ; Sat, 10 Jan 2026 15:44:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768088686; x=1768693486; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=0NZhG5CFt1ybfdmia3vmiDdp4otmf8/CdWQnIGdtkyg=; b=hm6bcZFd6tcjNzDpRrWxz+G1JkuV87Wvi55+AHZTNTUX2o5D+eR5jM0QTKC62PkFxt FyZFZEQoI3CTLO8MKlXqHZgfB1INL8ocC8olRI5u/Q+/ydGRut+tj/RI4mT8/M6X35VE S5YnmqpbV+3tzCm0TihhfBCGupGFxUPaIP1iv7zYuhto/i0qdDuDUJeleBRneP8Ur6ul +52DvoCsSVdnhVwxvH2WCsLPOOZvsM8Ni3/0D/NYYeVOd1DxBovCi4hJAp4gzb37m811 NTTfFWXfBktZler0ubp6DkQra/Hd+iL/HRaAktyHuaNmRXs5CD1MK/dDtQTdwUD3KpeX F7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768088686; x=1768693486; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0NZhG5CFt1ybfdmia3vmiDdp4otmf8/CdWQnIGdtkyg=; b=bj7W8wXIHfEB3WqR6DIQD1kPWdMvSHI8jHbTIJOTBxWulEl/y6MfZpKHFmw1u3YQbJ o70TKUMahxCxsiy8YsZh2yCs8iLIZefippJIF9toVDNrz7LVGO4t1Z+ebO6v2U2ONEqQ tsY7r1jp0YsWMiU1G3bu4pMDUNCCQdIhxSXuK9nLGPDgfAm8OukS++Ugh0cVUa/1wR7G wQADq0KnLKLEFcgz0Adjo26bWT4hpEoYJ5r/VuJTkCqqnUoKxnEqcEPlUDSIayEqBExE T84f1QWJC+rnpIsSzZ9Qjq+ofFptcuH0Y7Dyf0e8N5cthfPKtVNmyVil3x8Osj9Lcapx pINQ== X-Gm-Message-State: AOJu0Yw9UGevSzHZ15jCDOEWuwWBpx3yVY+AZRTP5EYyZ52Br7mzDmBC QMKASLQFXFLKAB3kbmhcUBLnmdENCWzYpECbiuCbv/nuiWabs2xW6/RmyggedKO2ge987ee2EUI SojEsYE/AzDzG0NiTGTxZMXXvsS+NsurwUfTrSclaLCrKZeaJL4Q2jvYHe1ifkLeqDA== X-Gm-Gg: AY/fxX77Yr54fRK5AKn3IQfXRdBEj+Zg80iDUDxjIL0EzInjoYFvt4v9ELRzkfJDpP5 oYlv2/ROl6wfs7joH57rcgTSYsAJG0w1C2F8exFT/gjGJxDEYGCBBiw6ZpLEFQ9goFFHaTv62rh M33SXbUDk+ZvkDftXQpLmUD1vWxteV7+kUjog6YB9K4IXt/xPYFiOf5cbKpsNMNDP9aRUg1KbgL pN8OfBPkZY+/er4p8LXc2nUhyUT5Kd+70yfhwRsEevsPMo6IHv0nTucCVfXtoP/QN/PabOKKheT hMU7pmgA99SR0UDxt3qeOBzm96rtiKD6QJcMGawE0tunucmbRWn2Y4b8zKu6AnYsttXLph9L5Yh z5CRHlcUVbhr6qkwYplzJE+Mm/vRB8AM= X-Received: by 2002:a05:600c:8b57:b0:477:73e9:dbe7 with SMTP id 5b1f17b1804b1-47d84b61399mr146048245e9.35.1768088686013; Sat, 10 Jan 2026 15:44:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWkxbGlnPNV/i0aKN6HHihFYnCeF7i35rO33Z3KEBVwX5gEpgyJ5DuhDBv8/FZocKje+6kqw== X-Received: by 2002:a05:600c:8b57:b0:477:73e9:dbe7 with SMTP id 5b1f17b1804b1-47d84b61399mr146048185e9.35.1768088685621; Sat, 10 Jan 2026 15:44:45 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8662c09bsm100644835e9.2.2026.01.10.15.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 15:44:44 -0800 (PST) Date: Sat, 10 Jan 2026 18:44:41 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 02/12] vduse: add vq group support Message-ID: <20260110183910-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-3-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109152430.512923-3-eperezma@redhat.com> On Fri, Jan 09, 2026 at 04:24:20PM +0100, Eugenio Pérez wrote: > @@ -1252,12 +1266,24 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd, > if (config.index >= dev->vq_num) > break; > > - if (!is_mem_zero((const char *)config.reserved, > - sizeof(config.reserved))) > + if (dev->api_version < VDUSE_API_VERSION_1 && config.group) > + break; > + > + if (dev->api_version >= VDUSE_API_VERSION_1) { > + if (config.group >= dev->ngroups) > + break; > + if (dev->status & VIRTIO_CONFIG_S_DRIVER_OK) > + break; > + } > + > + if (config.reserved1 || > + !is_mem_zero((const char *)config.reserved2, > + sizeof(config.reserved2))) Hmm but if api version is 0 then group should be 0 no? We should validate.