From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E01B1A58D for ; Sat, 10 Jan 2026 23:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768089251; cv=none; b=PfhdgC9oYSK1swN3QKlrVMdFHOlCWVwkBA8KTasPtyYsGMTheZPsvogM4KRR7/Ex7mar/u/7u7x2DQ0abXIUYWoqfPlW8S2/EA2kSUXDR3HVJhSDJEYlfw6NXBA829mjbG3hkg3k/H7DD+G1lZxFqoP0aU6AXXaQnO49kiWY02Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768089251; c=relaxed/simple; bh=Va3PZ+XyHWYa7wvBVca2BSI3zTZzZLZMzJcYIoJwDzo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UCCyHj0C4SIqRCR6+1lu/GJfzBOwR5xBCnyntg+YtutdUBY4OrOgSGdzJhlqfm5HHolxPyi926cZPht0pV7w/hOLgGvbUYC8wOGy0nBoNvZSzOzdIGRLmXJ+KQ7YGMPTtZTyjpG7nVxppd4mS6utVzw0wDwucl2aEiSnIPIcb+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AAKptrDX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=o+ykD8i6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AAKptrDX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="o+ykD8i6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768089249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMIqYyYEkztN33AcbA8wyUqktgEZTsE9ZUOY1WJxaMg=; b=AAKptrDXT49NWSjHG8bfpeKtGkoR2G5aA0gxVT9YSfLuC/YmgeT+ByVFKkCB2I8NR+2xnf oKe7FonE3ZOpmip0Y/6+AnvxqLKoGWDyBICLLVKyICRqVXpgWC8R+/B5GWeU9a7knj5nDJ WHdSpHt3xKsKAAaJYcuVPsqlHfErod4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-YNPAMETiPnquB7qIVxu0Aw-1; Sat, 10 Jan 2026 18:54:08 -0500 X-MC-Unique: YNPAMETiPnquB7qIVxu0Aw-1 X-Mimecast-MFC-AGG-ID: YNPAMETiPnquB7qIVxu0Aw_1768089247 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso39380415e9.2 for ; Sat, 10 Jan 2026 15:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768089247; x=1768694047; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XMIqYyYEkztN33AcbA8wyUqktgEZTsE9ZUOY1WJxaMg=; b=o+ykD8i6deBSTshouEkMvACBnISnxR1whMw406b5I+EaQOsdjPpcxEzKzrCDmGdMc2 MDstJnbOwN/zLU3FwHrGayKmn4EgkoqYA97weNXwCFQB9PlefiMX25JssjiRoz0D9UgF fi/t9pDSYhaBUSSB3t8VwEM3EBEWyFSpRu+bGfa6CXI7UZht5Z2fUNjuloMt3n/0rXNz rbdrsVXy1ZHAimMAFlb8/lYESBc/q0hi8NxyDKsDLD+I3o0bEsPNZykWeTk/dHHM0eAB X3t9QQ2rttnyXMiSC9Bqm5olFdrKFzeAUR/VjxMCJCU3EDrJ7r/G2k2oOnRkEhMigGdh GdVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768089247; x=1768694047; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XMIqYyYEkztN33AcbA8wyUqktgEZTsE9ZUOY1WJxaMg=; b=g+cxc0XEmRTOz2mtsP4eCLoQiwBXF0MLFuCtNogZ6jZjgKPjd5b989TEoqrV+Tk/og lx0glw8W4pl5p4ALWS2rFsW+3V6X2HmuOjnUkXQqhPBKPX6omZVCB2h+7Bk1XA5vJi2K iMnzZZZDUXpCYlgkjvLHMuxzwCvy/nao8cp1ROY1YNHR1wfxSUn+uIDJlnn/IE58g6w+ 3Uw8M0Irm8mmuwjnXrAZNh6XK+akvB0yHeEBZEUuHm9OenxD8Hb3gwNm2dz4XpS80EsX 3XesqQ6vLsPb6Zqq3O7o00YRZZJcm4bUx61bvAWhwEHKGIN40ePBUFallvphF72BecqU f70g== X-Gm-Message-State: AOJu0YzOnwulv/9+vI4tvFHz2hYRVpSSgHddZa0mjuUGxlGGGO1XaIkb IBafdqhowiyGHqXnruucX+oqsDq/HB0rXKDgGaDmgOI+ttQ4FYwTnY+qcOpMDbZcBXJ2V2+YQ87 0rtN5z06rjQkLq0YPceOAsvf4WlUGqM4hG0fwd1hyS2mfyM0TBhkYIOZ1WDyoPywFMQ== X-Gm-Gg: AY/fxX6zmwqErKMhvA1vKRygZoUk6eOGeEGf6qkf/MuvrHMFyZyZc47RBuTAydhwU9i xa3XWQSPPrg7yXU8vl1tMG22kuYVeo/S9skdaxSbVmVgWJmfHTm37n/PjG/g6HInMiWhaN4oxM1 zFAPCPqBsKQHKz2xQKPPlvYrYZQIi7yGH8HhqljcBtJR6BB7mK/mH0s1oZ89uwNNxUa6SXYFtSP dAox2nRUjHmTsLizFEyQCT/JdZaYU1ofZhYN6H48PnR7tcpM0ZY5R7alr4Lk48SXipop+JQLvuY RsyABgfDfW4hCAszREz4R9gUbvJZ7yq4BgzPmQJQD0LteGgR7qf+G3nd8axXSx0ZhZpcUv+nKvt qhsHcpFvcZvYaIUL0CFSf1BdsFo6j7mY= X-Received: by 2002:a05:600c:1988:b0:477:73e9:dc17 with SMTP id 5b1f17b1804b1-47d84b52c14mr169376125e9.35.1768089247047; Sat, 10 Jan 2026 15:54:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IH2lFv6S2UpYScZqXvGjsvTnj/bNNQPc/FV+uevdBAkv0ovWOp0NMfbAA2MPXsWK69PV+zdKw== X-Received: by 2002:a05:600c:1988:b0:477:73e9:dc17 with SMTP id 5b1f17b1804b1-47d84b52c14mr169375965e9.35.1768089246654; Sat, 10 Jan 2026 15:54:06 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8719d057sm93697125e9.16.2026.01.10.15.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 15:54:06 -0800 (PST) Date: Sat, 10 Jan 2026 18:54:03 -0500 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 09/12] vduse: take out allocations from vduse_dev_alloc_coherent Message-ID: <20260110185006-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-10-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260109152430.512923-10-eperezma@redhat.com> On Fri, Jan 09, 2026 at 04:24:27PM +0100, Eugenio Pérez wrote: > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index 82ee476d45e0..675da1465e0e 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -923,16 +923,24 @@ static void *vduse_dev_alloc_coherent(union virtio_map token, size_t size, > if (!token.group) > return NULL; > > + addr = alloc_pages_exact(size, flag); > + if (!addr) > + return NULL; > + So addr has allocated pages here ... > vdev = token.group->dev; > domain = vdev->domain; > addr = vduse_domain_alloc_coherent(domain, size, > - (dma_addr_t *)&iova, flag); > + (dma_addr_t *)&iova, addr); and then is overwritten here ... > if (!addr) > - return NULL; > + goto err; except on error where we go to err ... > > *dma_addr = (dma_addr_t)iova; > > return addr; > + > +err: > + free_pages_exact(addr, size); only to try and free NULL. will leak the original pages, will it not. > + return NULL; > } > > static void vduse_dev_free_coherent(union virtio_map token, size_t size,