mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Petre Rodan" <petre.rodan@subdimension.ro>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] iio: pressure: add Honeywell ABP2 driver
Date: Sun, 11 Jan 2026 12:53:24 +0000	[thread overview]
Message-ID: <20260111125324.0e86e990@jic23-huawei> (raw)
In-Reply-To: <aVkX6bCR8nkoUwQI@smile.fi.intel.com>

On Sat, 3 Jan 2026 15:21:45 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Jan 03, 2026 at 06:35:17AM +0200, Petre Rodan wrote:
> > Adds driver for digital Honeywell ABP2 series of board mount
> > pressure and temperature sensors.
> > 
> > This driver covers 113 different pressure ranges and units on
> > both i2c and SPI buses.
> > 
> > The communication protocol involves sending two simple commands
> > to the sensor and there is no register access or a memory map.
> > For this reason the regmap API was not used.
> > 
> > The i2c address is hardcoded and depends on the part number.
> > 
> > Optional end of conversion interrupt control is present on the
> > i2c variants of the chips.
> > The EOC can also be defined for the SPI variants if a non-ABP2
> > but compatible chip is to be driven.
> > 
> > Tested on two sensors (ABP2MRRT001PDSA3 and ABP2DANT001BA2A3).  
> 
> > ocuments/sps-siot-abp2-series-datasheet-32350268-en.pdf  
> 
> Broken link now.
> 
> > Datasheet: https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/basic-abp2-series/d  
> 
> Should be in this line, but do *not* resend just for this, I hope if everything
> else is okay, Jonathan will fix the above issue.
> 
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>  
> 
As I replied to v4, this is now a long way back in the tree so
I'm not going to rebase.  Please send a patch on top of the
testing tree of iio.git making the changes.

Thanks,

Jonathan


      reply	other threads:[~2026-01-11 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-03  4:35 [PATCH v5 0/2] " Petre Rodan
2026-01-03  4:35 ` [PATCH v5 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa Petre Rodan
2026-01-03  4:35 ` [PATCH v5 2/2] iio: pressure: add Honeywell ABP2 driver Petre Rodan
2026-01-03 13:21   ` Andy Shevchenko
2026-01-11 12:53     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260111125324.0e86e990@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=petre.rodan@subdimension.ro \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®