From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0765033A9CE for ; Mon, 12 Jan 2026 07:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204647; cv=none; b=H9qzlX8k1VHSqNQt5GT/bgFiSFugJmjB1hidLD3n5vtWHGxBcpTMJu7rlE9KlyavUcWgRT793s8W05mAMu0bKxBL4IKED+veWKXeCEKOLmg9/1RcmIWRoC7+8KDSlWPyvaaPMXtRny8yWYopv2dXvl2ESEYReuvIhux/HyfDVr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204647; c=relaxed/simple; bh=xJsrVMye5Gxd+KJoZVkqplX/4R2uP5UbfHEvPcP7uUE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bhgZ8MdbOyIUsyOBuOzGLqSKwEDEUOe6fdSeJ+cHS9VnC+ZfbCfdHjhtWU3gK5T9ymEl18UCJZw+Xz5a+pdWCUJJKUHFxCa/3r4+58qCIVkoYN60TEoWwPSu6tqz7pjTgRWj4ROW69INszAaPitROrUUysavtm+f+GBYAIPoxRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XfrVbvjP; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XfrVbvjP" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so39167365e9.3 for ; Sun, 11 Jan 2026 23:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768204643; x=1768809443; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=DHcSpt0J//n9tWUuyEeRMDpqtJxrFluPI+axYyMOc4c=; b=XfrVbvjPOmnID7sm9RcHV+ehWoJHq6gM1kRrlX25nhIHnOCfaZyp0GYmGr03EI3Zzb RTDzoYLGu7GZXukxw+LXsTvyKWysEUb+3BsFqJ458UzDAh4IsO+VADtq3adnOJ00tMEe p4rkKQh6drmbSwjaOAkUkmUMYxf8emWU23+Y4YP77RmsvbHbUwlI98jXfomHPmVTwdmt TogW+OHUIkGjz5TIFuD0iaWTcCw5fpKGcMeCeZaUBm8cK0/BZ8aTTEcqGtgSZawikQwC B7j3rb0HywN7Nr+Md0yAJ3Z5AQu6eakgrPkoo3BXd0EhSXBcYVq5BjmMgEDgOqrcYVTr hidQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204643; x=1768809443; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DHcSpt0J//n9tWUuyEeRMDpqtJxrFluPI+axYyMOc4c=; b=I5lciRzo6fKOssL1Ka1/N0cC1ZX4B/NvgX1LOJUEnr2jc7KeNVPW6Xrkf9UGtHJbj5 cieOnkCBYkY+S7ZOcn+OXx3aw9x0GxpXOCxGTB7xVSKEQ3djbcVOtHLk+qSdE9JmYIGm 1ksBs0RntmFWe58xBN06mQ39T5s4b1tdT6Zmyev4CwMBPqY51i/MqdTCAuWqvrJUc6Iv kLFkpMgExqnzjLcS++oqhDyBlVCocu5yZhASjieQ7pLpeWYiSkO+Y+q1LXieqWjiq9rN QzJe8l/PBseNu5g3INdI6b2fRV91u9iLZaubwgN/IlRYHXkjx/XlE9pk9KWIsBnXGa3R WRZw== X-Forwarded-Encrypted: i=1; AJvYcCXE32CCrbDCFrzM+WfKGBsVCxzwOsC4vKO88P0JV8sqkF3jWMjI4EtpVRaQrC3if6yQfGFa95+jFHIQEWY=@vger.kernel.org X-Gm-Message-State: AOJu0YxsOc5QtqgnObgK3Sa05p4sFa7VFfWvsKwvaj+PV0Hb3zys4Zzd PhDy0iWG3jUL/fecdOWQsXePetfAsl/KnfJPOxUpVQFfK7RHe7K2OzIQ0RUZcGbHYZE= X-Gm-Gg: AY/fxX7OAR7ANW64aAx46/VcS+EQi5iVWmYPMFvQu1qzW0kkjVvUS45ZS2sIAzNAD8j 8fZ4BuVZuZG/BV93wnmV47fxtR4kqzsPhbTzbzL5/MII0OjGDxVKmsLIoq4kRgqlp3dsbapnFjU iilyD6Hp6jxm7N5TxDKvovN8WNeaisv6KgeLESMPDE33rMkseao8a1uMtpHLHWmwomPLNNmkqDG VfP3UXZcxacBPBYyGrPtVK06FvXOhCZLnctkYWhq7vtokakkaBSPSJejJeIpmaS8iPl8pR6gXjd B9COixLxgQS+p6371OoQLPoaOKiZbEsJskC75SB5z6DGy8zvkunZM3YaTb/tN9n2vUZPqCrmuor LpqgG48gPr7u6sZXOxedxJye97BwBaB5h3irLFz3KSuO/lpG/yWFbIGBKh0lgTQyycgfiE0CvQ/ uNjGHt/sYqNt/Kvchl X-Google-Smtp-Source: AGHT+IHVU3uwgmuYvSLIBEuChOaTGJ1itV2wYM6ORLIdCQZS9BFIJGw3/RWBYiCCesKrugKb6K7gZA== X-Received: by 2002:a05:600c:45d3:b0:47a:7fdd:2906 with SMTP id 5b1f17b1804b1-47d84b21188mr198858515e9.12.1768204643000; Sun, 11 Jan 2026 23:57:23 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee870sm37420251f8f.36.2026.01.11.23.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 23:57:22 -0800 (PST) Date: Mon, 12 Jan 2026 10:57:19 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Peng Fan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Shawn Guo , Marco Felsch Subject: drivers/soc/imx/soc-imx8m.c:143 imx8m_soc_prepare() warn: 'drvdata->ocotp_base' from of_iomap() not released on lines: 139. Message-ID: <202601111406.ZVV3YaiU-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 755bc1335e3b116b702205b72eb57b7b8aef2bb2 commit: 390c01073f5d0bd64db37926ddb232f33b83620d soc: imx8m: Cleanup with adding imx8m_soc_[un]prepare config: m68k-randconfig-r072-20260111 (https://download.01.org/0day-ci/archive/20260111/202601111406.ZVV3YaiU-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 14.3.0 smatch version: v0.5.0-8985-g2614ff1a If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202601111406.ZVV3YaiU-lkp@intel.com/ smatch warnings: drivers/soc/imx/soc-imx8m.c:143 imx8m_soc_prepare() warn: 'drvdata->ocotp_base' from of_iomap() not released on lines: 139. vim +143 drivers/soc/imx/soc-imx8m.c 390c01073f5d0b Peng Fan 2025-04-23 119 static int imx8m_soc_prepare(struct platform_device *pdev, const char *ocotp_compatible) 390c01073f5d0b Peng Fan 2025-04-23 120 { 390c01073f5d0b Peng Fan 2025-04-23 121 struct device_node *np __free(device_node) = 390c01073f5d0b Peng Fan 2025-04-23 122 of_find_compatible_node(NULL, NULL, ocotp_compatible); 390c01073f5d0b Peng Fan 2025-04-23 123 struct imx8_soc_drvdata *drvdata = platform_get_drvdata(pdev); 390c01073f5d0b Peng Fan 2025-04-23 124 int ret = 0; 390c01073f5d0b Peng Fan 2025-04-23 125 390c01073f5d0b Peng Fan 2025-04-23 126 if (!np) 390c01073f5d0b Peng Fan 2025-04-23 127 return -EINVAL; 390c01073f5d0b Peng Fan 2025-04-23 128 390c01073f5d0b Peng Fan 2025-04-23 129 drvdata->ocotp_base = of_iomap(np, 0); 390c01073f5d0b Peng Fan 2025-04-23 130 if (!drvdata->ocotp_base) 390c01073f5d0b Peng Fan 2025-04-23 131 return -EINVAL; 390c01073f5d0b Peng Fan 2025-04-23 132 390c01073f5d0b Peng Fan 2025-04-23 133 drvdata->clk = of_clk_get_by_name(np, NULL); 390c01073f5d0b Peng Fan 2025-04-23 134 if (IS_ERR(drvdata->clk)) { 390c01073f5d0b Peng Fan 2025-04-23 135 ret = PTR_ERR(drvdata->clk); 390c01073f5d0b Peng Fan 2025-04-23 136 goto err_clk; 390c01073f5d0b Peng Fan 2025-04-23 137 } 390c01073f5d0b Peng Fan 2025-04-23 138 390c01073f5d0b Peng Fan 2025-04-23 139 return clk_prepare_enable(drvdata->clk); Call iounmap() if clk_prepare_enable() fails? 390c01073f5d0b Peng Fan 2025-04-23 140 390c01073f5d0b Peng Fan 2025-04-23 141 err_clk: 390c01073f5d0b Peng Fan 2025-04-23 142 iounmap(drvdata->ocotp_base); 390c01073f5d0b Peng Fan 2025-04-23 @143 return ret; 390c01073f5d0b Peng Fan 2025-04-23 144 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki