mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Khushal Chitturi <khushalchitturi@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
	Hans de Goede <hansg@kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Khushal Chitturi <khushalchitturi@gmail.com>
Subject: [PATCH 2/9] staging: rtl8723bs: remove empty branches
Date: Mon, 12 Jan 2026 00:06:23 +0530	[thread overview]
Message-ID: <20260111183630.12816-3-khushalchitturi@gmail.com> (raw)
In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com>

Remove empty else blocks in rtw_xmit.c to improve
readability and follow the kernel coding style.

Signed-off-by: Khushal Chitturi <khushalchitturi@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index b0d7e59e492d..cf7d92a85d6c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -1707,8 +1707,6 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram
 		queue = &pxmitpriv->free_xmit_queue;
 	else if (pxmitframe->ext_tag == 1)
 		queue = &pxmitpriv->free_xframe_ext_queue;
-	else {
-	}
 
 	spin_lock_bh(&queue->lock);
 
@@ -1999,11 +1997,11 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *xmitframe)
 		)
 			allow = true;
 
-	} else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL)
+	} else if (registry->hiq_filter == RTW_HIQ_FILTER_ALLOW_ALL) {
 		allow = true;
-	else if (registry->hiq_filter == RTW_HIQ_FILTER_DENY_ALL) {
-	} else
+	} else {
 		rtw_warn_on(1);
+	}
 
 	return allow;
 }
-- 
2.52.0


  parent reply	other threads:[~2026-01-11 18:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 18:36 [PATCH 0/9] staging: rtl8723bs: coding style and refactoring cleanups Khushal Chitturi
2026-01-11 18:36 ` [PATCH 1/9] staging: rtl8723bs: fix operator and type cast spacing Khushal Chitturi
2026-01-11 18:36 ` Khushal Chitturi [this message]
2026-01-12  8:02   ` [PATCH 2/9] staging: rtl8723bs: remove empty branches Dan Carpenter
2026-01-11 18:36 ` [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions Khushal Chitturi
2026-01-12  8:18   ` Dan Carpenter
2026-01-11 18:36 ` [PATCH 4/9] staging: rtl8723bs: replace msleep with usleep_range in rtw_xmit.c Khushal Chitturi
2026-01-11 18:36 ` [PATCH 5/9] staging: rtl8723bs: split chained assignments Khushal Chitturi
2026-01-12  8:01   ` Dan Carpenter
2026-01-11 18:36 ` [PATCH 6/9] staging: rtl8723bs: rename struct members to snake_case Khushal Chitturi
2026-01-11 18:36 ` [PATCH 7/9] staging: rtl8723bs: rename local variables " Khushal Chitturi
2026-01-11 18:36 ` [PATCH 8/9] staging: rtl8723bs: replace N_BYTE_ALIGMENT with PTR_ALIGN Khushal Chitturi
2026-01-11 18:36 ` [PATCH 9/9] staging: rtl8723bs: fix line length and alignment issues Khushal Chitturi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260111183630.12816-3-khushalchitturi@gmail.com \
    --to=khushalchitturi@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®