From: Brian Masney <bmasney@redhat.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Brian Masney <bmasney@redhat.com>
Subject: [PATCH v2 04/16] MIPS: copy pic32.h header file from asm/mach-pic32/ to include/platform-data/
Date: Mon, 12 Jan 2026 17:47:58 -0500 [thread overview]
Message-ID: <20260112-mips-pic32-header-move-v2-4-927d516b1ff9@redhat.com> (raw)
In-Reply-To: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com>
There are currently some pic32 MIPS drivers that are in tree, and are
only configured to be compiled on the pic32 platform. There's a risk of
breaking some of these drivers when migrating drivers away from legacy
APIs. It happened to me with a pic32 clk driver.
Let's go ahead and copy the MIPS pic32.h header to
include/linux/platform_data/, and make a minor update to allow compiling
this on other architectures. This will make it easier, and cleaner to
enable COMPILE_TEST for some of these pic32 drivers.
The asm variant of the header file will be dropped once all drivers have
been updated.
Link: https://lore.kernel.org/linux-clk/CABx5tq+eOocJ41X-GSgkGy6S+s+Am1yCS099wqP695NtwALTmg@mail.gmail.com/T/
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Cc: linux-kernel@vger.kernel.org
---
include/linux/platform_data/pic32.h | 39 +++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/include/linux/platform_data/pic32.h b/include/linux/platform_data/pic32.h
new file mode 100644
index 0000000000000000000000000000000000000000..f0b395fdb784fa8b7e19029b9ff97f761dbf1088
--- /dev/null
+++ b/include/linux/platform_data/pic32.h
@@ -0,0 +1,39 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Joshua Henderson <joshua.henderson@microchip.com>
+ * Copyright (C) 2015 Microchip Technology Inc. All rights reserved.
+ */
+#ifndef __LINUX_PLATFORM_DATA_PIC32_H
+#define __LINUX_PLATFORM_DATA_PIC32_H
+
+#include <linux/types.h>
+
+/*
+ * PIC32 register offsets for SET/CLR/INV where supported.
+ */
+#define PIC32_CLR(_reg) ((_reg) + 0x04)
+#define PIC32_SET(_reg) ((_reg) + 0x08)
+#define PIC32_INV(_reg) ((_reg) + 0x0C)
+
+/*
+ * PIC32 Base Register Offsets
+ */
+#define PIC32_BASE_CONFIG 0x1f800000
+#define PIC32_BASE_OSC 0x1f801200
+#define PIC32_BASE_RESET 0x1f801240
+#define PIC32_BASE_PPS 0x1f801400
+#define PIC32_BASE_UART 0x1f822000
+#define PIC32_BASE_PORT 0x1f860000
+#define PIC32_BASE_DEVCFG2 0x1fc4ff44
+
+#if defined(CONFIG_MACH_PIC32)
+/* Register unlock sequence required for some register access. */
+void pic32_syskey_unlock_debug(const char *fn, const ulong ln);
+#define pic32_syskey_unlock() \
+ pic32_syskey_unlock_debug(__func__, __LINE__)
+#else
+/* COMPILE_TEST on all other architectures */
+#define pic32_syskey_unlock()
+#endif
+
+#endif /* __LINUX_PLATFORM_DATA_PIC32_H */
--
2.52.0
next prev parent reply other threads:[~2026-01-12 22:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 22:47 [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Brian Masney
2026-01-12 22:47 ` [PATCH v2 01/16] MIPS: pic32: include linux/io.h header on several files Brian Masney
2026-01-12 22:47 ` [PATCH v2 02/16] MIPS: pic32: include linux/types.h on pic32.h Brian Masney
2026-01-12 22:47 ` [PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h Brian Masney
2026-01-16 7:12 ` claudiu beznea
2026-01-16 15:14 ` Brian Masney
2026-01-12 22:47 ` Brian Masney [this message]
2026-01-12 22:47 ` [PATCH v2 05/16] MAINTAINERS: add include/linux/platform_data/pic32.h to MIPS entry Brian Masney
2026-01-12 22:48 ` [PATCH v2 06/16] MIPS: update include to use pic32.h from platform_data Brian Masney
2026-01-12 22:48 ` [PATCH v2 07/16] clk: microchip: core: " Brian Masney
2026-01-16 7:15 ` claudiu beznea
2026-01-12 22:48 ` [PATCH v2 08/16] irqchip/irq-pic32-evic: " Brian Masney
2026-01-13 8:53 ` Thomas Gleixner
2026-01-12 22:48 ` [PATCH v2 09/16] mmc: sdhci-pic32: " Brian Masney
2026-01-21 6:51 ` Adrian Hunter
2026-01-22 17:26 ` Ulf Hansson
2026-01-12 22:48 ` [PATCH v2 10/16] pinctrl: pic32: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 11/16] rtc: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 12/16] serial: pic32_uart: " Brian Masney
2026-01-13 6:38 ` Jiri Slaby
2026-01-13 11:30 ` Brian Masney
2026-01-12 22:48 ` [PATCH v2 13/16] watchdog: pic32-dmt: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 14/16] watchdog: pic32-wdt: " Brian Masney
2026-01-12 22:48 ` [PATCH v2 15/16] MIPS: drop unused pic32.h header Brian Masney
2026-01-12 22:48 ` [PATCH v2 16/16] clk: microchip: core: allow driver to be compiled with COMPILE_TEST Brian Masney
2026-01-13 5:48 ` Stephen Boyd
2026-01-13 11:35 ` Brian Masney
2026-01-23 0:49 ` [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Brian Masney
2026-01-30 14:37 ` Thomas Bogendoerfer
2026-02-10 12:42 ` Brian Masney
2026-02-10 15:50 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112-mips-pic32-header-move-v2-4-927d516b1ff9@redhat.com \
--to=bmasney@redhat.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®