From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787FD30E83C for ; Mon, 12 Jan 2026 08:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204825; cv=none; b=F9r2fSjxL5/O28ZaBMjx7EnE2lAfcCZG7ohKfIXpv9OYj2ovEZXs8qG233/zGRf4qNAzRZfgdMSOEtpKEAj+Qtnhx4F1MqOWvxmRA+rVRrh2pihPObbQo7HNrvAfcSv+pu4FJG1mQjJrGNYyyEF423qeqT4U2Qnyq1BikTk4S3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768204825; c=relaxed/simple; bh=5dhidBQ2qVRjY7HWzYNvYRd1oZBKRDvfQdTEJffco/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KiLFVmFm/W4CSDlKjGZfcCVh10eXMJPLbiMYSHIXaYNP+7fhdl9hxLaieN4RsgicZhpoS56awSj3kbYI17EoeiG57s48zybPSgmM3KwYcqjgdWUlzpChanh0HEmtm00K7HUt/5vfaW6u0dykC06qIz6+golAifmdhSLHNrL4yhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PFOnRrVR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LSTUjp6Y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PFOnRrVR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LSTUjp6Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768204823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LVlVMdkkC1Jjx95S4ueZ2nCAXykmbyB/9y4QNLXeHAY=; b=PFOnRrVROiNKcCEnA9KTvQahyPq01D32p/lXGrx+PpA82FQy3dJZfH+Y03ZUyufJPChXr7 ti01ntgoPI5hLjRHv7Yiq7HidZtV4i/mk1E2I0eJ/zJGFwl6xXwGasd4p3edZOmzFBe9Zi VOxs00SelUKNrxzw/UlY231a8xNqQ0c= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-xseYf1VtPWepOAb1mom7ZQ-1; Mon, 12 Jan 2026 03:00:22 -0500 X-MC-Unique: xseYf1VtPWepOAb1mom7ZQ-1 X-Mimecast-MFC-AGG-ID: xseYf1VtPWepOAb1mom7ZQ_1768204821 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477a11d9e67so40395685e9.2 for ; Mon, 12 Jan 2026 00:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768204820; x=1768809620; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=LVlVMdkkC1Jjx95S4ueZ2nCAXykmbyB/9y4QNLXeHAY=; b=LSTUjp6YcFDwIEHUoHy5cRG7vgJtKAMZo8vZe7Kxobq6t14EvrPmZzAuvCIIKgSdHv mzHqb9Ws/JwwggXpJoxwYIAPE8Wjnem29A0eWmOug2OGr69Nh4bme8tOhxutFX8ARW0c Opgxq4ND4rm6ShsVpe8NVG+Crm7j3gyK2qXvMVY796n1Fo2iI0qfiR0UvkzN7eAQ+aic n9ukysnJT1dUc5cAvRoaHWWCHdVtX6Nl0H+UgkMRlicyZnbT0s0kw1FuemW0SwVqmvD2 Pyk0EQ/rl+D7Yuk+DDhY789fkPJXtYM/OGoGOh429PU+Fcf/DvvF5atACik504KLmR0d +wwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768204820; x=1768809620; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LVlVMdkkC1Jjx95S4ueZ2nCAXykmbyB/9y4QNLXeHAY=; b=N9jDvmBP2iK6Cg/gKQsPiH6K9TQPio0qfiHRHAvx02YxJORiQoiqWeZA9vHYcF3ZL2 Z5yjqh1t5X9ub03VH4rKvJWm0cpKZhrrJranLKRASTUjnPrRD7mi1Ca6xSZFCXpQqa39 Z6hIQSNobpRHjl3qvZFWX8trxeYXan6QDoPgWlnzEeukK6l7kklXPbzMxcNVgCgoZHbn I8/AVo3FewiuUCDvSe/5eHBAn1+tWb56yo/KqzHyhhdbPIq5uG5C38guNV8axRpbJJ5L TPxNTAYA1jDiX9pIhJNqIOhHW0jsjg5puWHfzdPYEWqPWCgloJVYSIAvocXmpdd+Tel5 lyYg== X-Gm-Message-State: AOJu0Yxt4tXwFM1JWt5fLVsTGWme/KBWRbSXaV4LShSv1uoVViEOwrR1 fbbHFYEQn/u5gG92+GOIadyvKBxnR1tNo/6TiBLO7VDkAUweMZrFd8rMPXtgjww0Hx6gGIqv6V8 Dm1z3CheCPprikM92MRc+cYEPHJyhxOSMVMVM3+ukISKbX9vjnufjVCwk3QpNfCFfAwkcoOOrlw == X-Gm-Gg: AY/fxX5NLe0Hip5KpptzoX09GTko35l+4JR5PmIJkmffqO3BeZUlyGrdc9/lHVSbRRx 53+Y1JbV6mKlZh0yQ4146Ok4lSnmWLzPAhuq87q6xVnm669orQDaVWit/XuH1lPQM/CHZdZ/9MR Y9p78Qg+jrqB35JzDiF3tuU2kQlqv7utv0rm80fP5YjLTGsHOIYqaF8SyAT79V2hkdLyBUk/zv8 NPxNWCkdqP4dcF+XEeVMBPQ2vzGwLl2DiC6spMt7E/0dMyQ16MMR1QbXe3SdkAHUJjjSdyP4BpU JpiPfLQ3+MS+vM9NChN8nd3QkpZ89+zoTHKz6sSLOe0tHmINs6F+pOsKKyFOIqDgaUpgUaJnw2U BDgMSwWYtbXid+VWuJ2CELBc6jfcc68g= X-Received: by 2002:a05:600c:8484:b0:47a:8cce:2940 with SMTP id 5b1f17b1804b1-47d84b1a095mr175391775e9.14.1768204818984; Mon, 12 Jan 2026 00:00:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IGq3Sj3sI5Uz7LmIr5BjRNBlTXc1OS6InhejNK0sTEWVefFhTaJ5FHexT2Lqrk80oxjuSK5zQ== X-Received: by 2002:a05:600c:8484:b0:47a:8cce:2940 with SMTP id 5b1f17b1804b1-47d84b1a095mr175391295e9.14.1768204818436; Mon, 12 Jan 2026 00:00:18 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f4184cbsm357729585e9.6.2026.01.12.00.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 00:00:17 -0800 (PST) Date: Mon, 12 Jan 2026 03:00:15 -0500 From: "Michael S. Tsirkin" To: Eugenio Perez Martin Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 02/12] vduse: add vq group support Message-ID: <20260112025737-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-3-eperezma@redhat.com> <20260110183910-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 12, 2026 at 08:35:37AM +0100, Eugenio Perez Martin wrote: > On Sun, Jan 11, 2026 at 12:44 AM Michael S. Tsirkin wrote: > > > > On Fri, Jan 09, 2026 at 04:24:20PM +0100, Eugenio Pérez wrote: > > > @@ -1252,12 +1266,24 @@ static long vduse_dev_ioctl(struct file *file, unsigned int cmd, > > > if (config.index >= dev->vq_num) > > > break; > > > > > > - if (!is_mem_zero((const char *)config.reserved, > > > - sizeof(config.reserved))) > > > + if (dev->api_version < VDUSE_API_VERSION_1 && config.group) > > > + break; > > (Bookmarking the piece of code above as [1] to reference later) > > > > + > > > + if (dev->api_version >= VDUSE_API_VERSION_1) { > > > + if (config.group >= dev->ngroups) > > > + break; > > > + if (dev->status & VIRTIO_CONFIG_S_DRIVER_OK) > > > + break; > > > + } > > > + > > > + if (config.reserved1 || > > > + !is_mem_zero((const char *)config.reserved2, > > > + sizeof(config.reserved2))) > > > > Hmm but if api version is 0 then group should be 0 no? > > We should validate. > > > > The check (dev->api_version < VDUSE_API_VERSION_1 && config.group) is > above this check in this set of changes [1], am I missing something? > Would you prefer it to be reordered here or written differently? Oh you are right. It's just not very clear that everything is covered. if (dev->api_version < VDUSE_API_VERSION_1) { if (config.group) .... } else { .... } would be clearer. BTW I don't really like this idiom of "break to return". Just return -EINVAL would be more explicit. But this is the way current code handles it, so I'm not demanding it is changed as part of this patchset. -- MST