From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAFBC1DF248 for ; Mon, 12 Jan 2026 12:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768219384; cv=none; b=hgyvI7IuA7FlJTbeB0yD4bzYG7VS6q3+EmU05iKNIQMB6XDcOoLF0/qAIWu7i1+3pnZg4anWQsTr5LTch7ZP8oB7XPLmbQO+gucQtX8QaCAoRjAVwwC+1iZq+fzP8D4txkhIKoEJQVC33uxl/Avtipm+3woh8kh1fA1vVqcs+rI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768219384; c=relaxed/simple; bh=hfFeAiIDDvcWTY7CcVSvPu7m04vemVeg0WMspIP5i4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jMBLB4FMMr8uDcRf6OjR4BW28huL/mgdorTv4QPX06ktsGcIezCfmTh/bCzcLumOBHpT6g6PWoVhW4dvxsb7dinP4CA1x/D9SCr5G+Tj/rBzhaDxlrKNg8w0IiEcQgQyt3MPNyCbnSoDhm0+Zb9uvbYMCcaW357urIXPFdTCJ54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fys6aXU0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=geqe4uu9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fys6aXU0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="geqe4uu9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768219381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OOV5rZtkgq/TYG6iIabLFlqJMdYBjVkhddu7QsUorlw=; b=fys6aXU0xhJU7xAerKbYkPjgejPcDpU/hiqdTgIqQDaMSg3tEE1aO+5tObqoT2GC50gz6G qHjqKpkvnf4J0OUC3qEYnfxeHNAEQCWnAIvkOATP34ekgIglh3ZJQaC1p3f01kH6/1mbnd SYR+jqQDIZeK6b/5lDqaoVRX6x0WFCY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-OIvFaspyO6KUze-IV2cX7g-1; Mon, 12 Jan 2026 07:00:46 -0500 X-MC-Unique: OIvFaspyO6KUze-IV2cX7g-1 X-Mimecast-MFC-AGG-ID: OIvFaspyO6KUze-IV2cX7g_1768219246 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779b3749a8so52075445e9.1 for ; Mon, 12 Jan 2026 04:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768219246; x=1768824046; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OOV5rZtkgq/TYG6iIabLFlqJMdYBjVkhddu7QsUorlw=; b=geqe4uu9cK7PnpCCXUL0bsc05vv23LfZmo6/AGM45e7CM3eBdplkyQkehtOy5CDLZz CEZtOvm6lLWrqiJw+7xki/EQttsqFO9XzrF2+VGKRu8eYDKD/aVUK8HGKiX2izEs62e/ aDT0Rl9CEyjoKR2ohBIzFJ0gDn5tbFzJwoHR/+F1jAmZFY1xZwmPX7w+0ZKi/at5ngeI g0oEbB9aDYZz1RKIXU12IEwX4Z8PO1v+azIrG4fBr5AN5GdLj2R/MmuOZyWl75OH2fnZ lLdXiV7y0IwKf22yp/SwbOO7p1YxJok6dgvLi9eYZd6JuSGbZVXv8k80U3auOGsyivdA lVCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768219246; x=1768824046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OOV5rZtkgq/TYG6iIabLFlqJMdYBjVkhddu7QsUorlw=; b=bFC8LwnNkXTsXxKVCMu5p5QVZARUidtXkYCjswAReN8FYyNBG+XP/qJQgKV/BZCe6P fAmdqvyIJkPgn7nmwTOY9BKpu5x0bXNX/B4/8SHMpAyVSuUY9FTlfajql5aSX/3Uz1CO N3EIDtz2Qu+uuvrhdfvZAFB9mpFbQvgFkOgwek+szXkPZ+hzH/pHmWXC4vg/A2284WEm QTiprX3CwNh3Y/b0fBJxE40v27j+k3TGFBUY378BDnAkLmihNuwbA38BOfWalTtIdmQL iJlmqa1mIV2X8nuYB2AbHEVeZHgTexujL/37hF3gSnATdmUXVFz4NzhKLORnRZMGFT2y XN/Q== X-Gm-Message-State: AOJu0Ywwf7bePMCofeyFb50B3P/F2So6CWOas6l9QWvhJlPb5u+5s01r GDMP8jGctCK3cQgsC1sL+kgS0rKqsihmKe2oI8WYf6mcprVelaBx2RhArkzJqHRa9EHVnJ1OhaW 7fY4+0Z01NBh2rE9HKF+CihbpgtrCfexpBMiZ0U8UYxHzubdf6x8cin15/zTEYq+BFg== X-Gm-Gg: AY/fxX6R62ySoLtiFo8O2ZEuSbkhgHO62fcQoIBpQFLlPO7RdIZ1rUGpYu4eSJmh7EX CRM43zQqSYu6BKcWsP9fG1wZN/sCjrXD7JYM7c5U+u+Aqd84o2w/t/tsUH7oc4PsShxbulZt0Sj rmZ/2ye0/ApmWa2nWZen8/1TiItmqnkUuzezTpTRgIH8TimO+gXrq36iF59PX5Ff3ptiFnfYjdA M1Zt+mT/+ywHWFb8JEefMBeCHy2VvyGNxwiVlWYaLnXb8C3DbUPCFnpgHgI/BB+NSMMoU8K+ogT Eg+fsrp7rkiLjOJ+WPTdrKXuD79NLAPMvCEIq6XAjdIlE31C64ABlwIb0bTXbi8n2W+GxqSKV8z S58xK5ftVP/Ht4MTRn9UJytzZoh81gic= X-Received: by 2002:a05:600c:a314:b0:479:3876:22a8 with SMTP id 5b1f17b1804b1-47d84b2d285mr182865195e9.16.1768219245586; Mon, 12 Jan 2026 04:00:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwS0FwA3G4d77kbD1y9f5zWxZfwkk17a86x64r/GhYecFR2Oj58FTKjjZU+xN7PYXrh1xDnQ== X-Received: by 2002:a05:600c:a314:b0:479:3876:22a8 with SMTP id 5b1f17b1804b1-47d84b2d285mr182864805e9.16.1768219245113; Mon, 12 Jan 2026 04:00:45 -0800 (PST) Received: from redhat.com (IGLD-80-230-35-22.inter.net.il. [80.230.35.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f668e03sm363963425e9.14.2026.01.12.04.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 04:00:44 -0800 (PST) Date: Mon, 12 Jan 2026 07:00:41 -0500 From: "Michael S. Tsirkin" To: Eugenio Perez Martin Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, Maxime Coquelin , Laurent Vivier , Cindy Lu , jasowang@redhat.com, Xuan Zhuo , Stefano Garzarella , Yongji Xie Subject: Re: [PATCH v11 11/12] vduse: add vq group asid support Message-ID: <20260112065928-mutt-send-email-mst@kernel.org> References: <20260109152430.512923-1-eperezma@redhat.com> <20260109152430.512923-12-eperezma@redhat.com> <20260110185711-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jan 12, 2026 at 12:56:34PM +0100, Eugenio Perez Martin wrote: > > > @@ -439,11 +453,14 @@ static __poll_t vduse_dev_poll(struct file *file, poll_table *wait) > > > static void vduse_dev_reset(struct vduse_dev *dev) > > > { > > > int i; > > > - struct vduse_iova_domain *domain = dev->domain; > > > > > > /* The coherent mappings are handled in vduse_dev_free_coherent() */ > > > - if (domain && domain->bounce_map) > > > - vduse_domain_reset_bounce_map(domain); > > > + for (i = 0; i < dev->nas; i++) { > > > + struct vduse_iova_domain *domain = dev->as[i].domain; > > > > I do not understand the locking here an in many other places. > > dev->as is dereferenced here apparently outside as_lock? > > > > The virtqueue groups' "as_lock" member protects the virtqueue groups' > "as" pointer. But we're not accessing any vq groups "as" member here, > we're accessing the dev->as[i].domain pointer here, which doesn't > change in all the lifetime of the device. Ah. got it. maybe a comment near the field definition will help.