Re: [PATCH v2] fs: improve dump_inode() to safely access inode fields.

[Yuto Ohnuki <ytohnuki@amazon.com>]

> It would be good to avoid duplication of the pr_warn stuff as the format
> string is expected to change over time. I guess you could retain
> "<invalid>" for the case where sb was unreadable? Or even denote it,
> perhaps with "<unknown, sb unreadable>" or similar.
> 
> 
> I don't really care as long as tere is one pr_warn dumping the state.
> 
> This bit:
> +	pr_warn("invalid inode:%px\n", inode);
> 
> could still print the passed reason. "invalid inode:" is a little
> misleaing, perhaps "unreadable inode" would be better?
> 
> As a side note I was told kernel printk supports %# for printing hash
> values, perhaps a good opportunity to squeeze this in intead of 0x. One
> will have to test it indeed gives the expected result.

Thank you for the review and suggestions.

Yes, I intended to denote the situation where sb is unreadable, so I've
adopted "<unknown, sb unreadable>" in v3.
I'll address all the other points as well and send out v3.

Best regards,
Yuto



Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705