From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE2212BE63F for ; Mon, 12 Jan 2026 14:50:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229429; cv=none; b=iOJbLMZLWLvz1fHkrbN0P24nIYt2mNS+fwZZ0RsR/NtQ33K7kQUSXpHGKSy9Ku/Hp9FHxlMUStE12BxvtemJbt1XeVsH4GY/EGKnU0wPVpmQZUH9vr9ESPAuEarHTvn8p0NznvuUHw6HKYIcvnoI6402VdVSf9lkkaeB9VZiqrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229429; c=relaxed/simple; bh=BCOua+Gf/qjKIUSKvJ3OEBekSx27C+LQ+kMN+B3TsEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WIxeX2ZHkhuGLoVXFXgyaFtzeLukC8FIOYDWQa2Uh1C2NJq77fsUQtfjEyufM+yQnbTiGg48gTt7NhQHfx9Qt/Qfw4ncfWy0zmkmk6g9wZO+kc/X71lQyZIrDUqUSXs6MmE6xDvmCwc6S9fle4dLiIyUrZGZQD1/XVHiZTY3GqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JV0YV+s3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JV0YV+s3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768229426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VtyFkhAh64y9WwItHEEgIZEX9ns5t8XYws0QfbfxKo0=; b=JV0YV+s3dAd7JZ0tx67W3evYCI1V7wRrjaKwkzpsJS9/G782/0Vu/KMvL0d1WhJ5s/ogfS RN8qH6i7ZFgZeB5wskR3Tis5idT1oRIPpLEgDAO/K94DvyUlHJ+trHZamZyoM99IEh4NO/ 90e9sx2Od/dJ0pKuoMlwn9mrX6tJ17w= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-R3G2buzJMB-aAEoTeLKR2A-1; Mon, 12 Jan 2026 09:50:24 -0500 X-MC-Unique: R3G2buzJMB-aAEoTeLKR2A-1 X-Mimecast-MFC-AGG-ID: R3G2buzJMB-aAEoTeLKR2A_1768229423 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91F3D1956070; Mon, 12 Jan 2026 14:50:23 +0000 (UTC) Received: from pauld.westford.csb (unknown [10.44.33.135]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5755918007D2; Mon, 12 Jan 2026 14:50:21 +0000 (UTC) Date: Mon, 12 Jan 2026 09:50:16 -0500 From: Phil Auld To: Gabriele Monaco Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] sched: Fix build for modules using set_tsk_need_resched() Message-ID: <20260112145016.GA865736@pauld.westford.csb> References: <20260112140413.362202-1-gmonaco@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260112140413.362202-1-gmonaco@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Mon, Jan 12, 2026 at 03:04:13PM +0100 Gabriele Monaco wrote: > Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > added a tracepoint to the need_resched action that can be triggered also > by set_tsk_need_resched. > This function was previously accessible from out-of-tree modules but > it's no longer available because the __trace_set_need_resched() symbol > is not exported (together with the tracepoint itself, which was exported > in a separate patch) and building such modules fails. > > Export __trace_set_need_resched to modules to fix those build issues. > > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > Cc: Phil Auld > Signed-off-by: Gabriele Monaco > --- > kernel/sched/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 60afadb6eede..a490d34cc65a 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1136,6 +1136,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) > { > trace_sched_set_need_resched_tp(curr, smp_processor_id(), tif); > } > +EXPORT_SYMBOL_GPL(__trace_set_need_resched); > > void resched_curr(struct rq *rq) > { > > base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 > -- > 2.52.0 > Thanks Gabriele! And good catch that the other patch is not sufficient. Reviewed-by: Phil Auld --