From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 941E91DEFF5 for ; Mon, 12 Jan 2026 14:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229605; cv=none; b=M0JzY4JPAPw0pMhgsUXj/3hjq/28dLDqtaxw4LSgOZXu566QXX7CZUTYyIH3sLHbSenz8xHBSzBdqN/YZn+R5lVEnXZXF39bQQM3qEbnyySFGYb96+EmvNjbYwOUIM2h9Aj/SY7Rvkdum6C9b7OfPwc0duumHQxwtB9BNbuH2oY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229605; c=relaxed/simple; bh=Ona84IHtxNXIQlAax/SD1j0qa8fHdgctzVaVzh0tjj8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QUqrDRVrKvAtpqIpTS7WNLJZ0eCcj4aLW5nOocNDS181AAxyGlZMRaQPKl9Owv2IG6awR2jXtYO2lZ0q25L8nmIVpjkiOI0XhmuEeX5EY74OqdpvyMtWoELwpht5UsAkSqgO9FMYeXLNF6dcF9IaZurn5SEpqGxD4JOAXnj8JZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F9/aK2ZB; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F9/aK2ZB" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-6455a60c12bso6122170d50.3 for ; Mon, 12 Jan 2026 06:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768229602; x=1768834402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GBTkFNmBBkEQ6ceIfuMijXTnivvV3fEgY8bCnCyu/gw=; b=F9/aK2ZB9bTUjONSPz/TNe9T52EhC+Ivu8ZCPsnENUHh9gtMHf4JWiVDUJGagGlyzu e7Z+6X3n7FE2+0duBnN3BJScaa/NmgNsXvaYBlVUOB7UFiZy9b1kyVs7m8JiEDlI4xXU WeXw1u7qWgtaTFsnNt9V6HBlNNB9dCPIDYYAA0IiUYDnpS5z81cfPzXtXGVYzxsWPGWE try/GDxaxV2YeEsbfVxhmQnLCu0RRZm5gYYjNJlkgYm07Q8TnCV4pFjPAUK2iF6cgg3d jdfyOX0sgmxQgXvQkY9JfWl8/2IIeAuSz1Zm8ffLV6DwnlQaN+0P1YMIla4owBGRKEfX U8jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768229602; x=1768834402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GBTkFNmBBkEQ6ceIfuMijXTnivvV3fEgY8bCnCyu/gw=; b=ufVr36ZPuYtQTBNSSEHuwu0EkPrWSbFdnobjaB3bx3j0jbo34ZUeHoHoMGBDzIYH9k 2Q0A9S0K+2Vo7CRWjwkwuue0eIbT82WPP6l39kKJtWZHeAInHKn60WZ8OnHqwFidw79F d/YGysIxauQJ6eUONgGBPJ6T1tX9frfId672dZ1+HthvXZUIXf3PCRC2yhitVl3i30w+ 6pp9XsJ6ygo2qZleOAS7S5Yp1va4rvJg5+BPEyA8egidg485RFCQ+z7Oo51s5KKuQ7oq ePjmkkOoDMIlFagU/oxlgdgodBXC1RlOywXqmeJ31LwLYHvpheHzevPoR+plAscm0Kj+ zncw== X-Forwarded-Encrypted: i=1; AJvYcCVaayLqW3oY17DjpcY7YqIMLSKnSs61lmoAbVO/0DUNsVTos5O2eMUJpdsXqlBmTEJSg3kScsXOVl4EzjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YygZkxf0MCVGTLii5P+AdczFvRB0oUK8fqDIwNBs3nihCX6MSqt dbgCO5a3JdRHZ7MPtgwMXYvgEnE5TotjV2e45UN9dJkv7olJq2GO6d2B X-Gm-Gg: AY/fxX5MlE5fChPDQDl/fIScQvhAqYuMwbBphpt4g+gXP0ZU1EH+rqACRlSHlbS9eC9 38k4PwbtZO+NKsw385s1aC61HGFMDwOM61cQ4yk2VNnStlWaFizo6p7Cew2+JuMDYdI2A0QKSPU GeTlBqdKPP1WtnFB6EJKLHpELj2fcJr7VCkKbhisnzzn+I2tydt74HbayPnBr77QIyMGapfEuMe 6KZt1byUc1tGsEB1rKV1yKNiPQcdcZoNmsG9T0cJ5lSKiKvaDPUmdx+5zttbFxlf5aqMzmWQKWe Llrcd9DRCw6i/pVnzi9CcIfbCluXivHrgiYJ0bfDPnvhcc5mwsz+91YsuW4u4VeiN7y0I6hUO3y MBHsuhuJp3R3j6m+FRb9zFCi5sghuXvK+CpNW/qPEtxYndw0B3zML1qm+lAXxIEWOqre1YkaRZw 2WFrE3Sidbjvkao+hBoN7s X-Google-Smtp-Source: AGHT+IEiVkX5JSBHCP0DgJ5mM3XaCn+4iei4lNICvN+Do6alENtz3Jm/zPI+xQjk/43RjBi+/xhScw== X-Received: by 2002:a05:690e:1516:b0:645:5467:29e7 with SMTP id 956f58d0204a3-64716b74e68mr15365862d50.24.1768229602464; Mon, 12 Jan 2026 06:53:22 -0800 (PST) Received: from localhost ([2a03:2880:25ff:4e::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6470d8b246fsm8044371d50.17.2026.01.12.06.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 06:53:22 -0800 (PST) From: Joshua Hahn To: Yajun Deng Cc: akpm@linux-foundation.org, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/page_alloc: Avoid duplicate NR_FREE_PAGES updates in move_to_free_list() Date: Mon, 12 Jan 2026 06:53:19 -0800 Message-ID: <20260112145320.3748979-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260112121614.1840607-1-yajun.deng@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 12 Jan 2026 20:16:14 +0800 Yajun Deng wrote: > In move_to_free_list(), when a page block changes its migration type, > we need to update free page counts for both the old and new types. > Originally, this was done by two calls to account_freepages(), which > updates NR_FREE_PAGES and also type-specific counters. However, this > causes NR_FREE_PAGES to be updated twice, while the net change is zero > in most cases. > > This patch adds a condition that updates the NR_FREE_PAGES only if one of > the two types is the isolate type. This avoids NR_FREE_PAGES being > updates twice. > > The optimization avoid duplicate NR_FREE_PAGES updates in > move_to_free_list(). > > Signed-off-by: Yajun Deng > Suggested-by: Joshua Hahn Hello Yajun, LGTM. Thank you for kindly accepting my suggestion! Reviewed-by: Joshua Hahn