From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED1136E47C for ; Mon, 12 Jan 2026 16:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768236710; cv=none; b=cATYq2XxwictAmFV/6bvmI3D3HZ9Z9IQIJF0R36vj6W3vDBKbB4gHSgL19099DPXOg3boDTkwsfyI6Il8S+7bTzLUHVk8VRCf2WUUD56nuNpo0jZocu43C4y8WCUxRm9XVxsbmjT6Xy3rlx4mnDuKGwaBXLDERk3Plku3pBZypE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768236710; c=relaxed/simple; bh=vcL0+tkbX9ziazK4k8h2ep5uJ4MGMym8KpSv7Yi9Qxk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wg6CaqUlJpk8WWE69DyFe5Pp5zEjBZcfDfQuvtplR+yBQtT8VfLN/7rNUX4MxtAiJAX2giMVMTsBq2gn4XBJckNxzymTXbEmfrRnPYO8FDF+snOq99eRexaRBmdSh/n2LrIEnMoUQpTQAP6XLVETJNEk2dvpqA378ZFYoMiko4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H/CdZu7Q; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H/CdZu7Q" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-34c93e0269cso3053891a91.1 for ; Mon, 12 Jan 2026 08:51:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768236706; x=1768841506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AvoZ+rUrOvuG604TGPECUR2LmQ/bZ1xOw03juzbXQQU=; b=H/CdZu7QRQNyBu2yfvRHBdJvYfE8xrnLPEqYCTVf6f3fgYVpycfSlUm88ggfoWy85t AHR7XFRI+9GrxhXFyVPJv9TTW9BVKM4h+OikPlaXANPKMd8ilsHB3JQNQt5URUu85iZg qHwJtAzTrZYyYbAspSd9Aoaw5wQel0COZFazsiBi5lCn7ZiVG/+nSG2jUnn/W4BupzdR Q/DFiKtADqiodqTzneA6NPWFYdG1R9NpSKipMvPXI6QPSmLhwrbNWOnuM+VVuVkvI3K1 iiraXY0v5kRIx2XmfLV4oB5+d1SGRAczeICS5uMlUuvqEfgnjQBu1WCyiVOX1rTc0ptW fWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768236706; x=1768841506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AvoZ+rUrOvuG604TGPECUR2LmQ/bZ1xOw03juzbXQQU=; b=PjR3uwGweFTPs+xvH50Cwb8UGiVGFoTetFLKkQtcKDD8IA5DRrtba3ywMtW/58l8ZX rCq8PyLSgGrYfd6W4aNwBf8PN7pAlKb34roFfwL1as7PG9m2Sfppt/mc+eH/WTL8taW8 oFPuz5q/9m0cMJlmNzVZiljQJwYMFPbmsMDbu/j76ehmqsAKUFGEAzNp3Em+tQMoInpO vVsd6JxEPTgWQA4KFcdbBNR+16qe64ynskr5+C2lhCmYMb7PUdP4dNUQgEThxGs+Y1mj Ktc6vHqIksGSHWtfZyNGGpXCnm7TC+wwU8wzJHE6oeGPYyrWQZehvSDAg+3ejev87/lU gptQ== X-Forwarded-Encrypted: i=1; AJvYcCWS4bSZzkkOk2LhucK0rTRARPvsKBeusPZ+f7mrL24qnjJ/5AcgzWJamh9eWldTR3MRyH8+xK0Qn1QWtFk=@vger.kernel.org X-Gm-Message-State: AOJu0YybCYG6Pcsd1lRk2dbcuU+ATZX5SGgRQI5h84lvfWt9O58QYJ8C YMJsOdmo64Hc9QvG/Bk/e7MmhtmCiWEHQfKazCO9knSMTxUb69CqzUl9 X-Gm-Gg: AY/fxX4vDI8yu9E+ayDRyqbdIg0qOmh/jyUHoGayFNK7IefzUmXYTqT5zuFqytPC+82 PoY6qGmrwpv7rVKkMXa0/KudtiK5zqVeLyNYkDlsURSTD3E6fUxFn+OuMhyJPq6GOSOzPBXDCWi navI7Wc5Pg56XBS3I+ZSZ0kKBLDfXWpDxjK9wJsNFbRDEcNRmMNQ7850yE5AEt6I5TMSdNhjb5c D+6ru/pTBNg14XzL4wDa/VcQvDsEmFmbtQ/np32F7dNFycBgCcZ0Zzm9qopHN7GzwfoPLwy1MCA LfxJ8b6PKVy2sYS57BJeTf2QQXGso95D4z2QxZ+V4TZ0yO7hzjvKLkZt+WiLJR0/cMBm/+Vvlx9 TahYuR+HHZaYWi065CcCUrc72TodpTrTsJ49/DoyFKKrQ6zmUtOBu5RAHjFOdKjJZqdY7tmi/+U vhYKV7UnzGPtXEVhOy X-Google-Smtp-Source: AGHT+IEpAyWZFzXSpf6HyuZsb9rIgfw2lyXvfzwmTP+2+WJbNT/kH9DQAwkggu83xayYi/59UBFdkw== X-Received: by 2002:a17:90b:4984:b0:32e:2fa7:fe6b with SMTP id 98e67ed59e1d1-350fd16c922mr25584a91.14.1768236705446; Mon, 12 Jan 2026 08:51:45 -0800 (PST) Received: from rakuram-MSI ([2405:201:d027:f096:5c52:f599:118c:bed2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5fa93ee7sm17905078a91.7.2026.01.12.08.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 08:51:45 -0800 (PST) From: Rakuram Eswaran To: vasant.hegde@amd.com Cc: dan.carpenter@linaro.org, iommu@lists.linux.dev, joro@8bytes.org, linux-kernel@vger.kernel.org, lkp@intel.com, rakuram.e96@gmail.com, robin.murphy@arm.com, suravee.suthikulpanit@amd.com, will@kernel.org Subject: Re: [PATCH] iommu: amd: Fix uninitialized dev_data on probe failure Date: Mon, 12 Jan 2026 22:21:37 +0530 Message-ID: <20260112165139.7120-1-rakuram.e96@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: 561ab88a-ba97-41d8-ad6a-8656a2e2b1d5@amd.com References: <561ab88a-ba97-41d8-ad6a-8656a2e2b1d5@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Vasant, On Mon, 12 Jan 2026 at 10:42, Vasant Hegde wrote: > > On 1/10/2026 3:39 PM, Jörg Rödel wrote: > > On Sun, Dec 21, 2025 at 11:04:16PM +0530, Rakuram Eswaran wrote: > >> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c > >> index 5d45795c367a..075125f0f52b 100644 > >> --- a/drivers/iommu/amd/iommu.c > >> +++ b/drivers/iommu/amd/iommu.c > >> @@ -2426,7 +2426,7 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev) > >> dev_err(dev, "Failed to initialize - trying to proceed anyway\n"); > >> iommu_dev = ERR_PTR(ret); > >> iommu_ignore_device(iommu, dev); > >> - goto out_err; > >> + return iommu_dev; > >> } > > > > This is not the right fix. It makes the function omit further initialization > > steps which are needed event when iommu_init_device() fails (which it only does > > on out-of-memory). > > > > The right fix is to initialize dev_data to NULL and check for that value before > > dereferencing it further down to keep the current logic. > > Ack. I think this function needs rewrite. PCIe device capability > check/enablement is scattered between this one and iommu_init_device(). I will > fix it as part of other PASID related fixes/cleanups. > > I think for now below fix is good enough. > > @Rakuram, @Joerg, let me know if you want me to send proper patch? > Ok. Best Regards, Rakuram