mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fredrik Markstrom via B4 Relay <devnull+fredrik.markstrom.est.tech@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Frank Li <Frank.Li@nxp.com>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	 Fredrik Markstrom <fredrik.markstrom@est.tech>,
	 Ivar Holmqvist <ivar.holmqvist@est.tech>
Subject: [PATCH] i3c: master: Set the device name only after we initialize i3c_bus->id
Date: Tue, 13 Jan 2026 14:08:53 +0100	[thread overview]
Message-ID: <20260113-set_i3c_master_name-v1-1-eafc5dcd1eee@est.tech> (raw)

From: Fredrik Markstrom <fredrik.markstrom@est.tech>

The i3c_bus->id field is used to construct the unique name of the I3C
bus device. This field is initialized and assigned its unique value
within the i3c_bus_init() function.

However, the existing code was referencing i3c_bus->id *before* the
call to i3c_bus_init(), leading to all the masters having the same
device name string.

This commit moves the reference to i3c_bus->id to *after* the call to
i3c_bus_init().

Fixes: 9d4f219807d5 ("i3c: fix refcount inconsistency in i3c_master_register")
Signed-off-by: Fredrik Markstrom <fredrik.markstrom@est.tech>
Reviewed-by: Ivar Holmqvist <ivar.holmqvist@est.tech>
---
 drivers/i3c/master.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7f606c871648..1bc3c9068402 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2881,7 +2881,6 @@ int i3c_master_register(struct i3c_master_controller *master,
 	INIT_LIST_HEAD(&master->boardinfo.i3c);
 
 	device_initialize(&master->dev);
-	dev_set_name(&master->dev, "i3c-%d", i3cbus->id);
 
 	master->dev.dma_mask = parent->dma_mask;
 	master->dev.coherent_dma_mask = parent->coherent_dma_mask;
@@ -2891,6 +2890,8 @@ int i3c_master_register(struct i3c_master_controller *master,
 	if (ret)
 		goto err_put_dev;
 
+	dev_set_name(&master->dev, "i3c-%d", i3cbus->id);
+
 	ret = of_populate_i3c_bus(master);
 	if (ret)
 		goto err_put_dev;

---
base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
change-id: 20260113-set_i3c_master_name-4fe45d589164

Best regards,
-- 
Fredrik Markstrom <fredrik.markstrom@est.tech>



             reply	other threads:[~2026-01-13 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 13:08 Fredrik Markstrom via B4 Relay [this message]
2026-01-14 17:08 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113-set_i3c_master_name-v1-1-eafc5dcd1eee@est.tech \
    --to=devnull+fredrik.markstrom.est.tech@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=fredrik.markstrom@est.tech \
    --cc=ivar.holmqvist@est.tech \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®