From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 876BD18BC3B for ; Tue, 13 Jan 2026 05:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768281011; cv=none; b=qN16q5RmWrQhwj9yX2ImuqgdPIYxFsFtdGNmg7GD2DpxMUAEIuVixw8Ls/LyAWnohzRtf0TVOwjmZePFGIkyRZL4NruvEhrUvY63FcPsL5W8w5HbDpGMmXHskKx1QlEhjYSs9mxSHdtxOrtcIRlIEOPQR+rEGtXqnzqgeZY8S1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768281011; c=relaxed/simple; bh=Wjv6Zaz6XrT0tJfxu9I4tq4S2Pax+FQGOFWkpQzMz2k=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=HotlhmkOjp9+sccLMmQpOmNkKKGaXXwHW0OB7O3pV4+g4LWHAD+K75J5zpVS6fNQopltK4saXjmAeqrCd40N0DddahY683Sav12HfoKDgxlTW/Kc4kQeK8Ht6adjZ6TruBZOMBlLQjO2FHmBXdSr0Lad4wwnXeBdoju5bVzpHV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R/zHz8hI; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R/zHz8hI" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so59482135e9.2 for ; Mon, 12 Jan 2026 21:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768281007; x=1768885807; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ka9s37IOQpf1n4F84ka//EI6cLx2h6p9ldAIxcvSXSs=; b=R/zHz8hIJBK2oLtRjcLo3R/0PRT8rglvrvYk8wsrrxU+iRtm1V9mIyMRKme0UdNujb i1M2abHo+yh2ZjEWyfby696SWiMkVZqsZ4hYxKlSHlpo4gQf3PtSF2XTQT0hQPJLRBlU ZL1u3csbT6Kp1+0DrSnK+Uaq7N03bMQ7admkCpP+wHOMqiQEoA4rppeJ/BApczXaHP8r CqQEC+FfSBVB+5THEg9IZxr5PK0Z+RFTusSytK63ScC8jYH77JXRRLaCqqq+Cbh646Oh DHOEag+dwdATVKPRsCtm0fTmMB9kVL45mCDXqI0TEz5sdBWQU66MO5XCJFvgezCtpub6 0SSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768281007; x=1768885807; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ka9s37IOQpf1n4F84ka//EI6cLx2h6p9ldAIxcvSXSs=; b=UsGcSehYgGjtCTmA751fag0INgdsqHkFePJLC6d126oie548sXMgNlZOzsbjVsGs5f VSJLm49FGvCiCLmWggL9VCP7hEx7ojSD/x5FR2kujDX9nGoQeHiAcTOcLZ3d4gHvZrVW q+S+Xt9QuyVkCibJXjbK4n7UooPLt8yamBMaqubsMA6oXvXRtlIDPX/r8AJZI3EK4W3g fnmdI6UXEowGrUD5mUDz3k3eqkl6N5m01yq1q099+nL1ISY/UD/bMH5mkp6zD3pcB5xA vI9o24N79OLW3F2mrCiCew3HdY4C+b24cnUQOsW+M2MbogFo0mUpJjj4NGHZrMMPggmG iBLw== X-Forwarded-Encrypted: i=1; AJvYcCW83k47Yg5EVdzEPqryAQyGiEc41SE+bDyB169tVZBH5AvyKm/oQlXgSz0cz5PkWYb10ercZhcUBdDidxU=@vger.kernel.org X-Gm-Message-State: AOJu0YzChJgmamFl9sUCtuVBCVhRQOVFdepYG/2zqXBMzTBdxI+EeC8L S3KB50yHj2J9DhRS44X19bcQQBzGrwV6wyao4hCWnoSungUPECVxeq7dtIGutkgKWHI= X-Gm-Gg: AY/fxX7gWjLo/DAyONQo0Jktvie0PNkwW6uHFcI7K9vCQwzYUidyfpawkZa+fLRn3bq AOdTkM0ewAli8S1TelDnVce2doRu1JXzXCK8FJ69fknpqmYzmV9+mh6wm5WrUL+b+cbaM0nJKB0 IZfLOc0PNheE4slzY2EPSHo510CnFmMFjDG/5AssrPO6smeqQCdXSxH3Hu/Syv6gDQ7zHe0zAls s+rZLttWtJBKoUYoua7el3vvyf6vAd4Z9CvfYfKUZpFzU1NoS6oMIkrN6IlL4bn9HT293qMmpA9 Dpr44VgmpCzgTL8BZMhC9CzWz5mIiwue+/mnTXIcUSnm89KpJShVp75B3UNOd9J57/ZdaO7LQUp qA6zC+eehWN1gql7gkahNRkeDHzDY9VDj0d9OHlHeGI9qMa3ecqvsV33j9T5R5HCqrTdgNjWIx1 i/uzxLSvnfreDATWVx X-Google-Smtp-Source: AGHT+IEyaRLJd9Y4u+qQUZuuxa9DXiE3wFCOSM338VWiA5DPbkRF7hTq5Cq55p5My4D4lkbA6XYZVQ== X-Received: by 2002:a05:600c:a106:b0:47d:73a4:45a7 with SMTP id 5b1f17b1804b1-47d84b3badfmr218580905e9.24.1768281006753; Mon, 12 Jan 2026 21:10:06 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47eda5784e4sm6508885e9.18.2026.01.12.21.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 21:10:06 -0800 (PST) Date: Tue, 13 Jan 2026 08:10:03 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Maxime Chevallier Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/net/ethernet/freescale/ucc_geth.c:1608 ugeth_mac_config() error: we previously assumed 'tbiphy' could be null (see line 1605) Message-ID: <202601130843.rFGNXA5a-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b71e635feefc852405b14620a7fc58c4c80c0f73 commit: 53036aa8d03178a8d056a24a52a301ad290877d4 net: freescale: ucc_geth: phylink conversion config: powerpc-randconfig-r072-20260113 (https://download.01.org/0day-ci/archive/20260113/202601130843.rFGNXA5a-lkp@intel.com/config) compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710) smatch version: v0.5.0-8985-g2614ff1a If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202601130843.rFGNXA5a-lkp@intel.com/ smatch warnings: drivers/net/ethernet/freescale/ucc_geth.c:1608 ugeth_mac_config() error: we previously assumed 'tbiphy' could be null (see line 1605) vim +/tbiphy +1608 drivers/net/ethernet/freescale/ucc_geth.c 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1589 static void ugeth_mac_config(struct phylink_config *config, unsigned int mode, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1590 const struct phylink_link_state *state) ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1591 { 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1592 struct net_device *ndev = to_net_dev(config->dev); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1593 struct ucc_geth_private *ugeth = netdev_priv(ndev); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1594 struct ucc_geth_info *ug_info = ugeth->ug_info; 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1595 u16 value; ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1596 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1597 if (state->interface == PHY_INTERFACE_MODE_TBI || 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1598 state->interface == PHY_INTERFACE_MODE_RTBI) { 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1599 struct phy_device *tbiphy; ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1600 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1601 if (!ug_info->tbi_node) 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1602 pr_warn("TBI mode requires that the device tree specify a tbi-handle\n"); ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1603 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1604 tbiphy = of_phy_find_device(ug_info->tbi_node); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 @1605 if (!tbiphy) 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1606 pr_warn("Could not get TBI device\n"); We may as well return here instead of crashing on the next line. 047584ce941080 drivers/net/ucc_geth.c Haiying Wang 2009-06-02 1607 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 @1608 value = phy_read(tbiphy, ENET_TBI_MII_CR); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1609 value &= ~0x1000; /* Turn off autonegotiation */ 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1610 phy_write(tbiphy, ENET_TBI_MII_CR, value); ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1611 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1612 put_device(&tbiphy->mdio.dev); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1613 } 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1614 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1615 if (phylink_autoneg_inband(mode)) { 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1616 ug_info->aufc = 1; 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1617 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1618 init_flow_control_params(ug_info->aufc, 1, 1, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1619 ug_info->pausePeriod, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1620 ug_info->extensionField, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1621 &ugeth->uccf->uf_regs->upsmr, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1622 &ugeth->ug_regs->uempr, 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1623 &ugeth->ug_regs->maccfg1); 53036aa8d03178 drivers/net/ethernet/freescale/ucc_geth.c Maxime Chevallier 2024-12-03 1624 } ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1625 } ce973b141dfac4 drivers/net/ucc_geth.c Li Yang 2006-08-14 1626 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki