From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EA038FF0B for ; Tue, 13 Jan 2026 13:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768309479; cv=none; b=sETeBZBvmyz20uA+7M28xFo0JLcZ5AKoKsa2UNV+wyMIT70pSEvWbpS0k+G/hUWhDSmMv9xkLIx2n3WTqzwRYdUPdhu4OQJkfsGtxGJCorydTYgwQSp4HjEhY1hM9EVNq25UxZ/3pNERNfEMgxvdgcg6KVdpGanX9JdYDPhUIRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768309479; c=relaxed/simple; bh=f1smv8y9rYnHFcqj5jCfR+O+3u96mNBPMUNJqZeNiOE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A6baKaWDm1duGht7tlxbEQYNTGd76iYeRWcqnZ7SLRVkv7Z9O3EEMAA/e66BGRLYsgMP3aoRi7/kqirORsTLydkRP3mRJYE5R4WQq2W5ZkOPh9PWBcl+l3Kw99NlYT5YzeooCj64T0+njMD+KU7caDgWo/v6bgI84DUQ84IZYus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lUOwiqaS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FhSI5bVz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lUOwiqaS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FhSI5bVz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D74Oee176949 for ; Tue, 13 Jan 2026 13:04:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=LrBsZObGco9NNSkqSndahBNl GYG6lpT3RWJ1IaZFwls=; b=lUOwiqaS8c/BRPD8rg7glwhP5sLXjAe2QS/iAfRE 6Rz9cd7faEMGMaULOtXhQ0DvY53nAiBuDrt0zInxo0/oqK8jHbe0NBQemSSqr8U7 lKr5i+nzgTi+aZV/I3POjWcilZ6hMaSwYkMDuyQ9lqxGiVSfy73iZrOtpVXU5/bA Uy6iPd92Id0ny6RC7kps0gGVIYIJfnZipRJq0umvj8yJS5RhKyvSBQ/L7QGIZ2dJ UBgwwN5k2KeQooO/5+OezHbtwiEfYatWirMNLWs1JLUBLHFiyLfSiu/M7tHt/tbo B5bwjXvWyycyQxOgXIQ6Gul+zQlu1Rz2zd6zn89Fh2iZZA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bn52f39na-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 13:04:37 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f13989cd3so176009675ad.1 for ; Tue, 13 Jan 2026 05:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768309476; x=1768914276; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LrBsZObGco9NNSkqSndahBNlGYG6lpT3RWJ1IaZFwls=; b=FhSI5bVzYLvDFWHdlbxdlmD+4dpT2PPXsG9FEcKoFSRD2Rhifxj0cgY/eH0/JC8/XO g0qjgvXoOUgfLoXzZA90QujqZWhV0cJDofePjqtk86rZOHZ8qIRcmH44TM9uHIMfMsOv 6xeJG9JJA+LxOLtQNja27avDDJJ8e9HXJaA5/c6qnNe0FZ/SVylGwfRY3u8MCrR9f+jQ SXp8fNZPRBgcC4tQP0ZtpzooRVcbnQSy+WzmhVWq8LVIUpY2KP0FwnZgFMf/TJlgNOns 7KtHJ45S5gpSfLCg2yiuzx3MdSedV7oVL/je5FW4iJCzzGThGkZ/FzhoSrLwS3fs/JQC yePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768309476; x=1768914276; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LrBsZObGco9NNSkqSndahBNlGYG6lpT3RWJ1IaZFwls=; b=bouE05RvjcnokCPr9W66dnAPjO6Ig0lH7dr123/C7f0jGpuhdlcAK2WZG3uKNfRyNa Fe9HWOoC/RUsjbyLEdtOcnpSW6Ri2cTpMz2GB8ehobnoDSDGFve85tqu9rmBOWJWE3wN KLDUML+hjNH28aaQ5PrqtEr+MQgbmmgSNDug4xa4UkeJ8z8uM/DmPZc2dUBf0eCNLDDi dgT/rkDcjLTC7umThPkrdQviZtpvFTCGTChZoXxNUyvUTyEx1jwJCtDFkZLnaYxTTW5n YxWmT25G2DPQ4kwFx7LCeHSNofyboL9i/fxpeKOOqD6VJxtqQCOg3C66NuvU4FCCkxxB Iwfw== X-Forwarded-Encrypted: i=1; AJvYcCXgF0IaMDdD+uqxwrfQfal050FkpwpkCcwrCYm0OjiEt3ShTGwdXlHPJBfXQqN3KGaTkNqyTzJoTvKJPgY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxva9jtxwxJ5zaphkcNPO7rNqTh+HUBpFPoDryRzuHFuXFatdaQ 4fE4VV8oH7Ko7xT2pxKqx7txpfLwfMShu5vetoVjKVDHikL2qfeadcjMd/57o8ZGSuB5pMYmh6S 7mriH3RgWF+KY9PWZcj/UYPsSXXMjIqy/6qIIISqNi74blGDyxhnQmrowpoqIP/twHrY= X-Gm-Gg: AY/fxX6w+FIiLrbtIf8CMnmJYgp6o5Nj8owfRLc3P3Xdnrx2QvpKRtlk0uiff097qUX 82EgPpV+KgwLlV3DBJhymbTj8aAlHg+urstii7CgmZY5qRC+5IVCTRdtV9RupoEooGD0hHHcEV2 9sAVjd/XCgvl81pRzmYvH6C7RWwSzO0zbB9yVRKhaaGsPgNGN0sOPS+pf9bMsH0jwedozHd88ng VucQLGCbi1acP4E+AhV8CRCkdSOT9c/VXJXZF6uv/nUbN/ueEAzCLqQwn5h5m0dLFwNgTZq5H1s H81TOMggX2VGxndfZW49kysLSl2yXvTZ2rsjjqTE4RzK+ce1HZ+Mp/JqK1Xww8DkRfh2zCWFtb0 j/mWPVcidpSQK0tYzP3hbz0Zj1pGw5CxAHqvF X-Received: by 2002:a17:903:138d:b0:2a0:f828:24a3 with SMTP id d9443c01a7336-2a3ee485087mr129935815ad.28.1768309476010; Tue, 13 Jan 2026 05:04:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpKvGzrZdXR5BWwgsLxpcnOulsUHWmcEnI6Ymv+Xl0EvB/JBQjr9f/Ye2wpymi4KJtZM5E8Q== X-Received: by 2002:a17:903:138d:b0:2a0:f828:24a3 with SMTP id d9443c01a7336-2a3ee485087mr129935575ad.28.1768309475307; Tue, 13 Jan 2026 05:04:35 -0800 (PST) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a31dsm201124835ad.9.2026.01.13.05.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 05:04:34 -0800 (PST) Date: Tue, 13 Jan 2026 18:34:28 +0530 From: Mukesh Ojha To: Konrad Dybcio Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Enable download mode register write Message-ID: <20260113130428.n2kuo2d2tkoosws2@hu-mojha-hyd.qualcomm.com> References: <20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com> <433fc01b-0e59-49bf-afdc-a23e815cc563@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDEwOSBTYWx0ZWRfX3g3vLLWuGOUV 3ulMzXGRt/uCJobq+Lk5kq9VvYp9n3ZYKcmYgTEqswEBXB6I9VKMITCUhg66Ixyo4yBxR+U7hL3 G0JLmOnzR6qIfQgLMM4+TcQjhc7ZjtgbfD0JcdBZp8Ped4eAyW26WWCYuPH6krXdgOqK2ofYGVN 2LO9WaoQV13tFZfY0hfOIP/itzX8YgGHw560RCZeYOFDk+MSip2c3O8K0yMFsd+jlCneAsVPX6x P9OJbQDPejLnG0KvAK06aYrIZDvA3GmS/LyDSbRqJiNPDUw1oE1A+uNu03UU8q7YIyohhzUu7wp gfVFA0EWoDAaRy9IBAd5FnrbN78+VhR/M6Zeud47m2Tj/GJUNt6RCjWjGd3jd2slPPIt7cbxs0z ntpT71dE8RLAeQIlSwfmjtAV6bibbeIRwEYRqky0fDl6clETB/UgCiVZ0UOi+zlOMtrV+1h9iCJ KarA1KHVrt5SsxHsL9Q== X-Authority-Analysis: v=2.4 cv=TcCbdBQh c=1 sm=1 tr=0 ts=696642e5 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=uypVyKnD2Y_mXFCH2p8A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: GQpyXFp4swRISi4WZX3xuUTHmSSV1I-2 X-Proofpoint-ORIG-GUID: GQpyXFp4swRISi4WZX3xuUTHmSSV1I-2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130109 On Tue, Jan 13, 2026 at 10:20:58AM +0100, Konrad Dybcio wrote: > On 1/13/26 10:16 AM, Konrad Dybcio wrote: > > On 1/12/26 4:17 PM, Mukesh Ojha wrote: > >> Enable download mode setting for sm8750 which can help collect > >> ramdump for this SoC. > >> > >> Signed-off-by: Mukesh Ojha > >> --- > > > > Reviewed-by: Konrad Dybcio > > Actually no, we have a mess to undo.. > > There's already this node: > > tcsrcc: clock-controller@f204008 { > compatible = "qcom,sm8750-tcsr", "syscon"; > reg = <0x0 0x0f204008 0x0 0x3004>; > > clocks = <&rpmhcc RPMH_CXO_CLK>; > > #clock-cells = <1>; > #reset-cells = <1>; > }; > > That's located at the rear end of TLMM (someone had a funny idea to > move registers around when designing this specific SoC) > > Problem is, those registers aren't actually "TCSRCC", not even "TCSR" > Physically, they belong to the TLMM register window (which starts at > the base it promises under the TLMM node today and is 0xf0_0000-long. > > What we should have done for a fairer representation is make TLMM a > clock provider on this specific platform > > qcom,sm8750-tcsr binds the tcsrcc driver, so we can't describe the > actual TCSR (as in this patch).. we'll have to break something.. > + syscon: syscon@1fc0000 { + compatible = "syscon"; + reg = <0 0x01fc0000 0 0x30000>; + }; What about above ? > Konrad -- -Mukesh Ojha